Age | Commit message (Collapse) | Author | Files | Lines |
|
R=r
CC=golang-dev
http://codereview.appspot.com/1664043
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1684046
|
|
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/1717046
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1724042
|
|
gob: substitute slice for map
R=r
CC=golang-dev
http://codereview.appspot.com/1699045
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1667048
|
|
netchan, rpc, websocket: run test servers on 127.0.0.1,
to avoid conflict with OS X firewall.
TBR=r
CC=golang-dev
http://codereview.appspot.com/1689046
|
|
We didn't mention this explicitly during our discussions,
but I think it fits the "identical types are spelled identically"
rule that we used.
R=gri, iant, ken2, r, rsc1
CC=golang-dev
http://codereview.appspot.com/1698043
|
|
Currently to install a command, you have to manually
goinstall each of the remote packages that it depends on.
This patch lets goinstall P work where P is
contains files in package main.
It does not actually build the package, but
it installs all of its dependencies and prints a message
to that effect.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1301043
Committer: Russ Cox <rsc@golang.org>
|
|
Based on the review of CL 1723044, I've changed the installation instructions
for the vim syntax files to suggest symlinking the files rather than copying
the files. Also the wording has changed to be more consistent.
R=golang-dev, Kyle Lemons, adg
CC=golang-dev
http://codereview.appspot.com/1702045
Committer: Andrew Gerrand <adg@golang.org>
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1736042
|
|
update other code to match.
R=r
CC=golang-dev
http://codereview.appspot.com/1680044
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1732043
|
|
TBR=r
CC=golang-dev
http://codereview.appspot.com/1734042
|
|
x.go:13: cannot use t (type T) as type Reader in assignment:
T does not implement Reader (Read method requires pointer receiver)
x.go:19: cannot use q (type Q) as type Reader in assignment:
Q does not implement Reader (missing Read method)
have read()
want Read()
x.go:22: cannot use z (type int) as type Reader in assignment:
int does not implement Reader (missing Read method)
x.go:24: too many arguments to conversion to complex: complex(1, 3)
R=ken2
CC=golang-dev
http://codereview.appspot.com/1736041
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1677047
|
|
This sets up vim to work out of the box with go programs as long as syntax
highlighting is enabled. Both files must be copied to the vim runtime
directory in order for the file-type detection and syntax loading to work.
R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/1723044
Committer: Andrew Gerrand <adg@golang.org>
|
|
TBR=r
CC=golang-dev
http://codereview.appspot.com/1706044
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1700043
|
|
R=rsc
CC=golang-dev, r
http://codereview.appspot.com/1706043
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1693043
Committer: Rob Pike <r@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1689042
Committer: Rob Pike <r@golang.org>
|
|
R=iant, ken2, r, r2, ken3
CC=golang-dev
http://codereview.appspot.com/1686044
|
|
R=rsc, iant
CC=golang-dev
http://codereview.appspot.com/1718042
|
|
R=rsc, iant
CC=golang-dev
http://codereview.appspot.com/1694044
|
|
This CL replaces my earlier http://codereview.appspot.com/1640044/show
in which Continue handling was explicit. Instead, this CL makes
it automatic. Reading from Body() is an implicit acknowledgement
that the request headers were fine and the body is wanted. In that
case, the 100 Continue response is written automatically when the
request continues the "Expect: 100-continue" header.
R=rsc, adg
CC=golang-dev
http://codereview.appspot.com/1610042
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
TBR=rsc
CC=golang-dev
http://codereview.appspot.com/1675047
|
|
R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/1707042
|
|
While we're at it, clean up and test the code to guarantee we see every byte when
the text is erroneous UTF-8.
Fixes issue 866.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1712042
|
|
Fixes issue 852.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1680042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1698041
Committer: Rob Pike <r@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1703041
|
|
Fix a bug that caused it to ignore field widths.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1704041
|
|
This shortens, simplifies and regularizes the code significantly.
(Improvements to reflect could make another step.)
Passes all.bash.
One semantic change occurs: The String() method changes
behavior. It used to run only for string formats such as %s and %q.
Instead, it now runs whenever the item has the method and the
result is then processed by the format as a string. Besides the
regularization, this has three effects:
1) width is honored for String() items
2) %x works for String() items
3) implementations of String that merely recur will recur forever
Regarding point 3, example from the updated documentation:
type X int
func (x X) String() string { return Sprintf("%d", x) }
should cast the value before recurring:
func (x X) String() string { return Sprintf("%d", int(x)) }
R=rsc
CC=golang-dev
http://codereview.appspot.com/1613045
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1701041
|
|
It fails with 6g. Once 6g is fixed up I will extend the value tests.
R=rsc, iant
CC=golang-dev
http://codereview.appspot.com/1677043
|
|
Change TrimRight and TrimLeft to use these functions.
Incidentally fix minor bug in TrimRight.
Add some test cases for this.
YMMV whether it's worth saving the closure allocation.
R=r, r2
CC=golang-dev, hoisie, rsc
http://codereview.appspot.com/1198044
Committer: Rob Pike <r@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1677042
|
|
various cleanup, deleting unused code
R=ken2
CC=golang-dev
http://codereview.appspot.com/1663041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1662041
|
|
Make dpix variable names consistent.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1563041
|
|
R=gri, iant, ken2, r, r2
CC=golang-dev
http://codereview.appspot.com/1632041
|
|
Cleans up a few other corner cases too.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1592045
|
|
Cannot assume that g == m->curg at time of signal.
Must save actual g and restore.
Fixes flaky crashes with messages like
throw: malloc mlookup
throw: malloc/free - deadlock
throw: unwindstack on self
throw: free mlookup
(and probably others) when running cgo.
R=iant
CC=golang-dev
http://codereview.appspot.com/1648043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1597044
|
|
executes.
R=golang-dev
CC=golang-dev
http://codereview.appspot.com/1641043
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1627042
|
|
There's only one Go object file per package now,
so there's no need to parse the metadata and merge
metadata from multiple files. Just save the original
and use it as __.PKGDEF verbatim.
R=r
CC=golang-dev
http://codereview.appspot.com/1647042
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1597043
|
|
This avoids a crash when using cgo where glibc's malloc thinks
that it can use some of the memory following the symbol table.
This fails because the symbol table is mapped read-only, which
affects the whole page.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1616042
|