Age | Commit message (Collapse) | Author | Files | Lines |
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1652041
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1615042
|
|
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/1555042
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1585041
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1649041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1633042
|
|
Although technically incorrect, we want this in order to parse X.509
certificates where a wildcard hostname ("*.example.com") has been put
into a PrintableString.
Fixes issue 850.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1615043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1644042
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1599043
|
|
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/1636043
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1626043
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1644041
|
|
* disallow surrogate pair runes.
* diagnose impossible type assertions
* eliminate another static buffer.
* do not overflow lexbuf.
* add -u flag to disable package unsafe.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1619042
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1631041
|
|
* Code for assignment, conversions now mirrors spec.
* Changed some snprint -> smprint.
* Renamed runtime functions to separate
interface conversions from type assertions:
convT2I, assertI2T, etc.
* Correct checking of \U sequences.
Fixes issue 840.
Fixes issue 830.
Fixes issue 778.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1303042
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1620042
|
|
(remains of the semicolon conversion)
R=rsc
CC=golang-dev
http://codereview.appspot.com/1623041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1621041
|
|
(caused certain files to not be idempotent under gofmt)
- corrected golden files for go/printer
- slightly simplified some code in nodes.go (no impact on formatting)
- these changes have no impact on gofmt output of .go files under src, misc
fallthrough statement considered harmful!
R=rsc
CC=golang-dev
http://codereview.appspot.com/1593042
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1616041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1614041
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1612041
|
|
*T2 implements I2, but T2 does not.
R=gri
CC=golang-dev
http://codereview.appspot.com/1613041
|
|
Fixes issue 844.
R=ken2, rsc, ken3
CC=golang-dev
http://codereview.appspot.com/1593041
|
|
Fixes issue 827.
R=ken2
CC=golang-dev, rsc
http://codereview.appspot.com/1592041
|
|
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/1590041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1581041
|
|
Specifically:
- introduced notion of "underlying type"
- removed notion of type compatibility
- consolidated rules about assignment compatibility in
assignment compatibility section
- be consistent with specyfing that nil is the value
for uninitialized variables that can be nil (this
was not specified clearly for pointers, functions, interfaces)
- added/fixed various related links throughout
- clarify language on conversions
R=rsc, r, iant, ken2
CC=golang-dev
http://codereview.appspot.com/1536041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1514041
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1535041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1539042
|
|
R=rsc, iant
CC=golang-dev
http://codereview.appspot.com/1567041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1559041
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1548042
|
|
Time (us) to draw a 200x200 src onto an image.RGBA dst with the Over
operator. Each case was measured three separate times, and the sorted
times are reported.
Fill case (where src is an image.ColorImage):
Before:
7438, 7511, 7526
After:
3073, 3087, 3102
Copy case (where src is an image.RGBA):
Before:
9506, 9510, 9563
After:
5262, 5300, 5344
R=rsc
CC=golang-dev
http://codereview.appspot.com/1532041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1533041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1518042
|
|
Specifically:
- Simplified definition of comparison compatibility and folded into
section on comparison operators since it's only used there.
This is a small language change/cleanup. As a consequence:
- An interface value may now be compared against a non-interface value.
- Channels with opposite directions cannot be compared directly anymore
(per discussion with rsc).
R=rsc, r, iant, ken2
CC=golang-dev
http://codereview.appspot.com/1462041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1472042
|
|
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/972046
Committer: Rob Pike <r@golang.org>
|
|
- cannot send body
- should not send body-related headers
R=r
CC=golang-dev
http://codereview.appspot.com/1499041
|
|
Also fix an interface bug: white-space-delimited doesn't work well for cases like "%d, %d" on "23, 23")
R=rsc
CC=golang-dev
http://codereview.appspot.com/1502041
|
|
Was timing Exp, not Exp2.
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/1521042
Committer: Rob Pike <r@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1473042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1522041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1503041
|
|
charclass to avoid unnecessarily iterating over ranges.
Also, use the fact that IntVector is an []int to avoid method calls.
On my machine, this brings us from ~27500 ns/op to ~17500 ns/op in the benchmark I've added (it is also faster in the case where a range check
doesn't help, added a benchmark for this too.)
I'd also like to propose that "[]", and "[^]" be disallowed. They aren't useful as far as I can tell, they aren't widely supported, and they make reasoning about character classes a bit more complicated.
R=r
CC=golang-dev
http://codereview.appspot.com/1495041
Committer: Rob Pike <r@golang.org>
|
|
Also added more tests for acosh, hypot, log, log10, log2
in all_test.go.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1417041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/1238044
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1486041
|