Age | Commit message (Collapse) | Author | Files | Lines |
|
Fix a bug that caused it to ignore field widths.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1704041
|
|
This shortens, simplifies and regularizes the code significantly.
(Improvements to reflect could make another step.)
Passes all.bash.
One semantic change occurs: The String() method changes
behavior. It used to run only for string formats such as %s and %q.
Instead, it now runs whenever the item has the method and the
result is then processed by the format as a string. Besides the
regularization, this has three effects:
1) width is honored for String() items
2) %x works for String() items
3) implementations of String that merely recur will recur forever
Regarding point 3, example from the updated documentation:
type X int
func (x X) String() string { return Sprintf("%d", x) }
should cast the value before recurring:
func (x X) String() string { return Sprintf("%d", int(x)) }
R=rsc
CC=golang-dev
http://codereview.appspot.com/1613045
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1701041
|
|
It fails with 6g. Once 6g is fixed up I will extend the value tests.
R=rsc, iant
CC=golang-dev
http://codereview.appspot.com/1677043
|
|
Change TrimRight and TrimLeft to use these functions.
Incidentally fix minor bug in TrimRight.
Add some test cases for this.
YMMV whether it's worth saving the closure allocation.
R=r, r2
CC=golang-dev, hoisie, rsc
http://codereview.appspot.com/1198044
Committer: Rob Pike <r@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1677042
|
|
various cleanup, deleting unused code
R=ken2
CC=golang-dev
http://codereview.appspot.com/1663041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1662041
|
|
Make dpix variable names consistent.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1563041
|
|
R=gri, iant, ken2, r, r2
CC=golang-dev
http://codereview.appspot.com/1632041
|
|
Cleans up a few other corner cases too.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1592045
|
|
Cannot assume that g == m->curg at time of signal.
Must save actual g and restore.
Fixes flaky crashes with messages like
throw: malloc mlookup
throw: malloc/free - deadlock
throw: unwindstack on self
throw: free mlookup
(and probably others) when running cgo.
R=iant
CC=golang-dev
http://codereview.appspot.com/1648043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1597044
|
|
executes.
R=golang-dev
CC=golang-dev
http://codereview.appspot.com/1641043
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1627042
|
|
There's only one Go object file per package now,
so there's no need to parse the metadata and merge
metadata from multiple files. Just save the original
and use it as __.PKGDEF verbatim.
R=r
CC=golang-dev
http://codereview.appspot.com/1647042
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1597043
|
|
This avoids a crash when using cgo where glibc's malloc thinks
that it can use some of the memory following the symbol table.
This fails because the symbol table is mapped read-only, which
affects the whole page.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1616042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1381041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1652041
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1615042
|
|
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/1555042
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1585041
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1649041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1633042
|
|
Although technically incorrect, we want this in order to parse X.509
certificates where a wildcard hostname ("*.example.com") has been put
into a PrintableString.
Fixes issue 850.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1615043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1644042
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1599043
|
|
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/1636043
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1626043
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1644041
|
|
* disallow surrogate pair runes.
* diagnose impossible type assertions
* eliminate another static buffer.
* do not overflow lexbuf.
* add -u flag to disable package unsafe.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1619042
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1631041
|
|
* Code for assignment, conversions now mirrors spec.
* Changed some snprint -> smprint.
* Renamed runtime functions to separate
interface conversions from type assertions:
convT2I, assertI2T, etc.
* Correct checking of \U sequences.
Fixes issue 840.
Fixes issue 830.
Fixes issue 778.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1303042
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1620042
|
|
(remains of the semicolon conversion)
R=rsc
CC=golang-dev
http://codereview.appspot.com/1623041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1621041
|
|
(caused certain files to not be idempotent under gofmt)
- corrected golden files for go/printer
- slightly simplified some code in nodes.go (no impact on formatting)
- these changes have no impact on gofmt output of .go files under src, misc
fallthrough statement considered harmful!
R=rsc
CC=golang-dev
http://codereview.appspot.com/1593042
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1616041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1614041
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1612041
|
|
*T2 implements I2, but T2 does not.
R=gri
CC=golang-dev
http://codereview.appspot.com/1613041
|
|
Fixes issue 844.
R=ken2, rsc, ken3
CC=golang-dev
http://codereview.appspot.com/1593041
|
|
Fixes issue 827.
R=ken2
CC=golang-dev, rsc
http://codereview.appspot.com/1592041
|
|
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/1590041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1581041
|
|
Specifically:
- introduced notion of "underlying type"
- removed notion of type compatibility
- consolidated rules about assignment compatibility in
assignment compatibility section
- be consistent with specyfing that nil is the value
for uninitialized variables that can be nil (this
was not specified clearly for pointers, functions, interfaces)
- added/fixed various related links throughout
- clarify language on conversions
R=rsc, r, iant, ken2
CC=golang-dev
http://codereview.appspot.com/1536041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1514041
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1535041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1539042
|