Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1741047
|
|
panic if base is invalid.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1702050
|
|
Use a count of -1 for infinity. Ditto for Replace.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1704044
Committer: Rob Pike <r@golang.org>
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1693047
|
|
libmach: disassemble CMPPD as 6a expects
R=ken2
CC=Charlie Dorian, golang-dev
http://codereview.appspot.com/1704046
|
|
(Here, quoted strings are the official AMD names.)
The amd64 "movsxd" instruction, when invoked
with a 64-bit REX prefix, moves and sign extends
a 32-bit value from register or memory into a
64-bit register. 6.out.h spells this MOVLQSX.
6.out.h also includes MOVLQZX, the zero extending
version, which it implements as "movsxd" without
the REX prefix. Without the REX prefix it's only sign
extending 32 bits to 32 bits (i.e., not doing anything
to the bits) and then storing in a 32-bit register.
Any write to a 32-bit register zeros the top half of the
corresponding 64-bit register, giving the advertised effect.
This particular implementation of the functionality is
non-standard, because an ordinary 32-bit "mov" would
do the same thing.
Because it is non-standard, it is often mishandled or
not handled by binary translation tools like valgrind.
Switching to the standard "mov" makes the binaries
work better with those tools.
It's probably useful in 6c and 6g to have an explicit
instruction, though, so that the intent of the size
change is clear. Thus we leave the concept of MOVLQZX
and just implement it by the standard "mov" instead of
the non-standard 32-bit "movsxd".
Fixes issue 896.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1733046
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1705041
Committer: Russ Cox <rsc@golang.org>
|
|
R=iant
CC=golang-dev
http://codereview.appspot.com/1666048
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1650041
|
|
With these changes, goinstall is now able to use branches
maintained with Bazaar located in Launchpad.
Project aliases such as /project and /project/series are
supported in addition to specific user or team branches
such as /~user/project/branch. Temporary branches under
the +junk special project are also supported.
As a curious side effect, since Launchpad is able to import
code from other locations, they can be indirectly
accessible too if desired.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1699050
Committer: Russ Cox <rsc@golang.org>
|
|
R=adg
CC=golang-dev
http://codereview.appspot.com/1693046
|
|
The Makefile and cgo now rewrite / to _ when creating the path.
The .so for gosqlite.googlecode.com/hg/sqlite is named
cgo_gosqlite.googlecode.com_hg_sqlite.so, and then 6l and 8l
both include a default rpath of $GOROOT/pkg/$GOOS_$GOARCH.
This should make it easier to move binaries from one system
to another.
Fixes issue 857.
R=iant, r
CC=golang-dev
http://codereview.appspot.com/1700048
|
|
Fixes issue 868.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1695049
|
|
Fixes issue 879.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1678048
|
|
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/1665047
Committer: Russ Cox <rsc@golang.org>
|
|
This is the Replace I suggested in the review of CL 1114041.
It's true that we already have
regexp.MustCompile(regexp.QuoteMeta(old)).ReplaceAll(s, new)
but because this Replace is doing a simpler job it is
simpler to call and inherently more efficient.
I will add the bytes implementation and tests to the
CL after the strings one has been reviewed.
R=r, cw
CC=golang-dev
http://codereview.appspot.com/1731048
|
|
(addressing comments from 1741045)
R=r
CC=golang-dev
http://codereview.appspot.com/1678047
|
|
For generating non-self-signed certs we need to be able to specify a
public key (for the signee) which is different from the private key (of
the signer).
R=rsc
CC=golang-dev
http://codereview.appspot.com/1741045
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1319042
Committer: Russ Cox <rsc@golang.org>
|
|
Benchmark of exp to 28 ns/op from 64 ns/op,
on 2.53GHz Intel Core 2 Duo.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1594041
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 834.
R=rsc, brainman
CC=golang-dev
http://codereview.appspot.com/1686047
Committer: Russ Cox <rsc@golang.org>
|
|
One goroutine started up and was waiting in rw. Then another
goroutine decided to close the pipe. The closing goroutine
stalled calling p.io.Lock() in pipeHalf.close. (This happened
in gccgo). If the closing goroutine had been able to set the
ioclosed flag, it would have gone on to tell the runner that
the pipe was closed, which would then send an EINVAL to the
goroutine sleeping in rw. Unlocking p.io before sleeping in
rw avoids the race.
R=rsc, rsc1
CC=golang-dev
http://codereview.appspot.com/1682048
|
|
Fixes issue 893.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1687045
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1729046
|
|
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/1727043
|
|
Fixes issue 761.
R=PeterGo, adg, rsc
CC=golang-dev
http://codereview.appspot.com/1121042
Committer: Russ Cox <rsc@golang.org>
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1679045
|
|
R=rsc, Mateusz Czaplinski
CC=golang-dev
http://codereview.appspot.com/1600041
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1678046
|
|
Fixes issue 758.
R=rsc, adg
CC=golang-dev
http://codereview.appspot.com/1078041
Committer: Andrew Gerrand <adg@golang.org>
|
|
Fixes issue 886.
R=r
CC=golang-dev
http://codereview.appspot.com/1667051
|
|
Fixes issue 822.
Credit to http://codereview.appspot.com/1442041 by danielfleischman
R=rsc
CC=golang-dev
http://codereview.appspot.com/1738047
|
|
Fixes issue 845.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1673049
|
|
fixes issue 892
R=rsc
CC=golang-dev
http://codereview.appspot.com/1745042
|