summaryrefslogtreecommitdiff
path: root/lib/codereview/codereview.py
AgeCommit message (Collapse)AuthorFilesLines
2010-03-03codereview.py: fix for compatibility with hg >=1.4.3Andrew Gerrand1-1/+1
hg.parseurl now returns a two-value tuple; codereview.py expected 3. Changed to merely take the first return value. R=rsc, iant CC=golang-dev http://codereview.appspot.com/223087
2010-01-28codereview: make sure each mail has a reviewerRuss Cox1-2/+10
R=r CC=golang-dev http://codereview.appspot.com/196050
2010-01-27codereview: correct handling of files created with hg cpRuss Cox1-5/+2
R=r CC=golang-dev http://codereview.appspot.com/194118
2010-01-20codereview: accommodate recent change to ui.promptRuss Cox1-2/+11
Fixes issue 525. R=r CC=golang-dev http://codereview.appspot.com/190044
2010-01-13codereview: split name list only on commas; some user names have spacesRuss Cox1-15/+16
R=r CC=golang-dev http://codereview.appspot.com/184069
2010-01-09codereview: do not send mail when submitting for othersRuss Cox1-20/+20
rename original_author to copied_from so that it reads better when used as a condition. R=r CC=golang-dev http://codereview.appspot.com/185045
2010-01-07codereview: repeated hg mail sends "PTAL"Russ Cox1-9/+29
also send out hg mail for TBR submits R=r CC=golang-dev http://codereview.appspot.com/183137
2009-12-15codereview: add golang-dev@googlegroups.comRuss Cox1-40/+33
automatically in "hg mail". also, avoid "empty list means all modified files in client" bug R=gri, cw CC=golang-dev http://codereview.appspot.com/174072
2009-12-13Ported godefs to Windows.Hector Chu1-0/+2
R=rsc http://codereview.appspot.com/164049 Committer: Russ Cox <rsc@golang.org>
2009-12-03codereview: do not gofmt deleted filesRuss Cox1-0/+1
R=r http://codereview.appspot.com/164083
2009-12-02codereview: move reviewers to cc line after submit,Russ Cox1-11/+18
so that the issue stops showing up on the per-reviewer dashboard page. R=r http://codereview.appspot.com/164075
2009-12-02 lxml.etree is the wrong location for this alt packageDevon H. O'Dell1-1/+1
on my linux machine this is the correct one. lxml.etree exists with an ElementTree class, but does not contain an .XML method. R=rsc http://codereview.appspot.com/163082 Committer: Russ Cox <rsc@golang.org>
2009-12-02xml.etree can also be lxml.etree (e.g. CentOS 5.4 with Python 2.4.3)Devon H. O'Dell1-1/+4
R=rsc CC=golang-dev http://codereview.appspot.com/164053 Committer: Russ Cox <rsc@golang.org>
2009-11-30Ports of lib9, libbio and libmach to Windows.Hector Chu1-1/+1
R=rsc http://codereview.appspot.com/157159 Committer: Russ Cox <rsc@golang.org>
2009-11-30codereview: allow editing of local CL descriptionRuss Cox1-1/+8
between hg clpatch and hg submit. R=r http://codereview.appspot.com/162059
2009-11-20gofmt -r 'α[β:len(α)] -> α[β:]' -w test/benchRuss Cox1-1/+2
except chameneosredux which i know is being edited require gofmt for test/bench R=r http://codereview.appspot.com/157110
2009-11-20codereview: handle UTF-8 in message descriptionsRuss Cox1-1/+1
what a terrible way to implement strings R=r http://codereview.appspot.com/156116
2009-11-20codereview: make hg sync work with Mercurial 1.4Russ Cox1-10/+21
R=r http://codereview.appspot.com/157102
2009-11-17codereview: more attempts at robustness in the face of unexpected exceptionsRuss Cox1-36/+39
R=r http://codereview.appspot.com/156062
2009-11-17codereview: handle spaces and other unexpected chars in nicknamesRuss Cox1-1/+3
R=r http://codereview.appspot.com/157053
2009-11-17case insensitive matching in CONTRIBUTORS fileRob Pike1-1/+1
R=rsc http://codereview.appspot.com/157043
2009-11-17codereview: discard \r characters (sigh)Russ Cox1-0/+2
R=r http://codereview.appspot.com/157041
2009-11-17codereview: add clpatch --ignore_hgpatch_errors.Russ Cox1-1/+2
of limited utility but good for creating the metadata for an AUTHORS/CONTRIBUTORS change even if the patch doesn't apply cleanly. R=r http://codereview.appspot.com/154140
2009-11-17Pass ui into PostMessage to avoid nasty/confusing exceptionDevon H. O'Dell1-4/+4
R=rsc http://codereview.appspot.com/155079 Committer: Russ Cox <rsc@golang.org>
2009-11-12codereview: clpatch tweaksRuss Cox1-3/+7
R=agl1 http://codereview.appspot.com/152114
2009-11-10default to codereview.appspot.comRuss Cox1-6/+1
R=r http://codereview.prom.corp.google.com/1026040
2009-11-08make hg mail more forgiving:Russ Cox1-2/+7
create CL first, even if gofmt is needed or no reviewers listed. R=r http://go/go-review/1025025
2009-11-08assorted cleanupRuss Cox1-1/+9
R=r, iant CC=go-dev http://go/go-review/1025024
2009-11-08another attempt at utf-8 uploads.Russ Cox1-7/+7
the last attempt broke uploads of binary files like .png R=r http://go/go-review/1026025
2009-11-07fix authentication in parallel LoadAllCLRuss Cox1-4/+11
R=r http://go/go-review/1024018
2009-11-07require Mercurial 1.3 again (how did that get dropped?)Russ Cox1-17/+40
avoid deprecation warning about os.popen3 R=r http://go/go-review/1026018
2009-11-06codereview: print gofmt message when abortingRuss Cox1-3/+3
R=r CC=vish http://go/go-review/1026013
2009-11-06make temporary google.com -> golang.org hack more sophisticatedRuss Cox1-8/+8
R=r http://go/go-review/1024013
2009-11-06require gofmt for all $GOROOT/src/.../*.go.Russ Cox1-8/+31
try harder to post messages to rietveld. R=gri, r CC=go-dev http://go/go-review/1024006
2009-11-05fix UTF-8 upload bugRuss Cox1-4/+7
TBR=r http://go/go-review/1026001
2009-11-05codereview: new commandsRuss Cox1-31/+231
* clpatch * download * submit, on behalf of clpatch stir hgpatch to fix a few bugs R=r CC=go-dev http://go/go-review/1016051
2009-11-05add -l flag to hg gofmt.Russ Cox1-4/+9
don't apply gofmt to non-go files during upload check. R=r http://go/go-review/1016048
2009-11-04add "hg gofmt" to run all modified files through gofmt.Russ Cox1-12/+93
add check before Upload, for now disabled by default, that files do not change when run through gofmt. enable by adding [codereview] force_gofmt = True to .hgrc or .hg/hgrc. add doc strings for a few more commands. rename codereview-login to code-login to make module doc visible. R=r CC=gri http://go/go-review/1018056
2009-11-04avoid infinite recursion in matcher.Russ Cox1-15/+79
after sync (or sync --local), clean up repository: * look for and close CLs submitted on our behalf * remove unmodified files from CLs * warn about empty CLs R=r http://go/go-review/1017029
2009-11-04various tweaks to code review.Russ Cox1-10/+27
main one is to check at submit time that user name being used in checkin message is listed in the CONTRIBUTORS file. this should catch misconfigurations. another is to cut the @domain part from the R= and CC= lines on checkin messages, so that cc'ing someone on a change does not mean their email address is recorded for all time. R=r CC=go-dev http://go/go-review/1016036
2009-11-02rietveld does not like code reviews with subjects longer than 100 ↵Russ Cox1-1/+3
characters, so trim the line pulled out of the description to avoid the limit. R=r http://go/go-review/1016027
2009-11-01code review: avoid subject changes, fix http_proxy submit bugRuss Cox1-11/+25
R=r http://go/go-review/1016021
2009-11-01code review fixesRuss Cox1-188/+282
* clean up error handling: show Exception info * white space fixes * clean up output when creating CL * simplify hg change command; add hg file * fix stale cookie bug (thanks iant) * in LoadAllCL, load each CL in a different thread, to parallelize the slow web fetches * throw away support for Mercurial before version 1.3 * add @CL-number file pattern for commands like diff * make hg sync show files being sync'ed R=r http://go/go-review/1016016
2009-10-22add codereview-login commandRuss Cox1-0/+15
R=r CC=go-dev http://go/go-review/1012007
2009-10-22fix handling of escaped characters like ' " & < >Russ Cox1-4/+3
R=r http://go/go-review/1013007
2009-10-22Initial checkin of codereview plugin.Russ Cox1-0/+2575
The master copy is going to live elsewhere, but weAPOSTROPHEll keep a copy in the Go tree so that developers donAPOSTROPHEt have to check out two different repositories. R=r CC=go-dev http://go/go-review/1012006
generated by cgit v1.2.3 (git 2.39.1) at 2025-06-06 16:35:24 +0000