Age | Commit message (Collapse) | Author | Files | Lines |
|
R=gri
CC=golang-dev
http://codereview.appspot.com/181155
|
|
R=rsc, r
CC=golang-dev, rog
http://codereview.appspot.com/183116
|
|
tabs after an empty line where not converted.
Also, made it more robust in the presence of
(unexpected) ' ' and '\v' chars in indentation
mode.
R=r
CC=golang-dev
http://codereview.appspot.com/181085
|
|
leading tabs into spaces to ensure a good outcome in
most browsers
R=rsc
http://codereview.appspot.com/165051
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
1st set of files.
R=rsc
CC=agl, golang-dev, iant, ken2, r
http://codereview.appspot.com/180047
|
|
R=rsc
http://codereview.appspot.com/174078
|
|
this breaks the dependency of package io on package bytes.
R=rsc
CC=golang-dev
http://codereview.appspot.com/163085
|
|
- simplified dealing with parse errors: no need to intersperse them in the source
- improve visibility of highlighted identifiers by showing them in bold
R=rsc
http://codereview.appspot.com/163051
|
|
R=gri
CC=r
http://codereview.appspot.com/157149
|
|
R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
|
|
package documentation using templates. The line tag interferes
with the anchor tag introduces by the template.
This fixes an an issue where some headers lost their ability
to link to the respective source code.
R=rsc
http://codereview.appspot.com/154166
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/1024040
|
|
R=rsc, r
http://go/go-review/1025029
|
|
- When providing alternative spellings to a query, do not
prefix it with a package qualifier as the suggestion may
not have any results. Correctly filtering is quite a bit
of work, and clicking the alternative spelling will always
also show the qualified hits if they exist (but also others).
Seems good enough for now.
- Give user feedback when the query syntax was wrong.
- Package names in search results are now links to the respective
package documentation.
- Experimented with excluding main packages and test files
from index with inconclusive results. Code is present and
can be enabled by changing a flag in the source. This needs
some more work.
R=rsc
CC=r, dsymonds
http://go/go-review/1026033
|
|
- don't forget first periods
- look at capitalization of last char before periods
R=rsc
http://go/go-review/1024027
|
|
HTML vs Html, URL vs Url, HTTP vs Http,
current source is 6:1 in favor of the former,
so change instances of the latter.
R=r
CC=go-dev
http://go/go-review/1024026
|
|
- introduced a new run per file containing all spots belonging
to the same kind (e.g. var decl, const decl, etc.)
- more comments, better index.go file organization
R=rsc
http://go/go-review/1026028
|
|
R=rsc
http://go/go-review/1026027
|
|
(this was surprisingly hard to get right in HTML)
- show modification times in source directory listings
- various tweaks
R=rsc
http://go/go-review/1024024
|
|
1st step of renaming dirList.html -> dirlist.html
(OS X filenames are not capitalization-sensitive)
R=rsc
http://go/go-review/1024021
|
|
instead of serving them raw
- path-related cleanups
R=rsc
http://go/go-review/1026021
|
|
- renamed listing.html -> dirList.html
(there is a dirs.html already, it should probably have a better name, too)
R=rsc
http://go/go-review/1025020
|
|
R=rsc
http://go/go-review/1026020
|
|
- formatting in dirs.html is crude, needs better html (open to suggestions),
but shows the synopsis
- many package comments should probably be adjusted such that the first
sentence is more concise
R=rsc, iant
http://go/go-review/1025014
|
|
R=rsc
http://go/go-review/1024004
|
|
R=rsc
http://go/go-review/1018039
|
|
- made package tree handler generic so it can work on any fs tree
- cleanups along the way
R=rsc
CC=r
http://go/go-review/1017020
|
|
(No visual change yet since the comments for
exported code snippets - as shown on the pkg
page - are not yet formatted using the standard
comment intersperse mechanism in the printer.
This is a TODO in the printer.)
R=rsc
http://go/go-review/1016031
|
|
- removed some underbars in section headings for better looks
- various minor tweaks
R=rsc
http://go/go-review/1018026
|
|
also fix a error-printing bug in godoc.
R=gri
http://go/go-review/1016030
|
|
just a single directory
- all pieces present but not well integrated
- directory tree served at the moment under /tree
R=rsc
http://go/go-review/1018016
|
|
and godoc/main.go.
R=gri
CC=r
http://go/go-review/1017005
|
|
- replaced deprecated use of </font> with </span> tag
- added html escaping to godoc formatters where missing
- enabled text format for package documentation
R=rsc
http://go/go-review/1017001
|
|
- sort by package name (instead of package path) for results with snippets
- sort line numbers in results without snippets
- properly characterize package clauses
- experiment with a leaner look: no underlines for top-level godoc links in the left side bar
Still using colors to distinguish results. Next step.
R=rsc
http://go/go-review/1015016
|
|
- added goroutine to automatically index in the background
- added handler for search requests
- added search box to top-level godoc template
- added search.html template for the display of search results
- changes to spec.go because of name conflicts
- added extra styles to style.css (for shorter .html files)
R=rsc
http://go/go-review/1014011
|
|
R=gri
CC=rsc
http://go/go-review/1014008
|
|
R=rsc
http://go/go-review/1013011
|
|
- replacement for p4 CL 35999 (abandoned)
R=rsc
http://go/go-review/1012010
|
|
- handle HTML tagging via (client-installable) Stylers
go/doc:
- basic styler support
- some factoring
- ready to contain the search code (but for now excluded)
doc/style.css:
- updated
doc/go_spec.css:
- cleanup: replace deprecated uses of <font> tag with <span> tag
R=rsc
DELTA=302 (160 added, 62 deleted, 80 changed)
OCL=35973
CL=35996
|
|
R=gri
OCL=35485
CL=35488
|
|
- the first HTML comment in those files is extracted as page
title when serving them
- lib/godoc.html is top-level template for all pages served
- experimented a bit with package documentation layout
(feedback welcome)
- various related cleanups
TODO:
- The / page (doc/root.html) content repeats links that are
in the navigation bar. It needs to be cleaned up.
R=rsc
DELTA=826 (86 added, 692 deleted, 48 changed)
OCL=35230
CL=35245
|
|
R=r
OCL=34731
CL=34731
|
|
R=rsc
DELTA=152 (6 added, 0 deleted, 146 changed)
OCL=34695
CL=34701
|
|
R=rsc
DELTA=217 (216 added, 0 deleted, 1 changed)
OCL=34279
CL=34306
|
|
R=rsc
DELTA=48 (35 added, 3 deleted, 10 changed)
OCL=34030
CL=34034
|
|
R=gri
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=33586
CL=33590
|
|
import "fmt"
var fmt = 1
R=ken
OCL=33556
CL=33561
|
|
- emit line tag id's in html mode
- support for general html tags
- better names for a few identifiers
godoc.go:
- emit links from exported names to source code
(actual placement needs fine-tuning)
R=rsc
DELTA=108 (68 added, 4 deleted, 36 changed)
OCL=32639
CL=32654
|
|
- prepare for generation of HTML id tags and links
- do HTML-escaping in central print routine
- move tabwriter setup into printer
- fixed various TODOs
godoc:
- removed tabwriter setup, need for various HTML-escaping
R=rsc
DELTA=210 (107 added, 36 deleted, 67 changed)
OCL=32612
CL=32616
|
|
- make token.Position.String more robust
TBR=rsc
DELTA=20 (10 added, 6 deleted, 4 changed)
OCL=32564
CL=32564
|