Age | Commit message (Collapse) | Author | Files | Lines |
|
- provide scope to parse functions; if non-nil, parser uses the scope
to declare and lookup identifiers
- resolve forward references where possible
R=rsc
CC=golang-dev
http://codereview.appspot.com/194098
|
|
R=rsc, r, gri
CC=golang-dev
http://codereview.appspot.com/186255
Committer: Rob Pike <r@golang.org>
|
|
- Identifiers refer now to the language entity (Object)
that they denote. At the moment this is at best an
approximation.
- Initial data structures for language entities (Objects)
and expression types (Type) independent of the actual
type notations.
- Initial support for declaring and looking up identifiers.
- Updated various dependent files and added support functions.
- Extensively tested to avoid breakage. This is an AST change.
R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/189080
|
|
Replacement for CL 184084; originally by Roger Peppe (rogpeppe@gmail.com).
R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/189059
|
|
demo at http://wreck:8080/doc/
click on go_talk-20100112.html
R=gri
CC=golang-dev
http://codereview.appspot.com/186137
|
|
now printed using the semicolon-free style.
Removed NoSemis flag and mechanism dealing with
optional semicolons from go/printer.
Updated all go/printer output files using the
semi-colon free style.
Changes have no formatting impact on checked in
go code under src and misc.
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/184068
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/181155
|
|
R=rsc, r
CC=golang-dev, rog
http://codereview.appspot.com/183116
|
|
tabs after an empty line where not converted.
Also, made it more robust in the presence of
(unexpected) ' ' and '\v' chars in indentation
mode.
R=r
CC=golang-dev
http://codereview.appspot.com/181085
|
|
leading tabs into spaces to ensure a good outcome in
most browsers
R=rsc
http://codereview.appspot.com/165051
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
1st set of files.
R=rsc
CC=agl, golang-dev, iant, ken2, r
http://codereview.appspot.com/180047
|
|
R=rsc
http://codereview.appspot.com/174078
|
|
R=rsc
http://codereview.appspot.com/172041
|
|
nodes in the tree are nested with respect to one another.
a simple change to the Visitor interface makes it possible
to do this (for example to maintain a current node-depth, or a
knowledge of the name of the current function).
Visit(nil) is called at the end of a node's children;
this make possible the channel-based interface below,
amongst other possibilities.
It is still just as simple to get the original behaviour - just
return the same Visitor from Visit.
Here are a couple of possible Visitor types.
// closure-based
type FVisitor func(n interface{}) FVisitor
func (f FVisitor) Visit(n interface{}) Visitor {
return f(n);
}
// channel-based
type CVisitor chan Visit;
type Visit struct {
node interface{};
reply chan CVisitor;
};
func (v CVisitor) Visit(n interface{}) Visitor
{
if n == nil {
close(v);
} else {
reply := make(chan CVisitor);
v <- Visit{n, reply};
r := <-reply;
if r == nil {
return nil;
}
return r;
}
return nil;
}
R=gri
CC=rsc
http://codereview.appspot.com/166047
Committer: Robert Griesemer <gri@golang.org>
|
|
this breaks the dependency of package io on package bytes.
R=rsc
CC=golang-dev
http://codereview.appspot.com/163085
|
|
- simplified dealing with parse errors: no need to intersperse them in the source
- improve visibility of highlighted identifiers by showing them in bold
R=rsc
http://codereview.appspot.com/163051
|
|
- removed New(len int) in favor of new(Vector).Resize(len, cap)
- removed Init(len int) in favor of Resize(len, cap)
- runs all.bash
Fixes issue 294.
R=rsc, r, r1
http://codereview.appspot.com/157143
|
|
R=gri
CC=r
http://codereview.appspot.com/157149
|
|
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes issue 115.
R=rsc, dsymonds1
http://codereview.appspot.com/157067
Committer: Russ Cox <rsc@golang.org>
|
|
R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
|
|
package documentation using templates. The line tag interferes
with the anchor tag introduces by the template.
This fixes an an issue where some headers lost their ability
to link to the respective source code.
R=rsc
http://codereview.appspot.com/154166
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/1024040
|
|
fix typo that prevented function bodies from being indexed (ouch!)
R=rsc
http://go/go-review/1024035
|
|
R=rsc, r
http://go/go-review/1025029
|
|
so that first sentence is better for cmd page.
live at http://r45:3456/cmd/
R=gri, r
http://go/go-review/1024034
|
|
- minor related cleanups
R=rsc
http://go/go-review/1025026
|
|
- When providing alternative spellings to a query, do not
prefix it with a package qualifier as the suggestion may
not have any results. Correctly filtering is quite a bit
of work, and clicking the alternative spelling will always
also show the qualified hits if they exist (but also others).
Seems good enough for now.
- Give user feedback when the query syntax was wrong.
- Package names in search results are now links to the respective
package documentation.
- Experimented with excluding main packages and test files
from index with inconclusive results. Code is present and
can be enabled by changing a flag in the source. This needs
some more work.
R=rsc
CC=r, dsymonds
http://go/go-review/1026033
|
|
- don't forget first periods
- look at capitalization of last char before periods
R=rsc
http://go/go-review/1024027
|
|
HTML vs Html, URL vs Url, HTTP vs Http,
current source is 6:1 in favor of the former,
so change instances of the latter.
R=r
CC=go-dev
http://go/go-review/1024026
|
|
- introduced a new run per file containing all spots belonging
to the same kind (e.g. var decl, const decl, etc.)
- more comments, better index.go file organization
R=rsc
http://go/go-review/1026028
|
|
R=rsc
http://go/go-review/1026027
|
|
(this was surprisingly hard to get right in HTML)
- show modification times in source directory listings
- various tweaks
R=rsc
http://go/go-review/1024024
|
|
1st step of renaming dirList.html -> dirlist.html
(OS X filenames are not capitalization-sensitive)
R=rsc
http://go/go-review/1024021
|
|
instead of serving them raw
- path-related cleanups
R=rsc
http://go/go-review/1026021
|
|
- renamed listing.html -> dirList.html
(there is a dirs.html already, it should probably have a better name, too)
R=rsc
http://go/go-review/1025020
|
|
R=rsc
http://go/go-review/1026020
|
|
- formatting in dirs.html is crude, needs better html (open to suggestions),
but shows the synopsis
- many package comments should probably be adjusted such that the first
sentence is more concise
R=rsc, iant
http://go/go-review/1025014
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
R=r
http://go/go-review/1026007
|
|
R=rsc
http://go/go-review/1024004
|
|
R=rsc
http://go/go-review/1018036
|
|
R=rsc
http://go/go-review/1018039
|
|
- made package tree handler generic so it can work on any fs tree
- cleanups along the way
R=rsc
CC=r
http://go/go-review/1017020
|
|
(No visual change yet since the comments for
exported code snippets - as shown on the pkg
page - are not yet formatted using the standard
comment intersperse mechanism in the printer.
This is a TODO in the printer.)
R=rsc
http://go/go-review/1016031
|
|
- removed some underbars in section headings for better looks
- various minor tweaks
R=rsc
http://go/go-review/1018026
|
|
also fix a error-printing bug in godoc.
R=gri
http://go/go-review/1016030
|
|
just a single directory
- all pieces present but not well integrated
- directory tree served at the moment under /tree
R=rsc
http://go/go-review/1018016
|
|
left, like an assignment, like strcpy, etc.
R=rsc
CC=go-dev
http://go/go-review/1016011
|
|
(and thus avoid re-indexing after every sync attempt)
R=rsc
http://go/go-review/1016010
|
|
and godoc/main.go.
R=gri
CC=r
http://go/go-review/1017005
|