Age | Commit message (Collapse) | Author | Files | Lines |
|
Fixes issue 245.
R=ken2
http://codereview.appspot.com/164094
|
|
Fixes bug 292.
R=ken2
http://codereview.appspot.com/164093
|
|
Fixes issue 364.
R=ken2
http://codereview.appspot.com/164092
|
|
Fixes issue 370.
R=ken2
http://codereview.appspot.com/163097
|
|
Fixes issue 371.
R=ken2
http://codereview.appspot.com/164091
|
|
this breaks the dependency of package io on package bytes.
R=rsc
CC=golang-dev
http://codereview.appspot.com/163085
|
|
R=rsc
http://codereview.appspot.com/164085
|
|
in favor of tempname.
allows optimizer to do more.
unfortunately, optimizer seems to be broken; disable it.
R=ken2
http://codereview.appspot.com/163091
|
|
drop check in range over array.
drop check in [256]array indexed by byte.
R=ken2
http://codereview.appspot.com/163088
|
|
tabs for indentation even if -spaces is set.
Changes to gofmt:
- added -tabindent flag
- don't recompute parser and printer mode repeatedly
Changes to go/printer:
- provide new printing mode TabIndent
Changes to tabwriter:
- implement new mode TabIndent to use tabs independent
of the actual padding character for leading empty columns
- distinguish between minimal cell width and tab width
(tabwidth is only used if the output contains tabs,
minwidth and padding are always considered)
- fixed and added more comments
- some additional factoring
By default, -tabindent is disabled and the default gofmt
behavior is unchanged. By setting -spaces and -tabindent,
gofmt will use tabs for indentation but do any other
alignment with spaces. This permits a user to change the
visible indentation by simply changing the editor's tab
width and the code will remain properly aligned without
the need to rerun gofmt.
R=rsc
http://codereview.appspot.com/163068
|
|
How to reproduce:
$ mkdir /tmp/foo
$ cp /dev/null /tmp/foo/bar.go
$ chmod -r /tmp/foo/bar.go
$ gofmt /tmp/foo
open /tmp/foo/bar.go: permission denied
$ echo $? # should echo 2
0
$
Maybe you need to put a call to time.Sleep at the beginning of report().
R=gri
CC=golang-dev
http://codereview.appspot.com/164073
Committer: Robert Griesemer <gri@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/164069
Committer: Russ Cox <rsc@golang.org>
|
|
R=gri
http://codereview.appspot.com/163067
Committer: Robert Griesemer <gri@golang.org>
|
|
Also fixes issue 310 comment 5 error.
Fixes issue 310.
R=rsc
http://codereview.appspot.com/163042
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
http://codereview.appspot.com/164059
|
|
R=rsc
http://codereview.appspot.com/161050
|
|
Opening /dev/stdin can sometimes fail. For example, in the acme editor,
executing "Edit ,|gofmt" fails with:
open /dev/stdin: no such device or address
Executing "Edit ,|ls -l /dev/stdin /proc/self/fd/0" gives:
lrwxrwxrwx 1 root root 15 2009-09-07 02:17 /dev/stdin -> /proc/self/fd/0
lrwx------ 1 fhs users 64 2009-11-26 22:05 /proc/self/fd/0 -> socket:[5528230]
(This is my first change, and I've signed the individual contributor license agreement.)
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/162041
Committer: Robert Griesemer <gri@golang.org>
|
|
- simplified dealing with parse errors: no need to intersperse them in the source
- improve visibility of highlighted identifiers by showing them in bold
R=rsc
http://codereview.appspot.com/163051
|
|
Ideally, the C name would come from the typedef or pointer that
references the Size<0 type, but we can't easily generate this without
performing a look-ahead to see if any referencing type will become opaque.
Fixes issue 334.
Fixes issue 281.
R=rsc
http://codereview.appspot.com/161056
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 288.
R=ken2
http://codereview.appspot.com/157162
|
|
- removed New(len int) in favor of new(Vector).Resize(len, cap)
- removed Init(len int) in favor of Resize(len, cap)
- runs all.bash
Fixes issue 294.
R=rsc, r, r1
http://codereview.appspot.com/157143
|
|
R=gri
CC=r
http://codereview.appspot.com/157149
|
|
'unexpected type: ...'.
Fixes issue 162.
R=rsc
http://codereview.appspot.com/157147
Committer: Russ Cox <rsc@golang.org>
|
|
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes issue 115.
R=rsc, dsymonds1
http://codereview.appspot.com/157067
Committer: Russ Cox <rsc@golang.org>
|
|
getquoted() currently checks for whitespaces and returns nil
if it finds one. this prevents us from having go in a path
containing whitespaces, as the #pragma dynld directives are
processed through the said function.
this commit makes getquoted() accept whitespaces, and this is
also needed for solving issue #115.
R=rsc
http://codereview.appspot.com/157066
Committer: Russ Cox <rsc@golang.org>
|
|
fix a few paren insertion bugs in the printer too.
R=gri, r
CC=golang-dev
http://codereview.appspot.com/157119
|
|
R=r
http://codereview.appspot.com/160044
|
|
R=ken2
http://codereview.appspot.com/160043
|
|
a little slow, but usable (speed unchanged when not using -r)
tweak go/printer to handle nodes without line numbers
more gracefully in a couple cases.
R=gri
http://codereview.appspot.com/156103
|
|
R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
|
|
R=ken2
http://codereview.appspot.com/157114
|
|
* add runtime sliceslice1 for x[lo:]
* remove runtime arraytoslice, rewriting &arr into arr[0:len(arr)].
* port cgen_inline into 8g, 5g.
* use native memmove in maps
R=ken2
http://codereview.appspot.com/157106
|
|
R=r
http://codereview.appspot.com/157103
|
|
fatal error.
Fixes issue 126.
R=rsc
http://codereview.appspot.com/157101
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 144.
R=ken2
CC=agl1
http://codereview.appspot.com/156102
|
|
R=rsc
http://codereview.appspot.com/157096
|
|
R=r, rsc
http://codereview.appspot.com/157082
|
|
No benchmarks are run unless the --benchmarks=<regexp> flag
is specified on the gotest command line. This change includes
sample benchmarks for regexp.
% gotest --benchmarks=.*
(standard test output redacted)
testing.BenchmarkSimpleMatch 200000 7799 ns/op
testing.BenchmarkUngroupedMatch 20000 76898 ns/op
testing.BenchmarkGroupedMatch 50000 38148 ns/op
R=r, rsc
http://codereview.appspot.com/154173
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
http://codereview.appspot.com/156100
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/157074
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
http://codereview.appspot.com/156085
|
|
replace all calls with calls to copy
use copy in regexp and bytes.Buffer
R=rsc
CC=golang-dev
http://codereview.appspot.com/157073
|
|
when used as arg to copy.
R=ken2
http://codereview.appspot.com/157071
|
|
necessary on freebsd.
R=r, dho
CC=golang-dev
http://codereview.appspot.com/157069
|
|
element.
R=rsc
CC=ken2, golang-dev
http://codereview.appspot.com/156083
|
|
prefixing them with _. Collisions with existing fields are resolved by prefixing the new Go identifier with _ until it matches nothing else in the struct.
Fixes issue 36.
R=rsc
http://codereview.appspot.com/157061
Committer: Russ Cox <rsc@golang.org>
|
|
This patchset gets Go to pretty much the same state that
FreeBSD/amd64 is in.
R=rsc
http://codereview.appspot.com/157055
Committer: Russ Cox <rsc@golang.org>
|
|
unsafe.Pointer.
Fixes issue 254.
R=rsc
http://codereview.appspot.com/157060
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
http://codereview.appspot.com/156060
|
|
did not test 386, but should work
shouldnt matter if copy is not used
R=rsc
http://codereview.appspot.com/156055
|