Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Use a count of -1 for infinity. Ditto for Replace.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1704044
Committer: Rob Pike <r@golang.org>
|
|
(addressing comments from 1741045)
R=r
CC=golang-dev
http://codereview.appspot.com/1678047
|
|
For generating non-self-signed certs we need to be able to specify a
public key (for the signee) which is different from the private key (of
the signer).
R=rsc
CC=golang-dev
http://codereview.appspot.com/1741045
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1326042
|
|
NewDeflater -> NewWriter
NewInflater -> NewReader
Deflater -> Compressor
Inflater -> Decompressor
R=rsc
CC=golang-dev
http://codereview.appspot.com/1166041
|
|
- renamed Len -> BitLen, simplified implementation
- renamed old Div, Mod, DivMod -> Que, Rem, QuoRem
- implemented Div, Mod, DivMod (Euclidian definition, more
useful in a mathematical context)
- fixed a bug in Exp (-0 was possible)
- added extra tests to check normalized results everywhere
- uniformly set Int.neg flag at the end of computations
- minor cosmetic cleanups
- ran all tests
R=rsc
CC=golang-dev
http://codereview.appspot.com/1091041
|
|
Depends on CL 957045, 980043, 1004043.
Fixes issue 715.
R=agl1, agl
CC=golang-dev
http://codereview.appspot.com/943043
|
|
R=agl1
CC=golang-dev
http://codereview.appspot.com/851041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/833044
|
|
note that sortmain.go has been run through hg gofmt;
only the formatting of the day initializers changed.
i'm happy to revert that formatting if you'd prefer.
stop on error in doc/progs/run
R=r
CC=golang-dev
http://codereview.appspot.com/850041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/823041
|
|
in the tests, println+panic.
gofmt some tests too.
R=rsc
CC=golang-dev
http://codereview.appspot.com/741041
|
|
Until proven insufficient, rely on the operating system
to give us good random bytes (/dev/urandom).
R=agl1
CC=golang-dev
http://codereview.appspot.com/569044
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/317041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/224081
Committer: Russ Cox <rsc@golang.org>
|
|
R=agl1, rsc
CC=golang-dev
http://codereview.appspot.com/253045
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/240043
Committer: Russ Cox <rsc@golang.org>
|
|
Previously we would require safe primes for our RSA key generation.
Since this took rather a long time, this removes the requirement that
the primes be safe.
OpenSSL doesn't use safe primes for RSA key generation either
(openssl-0.9.8l/crypto/rsa/rsa_gen.c:122)
Fixes issue 649.
R=rsc
CC=golang-dev
http://codereview.appspot.com/253041
|
|
- only manual changes are in src/pkg/go/printer/nodes.go
- use a heuristic to determine "outliers" such that not entire composites are
forced to align with them
- improves several places that were not unligned before due too simple heuristic
- unalignes some cases that contain "outliers"
- gofmt -w src misc
Fixes issue 644.
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/241041
|
|
- gofmt -w src misc
- looking for feedback
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/223076
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/217116
Committer: Russ Cox <rsc@golang.org>
|
|
gofmt -w -r 'strings.Bytes(a) -> []byte(a)' src/cmd src/pkg test/bench
gofmt -w -r 'strings.Runes(a) -> []int(a)' src/cmd src/pkg test/bench
delete unused imports
R=r
CC=golang-dev
http://codereview.appspot.com/224062
|
|
Replaces stale references to modes.go.
R=golang-dev, agl, rsc
CC=golang-dev
http://codereview.appspot.com/218071
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/212041
|
|
Marshalling:
* Fixes several silly bugs.
* Support the RawContents type.
* Support the RawValue type.
* Recurse into nested interface{}.
Both directions:
* Better handling of SETs. You can now tag an element in a
structure with "set" to get the correct tag for serialisation.
* For types that aren't in a structure, you can now name them
with "SET" on the end.
* SETs are no longer implicitly treated as SEQUENCEs.
R=rsc
CC=golang-dev
http://codereview.appspot.com/201049
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/201047
|
|
crypto/*: implement and test proper Sum
Fixes issue 216.
R=agl1
CC=golang-dev
http://codereview.appspot.com/186210
Committer: Russ Cox <rsc@golang.org>
|
|
R=agl, agl1
CC=golang-dev
http://codereview.appspot.com/183083
|
|
Use uint index variables in some cases instead
of int to enable strength reduction; this makes
it possible for the compiler to reduce % into
masks.
Old code: 6g -S md4.go md4block.go | grep "md4block.go:44"
0471 (md4block.go:44) MOVL AX,BX
0472 (md4block.go:44) MOVL AX,BP
0473 (md4block.go:44) MOVL AX,R8
0474 (md4block.go:44) SARL $31,R8
0475 (md4block.go:44) SHRL $30,R8
0476 (md4block.go:44) ADDL R8,BP
0477 (md4block.go:44) SARL $2,BP
0478 (md4block.go:44) IMULL $4,BP
0479 (md4block.go:44) SUBL BP,BX
0480 (md4block.go:44) MOVLQSX BX,BX
0481 (md4block.go:44) LEAQ shift1+0(SB),BP
0482 (md4block.go:44) CMPL BX,8(BP)
0483 (md4block.go:44) JCS ,485
0484 (md4block.go:44) CALL ,runtime.throwindex+0(SB)
0485 (md4block.go:44) MOVQ (BP),BP
0486 (md4block.go:44) MOVL (BP)(BX*4),DI
New code: 6g -S md4.go md4block.go | grep "md4block.go:44"
0471 (md4block.go:44) MOVL AX,BX
0472 (md4block.go:44) ANDL $3,BX
0473 (md4block.go:44) MOVLQZX BX,BX
0474 (md4block.go:44) LEAQ shift1+0(SB),BP
0475 (md4block.go:44) CMPL BX,8(BP)
0476 (md4block.go:44) JCS ,478
0477 (md4block.go:44) CALL ,runtime.throwindex+0(SB)
0478 (md4block.go:44) MOVQ (BP),BP
0479 (md4block.go:44) MOVL (BP)(BX*4),DI
R=agl, agl1
CC=golang-dev
http://codereview.appspot.com/181086
|
|
(I was looking at this code accidentally because of some gofmt
issues and thought that one could write this more effectively.
You may have deliberately chosen not to use ranges here to make
the index range clearer. Just let me know.)
R=agl, agl1
CC=golang-dev
http://codereview.appspot.com/181084
|
|
Listener contains private members and 6g now enforces that private
members cannot be assigned outside of their package.
R=rsc
CC=golang-dev
http://codereview.appspot.com/183073
|
|
Add support for TLS extensions in general and Next Protocol
Negotiation in particular.
R=rsc
CC=golang-dev
http://codereview.appspot.com/181045
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
1st set of files.
R=rsc
CC=agl, golang-dev, iant, ken2, r
http://codereview.appspot.com/180047
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/176062
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
http://codereview.appspot.com/172041
|
|
This is an adaption of the code from http://en.wikipedia.org/wiki/XTEA. The package also implements the block.Cipher
interface so that it can be used with the various block modes.
R=rsc
http://codereview.appspot.com/157152
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes bug 375.
R=rsc
http://codereview.appspot.com/165045
|