Age | Commit message (Collapse) | Author | Files | Lines |
|
R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
|
|
TBR=rsc
R=rsc
http://codereview.appspot.com/157075
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/156054
|
|
replace all calls with calls to copy
use copy in regexp and bytes.Buffer
R=rsc
CC=golang-dev
http://codereview.appspot.com/157073
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/156051
|
|
* add Marshal
* add BitString.RightAlign
* change to using a *time.Time (from time.Time) since that's what
the time package uses.
* return the unparsed data from Unmarshal.
R=rsc
CC=golang-dev
http://codereview.appspot.com/156047
|
|
Fixes issue 210.
R=rsc
CC=golang-dev
http://codereview.appspot.com/155057
|
|
We are dealing with the multiplicative group ℤ/pqℤ. Multiples of
either p or q are not members of the group since they cannot have an
inverse. (Such numbers are 0 in the subgroup ℤ/pℤ.)
With p and q of typical size (> 512 bits), the probability of a random
blind [1..pq-1] being a multiple of p or q is negligible. However, in
the unit tests, much smaller sizes are used and the event could occur.
This change checks the result of the ext GCD and deals with this case.
It also increases the size of p and q in the unit test as a large
number of the keys selected were p, q = 227,169.
R=rsc
CC=golang-dev
http://codereview.appspot.com/154141
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 171.
Fixes issue 172.
R=agl1
http://codereview.appspot.com/154136
|
|
|
|
TBR=agl1
CC=golang-dev
http://codereview.appspot.com/154065
|
|
Turn methods that don't store the result in their receiver into
functions in order to preserve the convention.
Re-jig Exp and Div by moving their guts into nat.go.
Add ProbablyPrime to perform Miller-Rabin primality tests.
crypto/rsa: reenable key generation since we now have ProbablyPrime.
R=gri
CC=go-dev
http://codereview.prom.corp.google.com/1024038
|
|
Fixes issue 38.
R=r1, r
http://codereview.appspot.com/152072
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/1026036
|
|
R=rsc, r
http://go/go-review/1025029
|
|
R=r, iant
CC=go-dev
http://go/go-review/1025024
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
crypto/x509: reenable tests.
R=gri
CC=go-dev
http://go/go-review/1026004
|
|
R=agl
http://go/go-review/1024009
|
|
TBR=rsc
R=rsc
CC=go-dev
http://go/go-review/1024007
|
|
(now down to a handfull of files in pkg)
R=rsc
http://go/go-review/1019006
|
|
Results of running gofmt again.
R=rsc
CC=go-dev
http://go/go-review/1022006
Committer: Adam Langley <agl@golang.org>
|
|
Make RSA and X509 build by using big. (This involves commenting out
key generation for now since I haven't written Miller-Rabin in big
yet.)
Add entries to the Makefile.
R=rsc
CC=go-dev
http://go/go-review/1022005
|
|
R=rsc
CC=go-dev
http://go/go-review/1019002
|
|
(With hindsight, record_process might have been designed wrong, but it
works for now. It'll get redrawn when client support is added.)
R=rsc
CC=r
http://go/go-review/1018032
Committer: Adam Langley <agl@golang.org>
|
|
R=agl
CC=rsc
http://go/go-review/1017032
|
|
R=rsc
CC=go-dev
http://go/go-review/1017021
|
|
R=rsc
CC=go-dev
http://go/go-review/1018028
|
|
For testing it can be useful to use a null random source (one which
always returns zero) to remove non-determinism from the tests.
However, when performing RSA blinding, the random blind ends up being
zero and it's hard to reverse a multiplication by zero.
R=rsc
CC=go-dev
http://go/go-review/1018033
|
|
Rather than drop everything into a single, huge review, I've included
some simple bits of code here.
R=rsc
CC=go-dev
http://go/go-review/1016029
|
|
R=rsc
CC=go-dev
http://go/go-review/1018020
|
|
left, like an assignment, like strcpy, etc.
R=rsc
CC=go-dev
http://go/go-review/1016011
|
|
R=go-dev
APPROVED=rsc
DELTA=407 (400 added, 0 deleted, 7 changed)
OCL=36007
CL=36146
|
|
R=r
APPROVED=r
DELTA=16 (0 added, 15 deleted, 1 changed)
OCL=35976
CL=35978
|
|
R=rsc
APPROVED=rsc
DELTA=659 (659 added, 0 deleted, 0 changed)
OCL=35932
CL=35975
|
|
R=rsc
APPROVED=rsc
DELTA=734 (734 added, 0 deleted, 0 changed)
OCL=35738
CL=35879
|
|
R=r
DELTA=30 (8 added, 15 deleted, 7 changed)
OCL=35677
CL=35713
|
|
R=gri
OCL=35485
CL=35488
|
|
R=gri
DELTA=2560 (127 added, 177 deleted, 2256 changed)
OCL=35388
CL=35395
|
|
RC4 is a common stream cipher. This adds a pure-go C implementation.
R=r
APPROVED=r
DELTA=139 (138 added, 0 deleted, 1 changed)
OCL=35056
CL=35092
|
|
R=r
OCL=34731
CL=34731
|
|
R=rsc
DELTA=152 (6 added, 0 deleted, 146 changed)
OCL=34695
CL=34701
|
|
the last round omitted := range and only
checked 1 out of N vars in a multi-var :=
R=r
OCL=34624
CL=34638
|
|
gzip.GzipInflater -> gzip.Inflater
gzip.NewGzipInflater -> gzip.NewInflater
zlib.NewZlibInflater -> zlib.NewInflater
io.ByteReader deleted in favor of bytes.Buffer
io.NewByteReader -> bytes.NewBuffer
R=r
DELTA=52 (3 added, 0 deleted, 49 changed)
OCL=33589
CL=33592
|
|
to whole-package compilation.
R=r
OCL=33070
CL=33101
|
|
io.ByteBuffer -> bytes.Buffer
left io.ByteBuffer stub around for now,
for protocol compiler.
R=r
OCL=30861
CL=30872
|
|
echo back context of call in error if likely to be useful.
For example, if os.Open("/etc/passwd", os.O_RDONLY)
fails with syscall.EPERM, it returns as the os.Error
&PathError{
Op: "open",
Path: "/etc/passwd"
Error: os.EPERM
}
which formats as
open /etc/passwd: permission denied
Not converted:
datafmt
go/...
google/...
regexp
tabwriter
template
R=r
DELTA=1153 (561 added, 156 deleted, 436 changed)
OCL=30738
CL=30781
|
|
remove io.ErrEOF.
rename io.FullRead to io.ReadFull, to match
ReadAtLeast and ReadAll.
remove io.FullReader, because it is now unused.
R=r
DELTA=295 (88 added, 105 deleted, 102 changed)
OCL=30544
CL=30588
|
|
tests: all.bash passes, gobuild still works, godoc still works.
R=rsc
OCL=30096
CL=30102
|