Age | Commit message (Collapse) | Author | Files | Lines |
|
- always include position information about opening/closing parens/braces
- replace uses of []*ast.Field with *ast.FieldList
Fixes issue 473.
R=rsc
CC=golang-dev
http://codereview.appspot.com/223043
|
|
- add extra test cases to go/printer tests
- apply gofmt to src and misc
R=rsc
CC=golang-dev
http://codereview.appspot.com/223041
|
|
- go/ast: removed StringList (not needed anymore)
- go/ast: changed import path and field list tag to a single string
- updated all dependencies
R=rsc
CC=golang-dev
http://codereview.appspot.com/217056
|
|
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/207096
|
|
directory:
- adjust ast.Package node and doc.PackageDoc correspondingly
- introduce parser.ParseFiles
R=rsc
CC=golang-dev
http://codereview.appspot.com/207087
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/203062
|
|
Averaged times (in microseconds) for drawing an 800x600 rectangle
are listed below. The summary is: around a 100x improvement.
draw.Draw call times were typically linear in the number of pixels
touched (i.e. drawing an 800x600 rectangle took 100x as much time as
drawing an 80x60 rectangle).
Before this change, there was only the general-but-slow code path.
When drawing any src with a 50%-opaque mask: 237300 us
When drawing any src with a nil mask: 50100 us
After this change, the 50%-opaque mask case is unchanged.
For an *image.RGBA dst and nil mask and...
...a uniform color (i.e. an image.ColorImage) src: 282 us
...another *image.RGBA src: 615 us.
For the curious, an intermediate implementation detected the special
cases but used simple nested for loops instead of the built-in copy
function. The respective times (compared to 282 and 615 for the
final implementation, or 50100 for the original) were 3110 and 3573.
Times were measured with 8g/8l on my laptop. I haven't tried gccgo
or other architectures.
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/201048
|
|
This lets you draw text (i.e. with mask = a font image) with
sources that aren't uniform colors.
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/193067
|
|
TBR=r
CC=golang-dev
http://codereview.appspot.com/198081
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/197043
|
|
No longer a distinct type; now a property of func types.
R=ken2
CC=golang-dev
http://codereview.appspot.com/197042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/194126
|
|
- provide scope to parse functions; if non-nil, parser uses the scope
to declare and lookup identifiers
- resolve forward references where possible
R=rsc
CC=golang-dev
http://codereview.appspot.com/194098
|
|
- Identifiers refer now to the language entity (Object)
that they denote. At the moment this is at best an
approximation.
- Initial data structures for language entities (Objects)
and expression types (Type) independent of the actual
type notations.
- Initial support for declaring and looking up identifiers.
- Updated various dependent files and added support functions.
- Extensively tested to avoid breakage. This is an AST change.
R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/189080
|
|
Fixes issue 531.
R=r
CC=golang-dev
http://codereview.appspot.com/189078
|
|
Manual changes to the following files:
src/pkg/Makefile
src/pkg/exp/vector/Makefile (now: src/pkg/container/vector/Makefile)
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/181041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/180108
|
|
R=gri
CC=rsc
http://codereview.appspot.com/178048
Committer: Robert Griesemer <gri@golang.org>
|
|
now that the parser doesn't do this test anymore
R=rsc
CC=golang-dev
http://codereview.appspot.com/179105
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/179099
|
|
in parser's ParsePkgFile and ParsePackage functions.
R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/180070
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
2nd set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/179067
|
|
This change removes the necessity to have GOBIN in $PATH,
and also doesn't assume that the build is being run from
$GOROOT/src. This is a minimal set of necessary changes
to get Go to build happily from the FreeBSD ports
collection.
R=rsc
CC=golang-dev
http://codereview.appspot.com/171044
Committer: Russ Cox <rsc@golang.org>
|
|
- oldparser parse old syntax (required semicolons)
- oldprinter print old syntax (required semicolons)
By default, these flags are enabled for now.
Setting -oldparser=false has no effect until go/parser is changed
to accept the new syntax.
Enabled exp/parser in Makefile; update dependent exp/eval.
R=rsc
http://codereview.appspot.com/174051
|
|
to allow simultaneous import with the
current go/parser
R=rsc
http://codereview.appspot.com/174053
|
|
R=rsc
CC=r
http://codereview.appspot.com/175045
|
|
R=rsc
http://codereview.appspot.com/172042
|
|
R=rsc
http://codereview.appspot.com/172041
|
|
add README explaining how to try the
web demos.
Fixes issue 339.
R=r
CC=barry.d.silverman, bss, vadim
http://codereview.appspot.com/165057
|
|
Modify iterFunc to take chan<- instead of just chan.
R=rsc, dsymonds1
CC=golang-dev, r
http://codereview.appspot.com/160064
Committer: Russ Cox <rsc@golang.org>
|
|
this breaks the dependency of package io on package bytes.
R=rsc
CC=golang-dev
http://codereview.appspot.com/163085
|
|
(compile tested only)
R=r, rsc
http://codereview.appspot.com/161069
Committer: Russ Cox <rsc@golang.org>
|
|
this is the exact same thing issue #115 is about. fix makefiles to use relative
path to work in the case we have whitespaces as part of GOROOT.
R=rsc
http://codereview.appspot.com/162055
Committer: Russ Cox <rsc@golang.org>
|
|
This provides an experimental X11 backend for the exp/draw interface.
It does not aim to provide a complete implementation of the X11 client protocol.
This works for me (Ubuntu Hardy 8.04, GOARCH=386). Your mileage my vary.
R=r, rsc, r1
CC=golang-dev
http://codereview.appspot.com/156109
|
|
- removed New(len int) in favor of new(Vector).Resize(len, cap)
- removed Init(len int) in favor of Resize(len, cap)
- runs all.bash
Fixes issue 294.
R=rsc, r, r1
http://codereview.appspot.com/157143
|
|
R=dsymonds1, rsc
http://codereview.appspot.com/156079
Committer: Russ Cox <rsc@golang.org>
|
|
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes issue 115.
R=rsc, dsymonds1
http://codereview.appspot.com/157067
Committer: Russ Cox <rsc@golang.org>
|
|
Meant as illustration of the Go pattern that is using
goroutines and channels to handle exceptional situations.
Note: There is no need for "Finally" since the
"try block" (the function f supplied to Try)
cannot do a Smalltalk-style non-local return
and terminate the function surrounding Try.
Replaces CL 157083.
R=r, rsc
http://codereview.appspot.com/157087
|
|
R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
|
|
R=r, rsc
http://codereview.appspot.com/157082
|
|
R=rsc
http://codereview.appspot.com/155065
Committer: Russ Cox <rsc@golang.org>
|
|
This does still contain some FreeBSD-specific bits, but
it's a pain to do partial diffs.
R=rsc
http://codereview.appspot.com/152138
Committer: Russ Cox <rsc@golang.org>
|
|
Thanks to Allister Macleod
Fixes issue 112.
R=rsc
CC=golang-dev
http://codereview.appspot.com/152102
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/1026036
|
|
R=rsc, r
http://go/go-review/1025029
|
|
R=rsc
CC=go-dev
http://go/go-review/1026014
Committer: Russ Cox <rsc@golang.org>
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
- added a list of issues to printer/nodes.go
R=rsc
http://go/go-review/1024002
|
|
R=rsc
http://go/go-review/1016055
|
|
R=rsc
http://go/go-review/1017055
|