Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
(remains of the semicolon conversion)
R=rsc
CC=golang-dev
http://codereview.appspot.com/1623041
|
|
(caused certain files to not be idempotent under gofmt)
- corrected golden files for go/printer
- slightly simplified some code in nodes.go (no impact on formatting)
- these changes have no impact on gofmt output of .go files under src, misc
fallthrough statement considered harmful!
R=rsc
CC=golang-dev
http://codereview.appspot.com/1593042
|
|
apply gofmt to src, misc
Fixes issue 752.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1240044
Committer: Robert Griesemer <gri@golang.org>
|
|
Fixes issue 779.
R=r
CC=golang-dev
http://codereview.appspot.com/1218042
|
|
(composite literals in control clauses only need
parentheses if the literals start with a type name)
R=rsc
CC=golang-dev
http://codereview.appspot.com/962045
|
|
Fixes issue 748.
R=rsc
CC=golang-dev
http://codereview.appspot.com/946043
|
|
- more test cases
- comment fixes
- minor unrelated changes as part of investigation of issue 702
R=rsc
CC=golang-dev
http://codereview.appspot.com/860041
|
|
This is for making the fluent interface idiom usable with gofmt.
R=gri
CC=golang-dev
http://codereview.appspot.com/802043
Committer: Robert Griesemer <gri@golang.org>
|
|
- new heuristic: if both the opening { and closing } braces are on the
same line, and the function body doesn't contain comments or is other-
wise too long (e.g. signature too long), it is formatted as a one-line
function
- related cleanups along the way
- gofmt -w src misc led to no additional changes as expected
R=rsc, rsc1
CC=golang-dev, ken2, r
http://codereview.appspot.com/758041
|
|
- gofmt -w src misc
- only manually modified file: src/pkg/go/printer/nodes.go
R=rsc
CC=golang-dev, r
http://codereview.appspot.com/606041
|
|
visible only when enabling internal debug mode:
- in rare cases expression depth can underflow
- when printing a single labeled statement, indentation
may underflow if not setup correctly
R=rsc
CC=golang-dev
http://codereview.appspot.com/484041
|
|
- only manual changes are in src/pkg/go/printer/nodes.go
- use a heuristic to determine "outliers" such that not entire composites are
forced to align with them
- improves several places that were not unligned before due too simple heuristic
- unalignes some cases that contain "outliers"
- gofmt -w src misc
Fixes issue 644.
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/241041
|
|
- gofmt -w src misc
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/223101
|
|
- gofmt -w src misc
- looking for feedback
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/223076
|
|
- gofmt -w src misc
- improves several lists and fixes minor degradation introduced
with the fix for issue 628
- removed some dead code (stringList)
R=rsc
CC=golang-dev
http://codereview.appspot.com/223058
|
|
gofmt -w -r 'strings.Bytes(a) -> []byte(a)' src/cmd src/pkg test/bench
gofmt -w -r 'strings.Runes(a) -> []int(a)' src/cmd src/pkg test/bench
delete unused imports
R=r
CC=golang-dev
http://codereview.appspot.com/224062
|
|
- always include position information about opening/closing parens/braces
- replace uses of []*ast.Field with *ast.FieldList
Fixes issue 473.
R=rsc
CC=golang-dev
http://codereview.appspot.com/223043
|
|
- add extra test cases to go/printer tests
- apply gofmt to src and misc
R=rsc
CC=golang-dev
http://codereview.appspot.com/223041
|
|
- remove several TODOs
- as a side-effect, comment stylers are now used always and comments
will be properly colored in godoc pkg documentation pages (and not
only when looking at source text)
R=rsc
CC=golang-dev
http://codereview.appspot.com/222041
|
|
minor unrelated cleanups
R=rsc
CC=golang-dev
http://codereview.appspot.com/217086
|
|
(this will simplify some further changes)
removed several TODOs
R=rsc
CC=golang-dev
http://codereview.appspot.com/216059
|
|
- go/ast: removed StringList (not needed anymore)
- go/ast: changed import path and field list tag to a single string
- updated all dependencies
R=rsc
CC=golang-dev
http://codereview.appspot.com/217056
|
|
Fixes issue 605.
R=rsc
CC=golang-dev
http://codereview.appspot.com/207108
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/194126
|
|
- Identifiers refer now to the language entity (Object)
that they denote. At the moment this is at best an
approximation.
- Initial data structures for language entities (Objects)
and expression types (Type) independent of the actual
type notations.
- Initial support for declaring and looking up identifiers.
- Updated various dependent files and added support functions.
- Extensively tested to avoid breakage. This is an AST change.
R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/189080
|
|
now printed using the semicolon-free style.
Removed NoSemis flag and mechanism dealing with
optional semicolons from go/printer.
Updated all go/printer output files using the
semi-colon free style.
Changes have no formatting impact on checked in
go code under src and misc.
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/184068
|
|
Addresses some cases and respects position of
closing parenthesis; but doesn't work yet in
all cases. Heuristic; will need to be replaced
by a real solution eventually. Does not cause
existing code to be reformatted.
R=r
CC=golang-dev, rsc
http://codereview.appspot.com/186043
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
3rd set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180048
|
|
multi-line expressions with comments
Fixes issue 414.
R=rsc
http://codereview.appspot.com/179047
|
|
- no need to replace comments for stand-alone blocks
- always print string concatenations with interspersed "+"
(remove option)
- minor cleanups
R=rsc
http://codereview.appspot.com/174076
|
|
R=rsc
http://codereview.appspot.com/175048
|
|
R=rsc
http://codereview.appspot.com/174050
|
|
fix a few paren insertion bugs in the printer too.
R=gri, r
CC=golang-dev
http://codereview.appspot.com/157119
|
|
a little slow, but usable (speed unchanged when not using -r)
tweak go/printer to handle nodes without line numbers
more gracefully in a couple cases.
R=gri
http://codereview.appspot.com/156103
|
|
R=r, rsc
http://codereview.appspot.com/157082
|
|
- better debugging support
- gofmt -l src misc | wc -l is 0
R=rsc
http://go/go-review/1024042
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/1026036
|
|
R=rsc, r
http://go/go-review/1025029
|
|
(and to match the style of declContext)
R=rsc
http://go/go-review/1024033
|
|
a node fits on one line:
- for purposes of measuring the node size in text,
don't generate html or use a styler that could
generate html as it will lead to overly large
sizes
A consequence of this bug is that source code displayed
with godoc may show functions that fit on one line in
the source on multiple lines.
This change causes no difference to the gofmt formatting
of any files in src or misc.
R=rsc
http://go/go-review/1026034
|
|
- blank padding around composite literal contents for a less dense look
(most if not all composite literals were written in that style before gofmt
ran through them)
- corresponding (internal) flag: compositeLitBlank
- don't print a semi after a one-statement statement list (as preferred by r)
- corresponding (internal flag): fewerSemis
- the number of changes in nodes.go is huge because of the removed semis;
hg mail requires that I gofmt the file before
With both flags set to false, this CL causes no gofmt formatting change. We
can turn them on if we like it (and then remove the flags). Will submit with
flags disabled.
R=rsc, r
http://go/go-review/1025015
|
|
on one line for a more compact representation of some composite Literals
R=rsc
http://go/go-review/1025008
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|