Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
(caused certain files to not be idempotent under gofmt)
- corrected golden files for go/printer
- slightly simplified some code in nodes.go (no impact on formatting)
- these changes have no impact on gofmt output of .go files under src, misc
fallthrough statement considered harmful!
R=rsc
CC=golang-dev
http://codereview.appspot.com/1593042
|
|
apply gofmt to src, misc
Fixes issue 752.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1240044
Committer: Robert Griesemer <gri@golang.org>
|
|
Fixes issue 779.
R=r
CC=golang-dev
http://codereview.appspot.com/1218042
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/989044
|
|
(composite literals in control clauses only need
parentheses if the literals start with a type name)
R=rsc
CC=golang-dev
http://codereview.appspot.com/962045
|
|
Fixes issue 748.
R=rsc
CC=golang-dev
http://codereview.appspot.com/946043
|
|
- more test cases
- comment fixes
- minor unrelated changes as part of investigation of issue 702
R=rsc
CC=golang-dev
http://codereview.appspot.com/860041
|
|
This is for making the fluent interface idiom usable with gofmt.
R=gri
CC=golang-dev
http://codereview.appspot.com/802043
Committer: Robert Griesemer <gri@golang.org>
|
|
- new heuristic: if both the opening { and closing } braces are on the
same line, and the function body doesn't contain comments or is other-
wise too long (e.g. signature too long), it is formatted as a one-line
function
- related cleanups along the way
- gofmt -w src misc led to no additional changes as expected
R=rsc, rsc1
CC=golang-dev, ken2, r
http://codereview.appspot.com/758041
|
|
- gofmt -w src misc
- only manually modified file: src/pkg/go/printer/nodes.go
R=rsc
CC=golang-dev, r
http://codereview.appspot.com/606041
|
|
a /*-style comment at the end of a file
Some minor cleanups/typo fixes along the way.
Fixes an issue where that newline was removed
after applying gofmt.
R=r
CC=golang-dev
http://codereview.appspot.com/476043
|
|
visible only when enabling internal debug mode:
- in rare cases expression depth can underflow
- when printing a single labeled statement, indentation
may underflow if not setup correctly
R=rsc
CC=golang-dev
http://codereview.appspot.com/484041
|
|
- only manual changes are in src/pkg/go/printer/nodes.go
- use a heuristic to determine "outliers" such that not entire composites are
forced to align with them
- improves several places that were not unligned before due too simple heuristic
- unalignes some cases that contain "outliers"
- gofmt -w src misc
Fixes issue 644.
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/241041
|
|
- gofmt -w src misc
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/223101
|
|
- gofmt -w src misc
- looking for feedback
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/223076
|
|
- gofmt -w src misc
- improves several lists and fixes minor degradation introduced
with the fix for issue 628
- removed some dead code (stringList)
R=rsc
CC=golang-dev
http://codereview.appspot.com/223058
|
|
- applied gofmt to src and misc
Note: This fix improved formatting of src/pkg/math/all_test.go but leads
to a degradation in src/pkg/exp/4s/xs.go. The latter happened to "work"
before accidentally. Fixing the alignment in that case in general will
be a separate CL.
Fixes issue 628.
R=rsc
CC=golang-dev
http://codereview.appspot.com/223054
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/223044
|
|
- always include position information about opening/closing parens/braces
- replace uses of []*ast.Field with *ast.FieldList
Fixes issue 473.
R=rsc
CC=golang-dev
http://codereview.appspot.com/223043
|
|
- add extra test cases to go/printer tests
- apply gofmt to src and misc
R=rsc
CC=golang-dev
http://codereview.appspot.com/223041
|
|
- remove several TODOs
- as a side-effect, comment stylers are now used always and comments
will be properly colored in godoc pkg documentation pages (and not
only when looking at source text)
R=rsc
CC=golang-dev
http://codereview.appspot.com/222041
|
|
under repeated application of gofmt
R=agl, agl1
CC=golang-dev
http://codereview.appspot.com/212046
|
|
Fixes issue 605.
R=rsc
CC=golang-dev
http://codereview.appspot.com/207108
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/198048
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/194126
|
|
now printed using the semicolon-free style.
Removed NoSemis flag and mechanism dealing with
optional semicolons from go/printer.
Updated all go/printer output files using the
semi-colon free style.
Changes have no formatting impact on checked in
go code under src and misc.
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/184068
|
|
Addresses some cases and respects position of
closing parenthesis; but doesn't work yet in
all cases. Heuristic; will need to be replaced
by a real solution eventually. Does not cause
existing code to be reformatted.
R=r
CC=golang-dev, rsc
http://codereview.appspot.com/186043
|
|
multi-line expressions with comments
Fixes issue 414.
R=rsc
http://codereview.appspot.com/179047
|
|
R=rsc
http://codereview.appspot.com/175048
|
|
R=r, rsc
http://codereview.appspot.com/157082
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/1026036
|
|
R=rsc, r
http://go/go-review/1025029
|
|
on one line for a more compact representation of some composite Literals
R=rsc
http://go/go-review/1025008
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
- this ensures better comment formatting in template.go and codec_test.go
- it affects only 2 files of all files that have been gofmt'ed already,
see separate CL (it fixes the same issue in those files)
R=rsc
http://go/go-review/1023002
|
|
- slightly better output in general
- extra indentation where we could do without
(however that seems better for now that not having the indentation
where it is needed)
- no information is lost, so a future better approach can fix these
places up again
R=rsc
http://go/go-review/1017050
|
|
- preserve (some) indentation of comment text for /*-style comments
even if the first comment line does not contain any text that might
suggest the "correct" indentation
- enabled because otherwise existing larger comments get re-formatted
(this will not introduce a lot of changes since comments of this
kind - until now - were not changed with respect to indentation)
R=rsc
http://go/go-review/1016047
|
|
picked up by gofmt (they should not be modified) or godoc
(testdata should not be considered a potential package
directory)
R=rsc
http://go/go-review/1018045
|
|
R=rsc
http://go/go-review/1017030
|
|
- at the moment this also affects single-line function declarations
because we have disabled them at the moment (but not single-line
function literals)
R=rsc
http://go/go-review/1016040
|
|
- made ast.Spec nodes implement Node interface
- added extra test cases
R=rsc
http://go/go-review/1016038
|
|
- start new sections if a field/method declaration spans multiple lines;
this avoids tabs from the previous line affecting the next field/method
R=rsc
http://go/go-review/1017015
|
|
(previously not shown in godoc)
- simplify parsing of struct types (match code structure for parsing interface types)
R=rsc, r
http://go/go-review/1016019
|
|
- print comments line by line, strip common prefix but do not
modify comment contents otherwise
- align comments with subsequent keyword if indicated (e.g. case labels)
- terminate "column section" after multi-line expressions for better alignment
R=rsc
http://go/go-review/1017002
|
|
R=rsc
http://go/go-review/1013017
|
|
R=rsc
DELTA=207 (160 added, 42 deleted, 5 changed)
OCL=35854
CL=35887
|
|
R=rsc
DELTA=189 (118 added, 9 deleted, 62 changed)
OCL=35816
CL=35821
|