Age | Commit message (Collapse) | Author | Files | Lines |
|
fix a few paren insertion bugs in the printer too.
R=gri, r
CC=golang-dev
http://codereview.appspot.com/157119
|
|
a little slow, but usable (speed unchanged when not using -r)
tweak go/printer to handle nodes without line numbers
more gracefully in a couple cases.
R=gri
http://codereview.appspot.com/156103
|
|
R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
|
|
R=r, rsc
http://codereview.appspot.com/157082
|
|
- better debugging support
- gofmt -l src misc | wc -l is 0
R=rsc
http://go/go-review/1024042
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/1026036
|
|
R=rsc, r
http://go/go-review/1025029
|
|
(and to match the style of declContext)
R=rsc
http://go/go-review/1024033
|
|
a node fits on one line:
- for purposes of measuring the node size in text,
don't generate html or use a styler that could
generate html as it will lead to overly large
sizes
A consequence of this bug is that source code displayed
with godoc may show functions that fit on one line in
the source on multiple lines.
This change causes no difference to the gofmt formatting
of any files in src or misc.
R=rsc
http://go/go-review/1026034
|
|
HTML vs Html, URL vs Url, HTTP vs Http,
current source is 6:1 in favor of the former,
so change instances of the latter.
R=r
CC=go-dev
http://go/go-review/1024026
|
|
R=r, iant
CC=go-dev
http://go/go-review/1025024
|
|
R=r, rsc
http://go/go-review/1025023
|
|
- blank padding around composite literal contents for a less dense look
(most if not all composite literals were written in that style before gofmt
ran through them)
- corresponding (internal) flag: compositeLitBlank
- don't print a semi after a one-statement statement list (as preferred by r)
- corresponding (internal flag): fewerSemis
- the number of changes in nodes.go is huge because of the removed semis;
hg mail requires that I gofmt the file before
With both flags set to false, this CL causes no gofmt formatting change. We
can turn them on if we like it (and then remove the flags). Will submit with
flags disabled.
R=rsc, r
http://go/go-review/1025015
|
|
on one line for a more compact representation of some composite Literals
R=rsc
http://go/go-review/1025008
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
- added a list of issues to printer/nodes.go
R=rsc
http://go/go-review/1024002
|
|
- this ensures better comment formatting in template.go and codec_test.go
- it affects only 2 files of all files that have been gofmt'ed already,
see separate CL (it fixes the same issue in those files)
R=rsc
http://go/go-review/1023002
|
|
R=rsc
http://go/go-review/1023001
|
|
- slightly better output in general
- extra indentation where we could do without
(however that seems better for now that not having the indentation
where it is needed)
- no information is lost, so a future better approach can fix these
places up again
R=rsc
http://go/go-review/1017050
|
|
- preserve (some) indentation of comment text for /*-style comments
even if the first comment line does not contain any text that might
suggest the "correct" indentation
- enabled because otherwise existing larger comments get re-formatted
(this will not introduce a lot of changes since comments of this
kind - until now - were not changed with respect to indentation)
R=rsc
http://go/go-review/1016047
|
|
(request by r)
- feature temporarily disabled
R=rsc
CC=r
http://go/go-review/1018052
|
|
and parser.go and scanner_test.go which have minor formatting issues)
R=rsc
http://go/go-review/1016042
|
|
picked up by gofmt (they should not be modified) or godoc
(testdata should not be considered a potential package
directory)
R=rsc
http://go/go-review/1018045
|
|
R=rsc
http://go/go-review/1017030
|
|
- at the moment this also affects single-line function declarations
because we have disabled them at the moment (but not single-line
function literals)
R=rsc
http://go/go-review/1016040
|
|
R=rsc
http://go/go-review/1017027
|
|
- made ast.Spec nodes implement Node interface
- added extra test cases
R=rsc
http://go/go-review/1016038
|
|
(which I uploaded at home and thus can't upload from here).
CL 1018027 was reviewed.
- added comments to scope.go
- commented out some code that is not yet needed
(and which showed up prominently in the documentation)
R=rsc
http://go/go-review/1017017
|
|
- start new sections if a field/method declaration spans multiple lines;
this avoids tabs from the previous line affecting the next field/method
R=rsc
http://go/go-review/1017015
|
|
- nodes.go implements ast node formatting
- printer.go implements the core printing functionality
and public interface
No code changes except for updating the import clauses
and adding a top-level comment to nodes.go.
R=rsc
http://go/go-review/1016026
|
|
global regexps.
R=rsc, gri
CC=go-dev
http://go/go-review/1016025
|
|
(previously not shown in godoc)
- simplify parsing of struct types (match code structure for parsing interface types)
R=rsc, r
http://go/go-review/1016019
|
|
left, like an assignment, like strcpy, etc.
R=rsc
CC=go-dev
http://go/go-review/1016011
|
|
- print comments line by line, strip common prefix but do not
modify comment contents otherwise
- align comments with subsequent keyword if indicated (e.g. case labels)
- terminate "column section" after multi-line expressions for better alignment
R=rsc
http://go/go-review/1017002
|
|
R=rsc
http://go/go-review/1013017
|
|
R=gri
http://go/go-review/1015011
|
|
- fixed several bugs
R=rsc
http://go/go-review/1015015
|
|
This matches the change to printer.go in revision 3632.
R=gri
http://go/go-review/1015001
|
|
- replacement for p4 CL 35999 (abandoned)
R=rsc
http://go/go-review/1012010
|
|
R=rsc
http://go/go-review/1012008
|
|
R=rsc
http://go/go-review/1014006
|
|
- handle HTML tagging via (client-installable) Stylers
go/doc:
- basic styler support
- some factoring
- ready to contain the search code (but for now excluded)
doc/style.css:
- updated
doc/go_spec.css:
- cleanup: replace deprecated uses of <font> tag with <span> tag
R=rsc
DELTA=302 (160 added, 62 deleted, 80 changed)
OCL=35973
CL=35996
|
|
R=rsc
DELTA=207 (160 added, 42 deleted, 5 changed)
OCL=35854
CL=35887
|
|
R=rsc
DELTA=189 (118 added, 9 deleted, 62 changed)
OCL=35816
CL=35821
|
|
R=rsc
DELTA=1 (1 added, 0 deleted, 0 changed)
OCL=35778
CL=35780
|
|
(always write tabwriter.Escape chars so formatting is driven correctly; but strip
them again in the end if no tabwriter is used)
- added testcase for RawFormat printing
R=rsc
DELTA=227 (198 added, 6 deleted, 23 changed)
OCL=35772
CL=35774
|
|
contain tabs or line breaks
R=rsc
DELTA=57 (19 added, 12 deleted, 26 changed)
OCL=35749
CL=35770
|
|
only associate a couple of functions as factories
for os.Error.
Replaces CL 35628 (abandoned).
R=rsc
DELTA=35 (26 added, 0 deleted, 9 changed)
OCL=35754
CL=35768
|
|
ditto for heap.HeapInterface
R=gri,rsc
DELTA=31 (0 added, 1 deleted, 30 changed)
OCL=35665
CL=35673
|
|
R=rsc
DELTA=15 (12 added, 2 deleted, 1 changed)
OCL=35641
CL=35645
|