Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
Use a count of -1 for infinity. Ditto for Replace.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1704044
Committer: Rob Pike <r@golang.org>
|
|
This CL replaces my earlier http://codereview.appspot.com/1640044/show
in which Continue handling was explicit. Instead, this CL makes
it automatic. Reading from Body() is an implicit acknowledgement
that the request headers were fine and the body is wanted. In that
case, the 100 Continue response is written automatically when the
request continues the "Expect: 100-continue" header.
R=rsc, adg
CC=golang-dev
http://codereview.appspot.com/1610042
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1539042
|
|
Fixes issue 775.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1180042
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/833044
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/238041
Committer: Russ Cox <rsc@golang.org>
|
|
- gofmt -w src misc
- looking for feedback
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/223076
|
|
gofmt -w -r 'strings.Bytes(a) -> []byte(a)' src/cmd src/pkg test/bench
gofmt -w -r 'strings.Runes(a) -> []int(a)' src/cmd src/pkg test/bench
delete unused imports
R=r
CC=golang-dev
http://codereview.appspot.com/224062
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/217066
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc, adg
CC=golang-dev
http://codereview.appspot.com/217071
Committer: Andrew Gerrand <adg@golang.org>
|
|
Compliance issue addressed here: POST requests carrying form data are required
to use "identity" transfer encoding by common nginx and apache server configurations,
e.g. wordpress.com (and many others). So, Request needed to be able to send
non-chunked encodings.
Thus, Request is extended to support identity and chunked encodings, like
Response. Since the Read() and Write() logic are shared by both (and are
quite long), it is exported in a separate file transfer.go.
R=rsc
CC=golang-dev
http://codereview.appspot.com/217048
Committer: Russ Cox <rsc@golang.org>
|
|
since they were causing a silent program exit (too many EPIPE's).
R=rsc
CC=golang-dev
http://codereview.appspot.com/204062
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/203050
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/196079
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 566.
R=rsc
CC=golang-dev
http://codereview.appspot.com/194074
Committer: Russ Cox <rsc@golang.org>
|
|
(1) http.Response must close resp.Body after writing.
(2) Case when resp.Body != nil and resp.ContentLength = 0 should not be
treated as an error in Response.Write, because this is what
ReadResponse often returns.
(3) Changed body.th to body.hdr for readability.
R=rsc
CC=golang-dev
http://codereview.appspot.com/194084
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc, rsc1
CC=golang-dev
http://codereview.appspot.com/194046
Committer: Russ Cox <rsc@golang.org>
|
|
usage pattern of http.Request and paves the way to persistent connection
handling.
R=rsc
CC=golang-dev
http://codereview.appspot.com/185043
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 502.
R=r, hoisie
CC=golang-dev
http://codereview.appspot.com/181179
|
|
R=r
CC=golang-dev, petar-m
http://codereview.appspot.com/183132
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
3rd set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180048
|
|
this breaks the dependency of package io on package bytes.
R=rsc
CC=golang-dev
http://codereview.appspot.com/163085
|
|
- removed New(len int) in favor of new(Vector).Resize(len, cap)
- removed Init(len int) in favor of Resize(len, cap)
- runs all.bash
Fixes issue 294.
R=rsc, r, r1
http://codereview.appspot.com/157143
|
|
R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
|
|
Fixes issue 233.
R=dsymonds1
http://codereview.appspot.com/154179
|
|
R=r
http://go/go-review/1024046
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)
R=rsc, r
http://go/go-review/1024041
|
|
R=rsc, r
http://go/go-review/1025029
|
|
HTML vs Html, URL vs Url, HTTP vs Http,
current source is 6:1 in favor of the former,
so change instances of the latter.
R=r
CC=go-dev
http://go/go-review/1024026
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
R=rsc
CC=go-dev
http://go/go-review/1015003
|
|
R=gri
OCL=35485
CL=35488
|
|
request.go does not handle Content-Type correctly for the definition of
Media Types.
http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.7
R=rsc
APPROVED=rsc
DELTA=44 (42 added, 0 deleted, 2 changed)
OCL=35274
CL=35306
|
|
the last round omitted := range and only
checked 1 out of N vars in a multi-var :=
R=r
OCL=34624
CL=34638
|
|
R=r
DELTA=112 (6 added, 57 deleted, 49 changed)
OCL=34610
CL=34610
|
|
also drop bool arg from ReadString
R=r
DELTA=45 (13 added, 1 deleted, 31 changed)
OCL=33923
CL=33960
|
|
gzip.GzipInflater -> gzip.Inflater
gzip.NewGzipInflater -> gzip.NewInflater
zlib.NewZlibInflater -> zlib.NewInflater
io.ByteReader deleted in favor of bytes.Buffer
io.NewByteReader -> bytes.NewBuffer
R=r
DELTA=52 (3 added, 0 deleted, 49 changed)
OCL=33589
CL=33592
|
|
to whole-package compilation.
R=r
OCL=33070
CL=33101
|
|
R=ken
OCL=30889
CL=30889
|
|
io.ByteBuffer -> bytes.Buffer
left io.ByteBuffer stub around for now,
for protocol compiler.
R=r
OCL=30861
CL=30872
|
|
R=rsc
APPROVED=rsc
DELTA=95 (40 added, 14 deleted, 41 changed)
OCL=30727
CL=30784
|
|
echo back context of call in error if likely to be useful.
For example, if os.Open("/etc/passwd", os.O_RDONLY)
fails with syscall.EPERM, it returns as the os.Error
&PathError{
Op: "open",
Path: "/etc/passwd"
Error: os.EPERM
}
which formats as
open /etc/passwd: permission denied
Not converted:
datafmt
go/...
google/...
regexp
tabwriter
template
R=r
DELTA=1153 (561 added, 156 deleted, 436 changed)
OCL=30738
CL=30781
|
|
R=rsc
APPROVED=r
DELTA=131 (39 added, 10 deleted, 82 changed)
OCL=30669
CL=30723
|
|
Request".
Use chunked Transfer-Encoding for all POSTs.
Implement chunked reading.
Change http.Request.write to be HTTP/1.1 only.
R=rsc
APPROVED=rsc
DELTA=178 (123 added, 26 deleted, 29 changed)
OCL=30563
CL=30673
|
|
because Url.Path already starts with one.
Avoid crashing in Request.ParseForm if there is no body.
R=rsc
APPROVED=rsc
DELTA=5 (4 added, 0 deleted, 1 changed)
OCL=30552
CL=30607
|
|
remove io.ErrEOF.
rename io.FullRead to io.ReadFull, to match
ReadAtLeast and ReadAll.
remove io.FullReader, because it is now unused.
R=r
DELTA=295 (88 added, 105 deleted, 102 changed)
OCL=30544
CL=30588
|
|
better error handling throughout.
R=r,rsc
APPROVED=r
DELTA=254 (201 added, 3 deleted, 50 changed)
OCL=30515
CL=30545
|
|
R=rsc
APPROVED=rsc
DELTA=392 (386 added, 2 deleted, 4 changed)
OCL=29963
CL=30107
|
|
tests: all.bash passes, gobuild still works, godoc still works.
R=rsc
OCL=30096
CL=30102
|