Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1736042
|
|
x.go:13: cannot use t (type T) as type Reader in assignment:
T does not implement Reader (Read method requires pointer receiver)
x.go:19: cannot use q (type Q) as type Reader in assignment:
Q does not implement Reader (missing Read method)
have read()
want Read()
x.go:22: cannot use z (type int) as type Reader in assignment:
int does not implement Reader (missing Read method)
x.go:24: too many arguments to conversion to complex: complex(1, 3)
R=ken2
CC=golang-dev
http://codereview.appspot.com/1736041
|
|
R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/1707042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1533041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1388041
|
|
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/1267041
|
|
NewDeflater -> NewWriter
NewInflater -> NewReader
Deflater -> Compressor
Inflater -> Decompressor
R=rsc
CC=golang-dev
http://codereview.appspot.com/1166041
|
|
Fixes issue 665.
R=nigeltao, nigeltao_golang
CC=golang-dev
http://codereview.appspot.com/570041
|
|
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/198066
|
|
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/199052
|
|
Fixes issue 439.
R=r
CC=golang-dev
http://codereview.appspot.com/181087
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/181075
|
|
This is not a complete JPEG implementation (e.g. it does not handle
progressive JPEGs or restart markers), but I was able to take a photo
with my phone, and view the resultant JPEG in pure Go.
The decoder is simple, but slow. The Huffman decoder in particular
should be easily improvable, but optimization is left to future
changelists. Being able to inline functions in the inner loop should
also help performance.
The output is not pixel-for-pixel identical to libjpeg, although
identical behavior isn't necessarily a goal, since JPEG is a lossy
codec. There are at least two reasons for the discrepancy.
First, the inverse DCT algorithm used is the same as Plan9's
src/cmd/jpg, which has different rounding errors from libjpeg's
default IDCT implementation. Note that libjpeg actually has three
different IDCT implementations: one floating point, and two fixed
point. Out of those four, Plan9's seemed the simplest to understand,
partly because it has no #ifdef's or C macros.
Second, for 4:2:2 or 4:2:0 chroma sampling, this implementation does
nearest neighbor upsampling, compared to libjpeg's triangle filter
(e.g. see h2v1_fancy_upsample in jdsample.c).
The difference from the first reason is typically zero, but sometimes
1 (out of 256) in YCbCr space, or double that in RGB space. The
difference from the second reason can be as large as 8/256 in YCbCr
space, in regions of steep chroma gradients. Informal eyeballing
suggests that the net difference is typically imperceptible, though.
R=r
CC=golang-dev, rsc
http://codereview.appspot.com/164056
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
3rd set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180048
|
|
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes issue 115.
R=rsc, dsymonds1
http://codereview.appspot.com/157067
Committer: Russ Cox <rsc@golang.org>
|
|
R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
|
|
R=rsc
http://codereview.appspot.com/154125
Committer: Russ Cox <rsc@golang.org>
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)
R=rsc, r
http://go/go-review/1024041
|
|
R=rsc, r
http://go/go-review/1025029
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
R=rsc
http://go/go-review/1017044
|
|
R=gri
http://go/go-review/1015011
|
|
R=r,rsc
APPROVED=r
DELTA=7 (5 added, 0 deleted, 2 changed)
OCL=35651
CL=35692
|
|
R=r,rsc
APPROVED=r
DELTA=122 (102 added, 0 deleted, 20 changed)
OCL=35573
CL=35587
|
|
R=rsc,r
APPROVED=rsc
DELTA=29 (2 added, 4 deleted, 23 changed)
OCL=35460
CL=35565
|
|
R=gri
OCL=35485
CL=35488
|
|
R=rsc,r
APPROVED=r
DELTA=84 (77 added, 6 deleted, 1 changed)
OCL=35456
CL=35458
|
|
R=gri
DELTA=1359 (138 added, 32 deleted, 1189 changed)
OCL=35408
CL=35420
|
|
TODOs include filtering, and a unit test.
R=rsc
APPROVED=r
DELTA=280 (249 added, 1 deleted, 30 changed)
OCL=35262
CL=35348
|
|
R=r
DELTA=2 (0 added, 0 deleted, 2 changed)
OCL=34860
CL=34864
|
|
libpng.org.
R=rsc
APPROVED=r
DELTA=1176 (1175 added, 1 deleted, 0 changed)
OCL=34727
CL=34838
|
|
the last round omitted := range and only
checked 1 out of N vars in a multi-var :=
R=r
OCL=34624
CL=34638
|
|
the first IDAT chunk.
R=rsc
APPROVED=rsc
DELTA=7 (2 added, 0 deleted, 5 changed)
OCL=34583
CL=34585
|
|
R=rsc
APPROVED=r
DELTA=694 (675 added, 3 deleted, 16 changed)
OCL=34427
CL=34554
|
|
R=rsc
APPROVED=r,rsc
DELTA=244 (244 added, 0 deleted, 0 changed)
OCL=33733
CL=33940
|