Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
Fixes issue 834.
R=rsc, brainman
CC=golang-dev
http://codereview.appspot.com/1686047
Committer: Russ Cox <rsc@golang.org>
|
|
One goroutine started up and was waiting in rw. Then another
goroutine decided to close the pipe. The closing goroutine
stalled calling p.io.Lock() in pipeHalf.close. (This happened
in gccgo). If the closing goroutine had been able to set the
ioclosed flag, it would have gone on to tell the runner that
the pipe was closed, which would then send an EINVAL to the
goroutine sleeping in rw. Unlocking p.io before sleeping in
rw avoids the race.
R=rsc, rsc1
CC=golang-dev
http://codereview.appspot.com/1682048
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1472042
|
|
Added goroutine; got simpler.
Fixes deadlock when doing Read+Close
or Write+Close on same end.
R=r, cw
CC=golang-dev
http://codereview.appspot.com/994043
|
|
Uid, Gid become int.
File size info becomes int64.
Times become int64.
R=rsc, cw
CC=golang-dev
http://codereview.appspot.com/968042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/902042
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/867044
|
|
gofmt -w -r 'strings.Bytes(a) -> []byte(a)' src/cmd src/pkg test/bench
gofmt -w -r 'strings.Runes(a) -> []int(a)' src/cmd src/pkg test/bench
delete unused imports
R=r
CC=golang-dev
http://codereview.appspot.com/224062
|
|
* renamed channels to say what gets sent
* use channel closed status instead of racy check of boolean
R=nigeltao_golang
CC=golang-dev
http://codereview.appspot.com/196065
|
|
R=nigeltao_golang
CC=golang-dev
http://codereview.appspot.com/194132
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/181163
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
3rd set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180048
|
|
R=rsc
http://codereview.appspot.com/172041
|
|
buffer allocation.
Use them in Copy and Copyn.
Speed up ReadFile by using ReadFrom and avoiding Copy altogether (a minor win).
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/166041
|
|
this breaks the dependency of package io on package bytes.
R=rsc
CC=golang-dev
http://codereview.appspot.com/163085
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/163069
|
|
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes issue 115.
R=rsc, dsymonds1
http://codereview.appspot.com/157067
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=eds
http://codereview.appspot.com/160045
|
|
R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)
R=rsc, r
http://go/go-review/1024041
|
|
R=rsc, r
http://go/go-review/1025029
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
R=rsc
http://go/go-review/1017056
|
|
left, like an assignment, like strcpy, etc.
R=rsc
CC=go-dev
http://go/go-review/1016011
|
|
- added tests
R=rsc
DELTA=62 (61 added, 1 deleted, 0 changed)
OCL=35788
CL=35802
|
|
R=gri
OCL=35485
CL=35488
|
|
R=gri
DELTA=1359 (138 added, 32 deleted, 1189 changed)
OCL=35408
CL=35420
|
|
R=r
OCL=34731
CL=34731
|
|
R=rsc
DELTA=152 (6 added, 0 deleted, 146 changed)
OCL=34695
CL=34701
|
|
the last round omitted := range and only
checked 1 out of N vars in a multi-var :=
R=r
OCL=34624
CL=34638
|
|
R=austin
DELTA=958 (956 added, 0 deleted, 2 changed)
OCL=34180
CL=34212
|
|
R=r
DELTA=85 (85 added, 0 deleted, 0 changed)
OCL=34141
CL=34144
|
|
use it to limit data read from http.Request Body
R=r
DELTA=32 (8 added, 6 deleted, 18 changed)
OCL=33899
CL=33916
|
|
R=rsc
APPROVED=rsc
DELTA=35 (30 added, 4 deleted, 1 changed)
OCL=33491
CL=33498
|
|
whole-package compilation. new Makefiles,
tests now in separate package
bytes
flag
fmt
io
math
once
os
reflect
strconv
sync
time
utf8
delete import "xxx" in package xxx.
inside package xxx, xxx is not declared
anymore so s/xxx.//g
delete file and package level forward declarations.
note the new internal_test.go and sync
and strconv to provide public access to
internals during testing. the installed version
of the package omits that file and thus does
not open the internals to all clients.
R=r
OCL=33065
CL=33097
|
|
R=r
OCL=31359
CL=31359
|
|
R=rsc
DELTA=41 (41 added, 0 deleted, 0 changed)
OCL=31349
CL=31358
|
|
R=r
DELTA=23 (1 added, 12 deleted, 10 changed)
OCL=30957
CL=30980
|
|
R=r
DELTA=25 (0 added, 15 deleted, 10 changed)
OCL=30892
CL=30892
|
|
io.ByteBuffer -> bytes.Buffer
left io.ByteBuffer stub around for now,
for protocol compiler.
R=r
OCL=30861
CL=30872
|
|
echo back context of call in error if likely to be useful.
For example, if os.Open("/etc/passwd", os.O_RDONLY)
fails with syscall.EPERM, it returns as the os.Error
&PathError{
Op: "open",
Path: "/etc/passwd"
Error: os.EPERM
}
which formats as
open /etc/passwd: permission denied
Not converted:
datafmt
go/...
google/...
regexp
tabwriter
template
R=r
DELTA=1153 (561 added, 156 deleted, 436 changed)
OCL=30738
CL=30781
|
|
R=rsc
DELTA=7 (5 added, 0 deleted, 2 changed)
OCL=30657
CL=30659
|
|
R=r
DELTA=7 (6 added, 0 deleted, 1 changed)
OCL=30596
CL=30605
|
|
in cap, len, [], and range on maps, strings, and slices.
R=r
DELTA=57 (2 added, 12 deleted, 43 changed)
OCL=30549
CL=30590
|
|
remove io.ErrEOF.
rename io.FullRead to io.ReadFull, to match
ReadAtLeast and ReadAll.
remove io.FullReader, because it is now unused.
R=r
DELTA=295 (88 added, 105 deleted, 102 changed)
OCL=30544
CL=30588
|