Age | Commit message (Collapse) | Author | Files | Lines |
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1714044
|
|
Fixes issue 872.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1731043
|
|
charclass to avoid unnecessarily iterating over ranges.
Also, use the fact that IntVector is an []int to avoid method calls.
On my machine, this brings us from ~27500 ns/op to ~17500 ns/op in the benchmark I've added (it is also faster in the case where a range check
doesn't help, added a benchmark for this too.)
I'd also like to propose that "[]", and "[^]" be disallowed. They aren't useful as far as I can tell, they aren't widely supported, and they make reasoning about character classes a bit more complicated.
R=r
CC=golang-dev
http://codereview.appspot.com/1495041
Committer: Rob Pike <r@golang.org>
|
|
More in line with other regexp packages
and egrep; accommodates overzealous escapers.
R=r
CC=golang-dev
http://codereview.appspot.com/1008041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/816042
Committer: Rob Pike <r@golang.org>
|
|
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/821046
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/787041
|
|
in the tests, println+panic.
gofmt some tests too.
R=rsc
CC=golang-dev
http://codereview.appspot.com/741041
|
|
- gofmt -w src misc
- only manually modified file: src/pkg/go/printer/nodes.go
R=rsc
CC=golang-dev, r
http://codereview.appspot.com/606041
|
|
R=rsc, adg, r
CC=golang-dev
http://codereview.appspot.com/264041
Committer: Rob Pike <r@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/247041
Committer: Andrew Gerrand <adg@golang.org>
|
|
gofmt -w -r 'strings.Bytes(a) -> []byte(a)' src/cmd src/pkg test/bench
gofmt -w -r 'strings.Runes(a) -> []int(a)' src/cmd src/pkg test/bench
delete unused imports
R=r
CC=golang-dev
http://codereview.appspot.com/224062
|
|
Fixes issue 596.
R=rsc
CC=golang-dev
http://codereview.appspot.com/206101
Committer: Rob Pike <r@golang.org>
|
|
This was convenient for me to have without being forced
to parse the regexp myself. I'd understand if it's not
really wanted, but I also think that some meta information
about compiled regexps would be fine.
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/183044
Committer: Rob Pike <r@golang.org>
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
4th set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180049
|
|
- removed New(len int) in favor of new(Vector).Resize(len, cap)
- removed Init(len int) in favor of Resize(len, cap)
- runs all.bash
Fixes issue 294.
R=rsc, r, r1
http://codereview.appspot.com/157143
|
|
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes issue 115.
R=rsc, dsymonds1
http://codereview.appspot.com/157067
Committer: Russ Cox <rsc@golang.org>
|
|
of an empty string
Fixes issue 308.
R=rsc
CC=golang-dev
http://codereview.appspot.com/157142
|
|
R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
|
|
R=rsc
http://codereview.appspot.com/159044
|
|
in order of discovery.
R=rsc
http://codereview.appspot.com/157112
|
|
simple regexps run 20x faster.
the regex-dna benchmark goes 3x faster.
R=rsc
CC=golang-dev
http://codereview.appspot.com/156108
|
|
1) if char class contains a single character, make it a single character.
(this is used to quote, e.g. [.] rather than \.
2) if regexp begins with ordinary text substring, use plain string match to start engine
R=rsc
CC=golang-dev
http://codereview.appspot.com/157095
|
|
replace all calls with calls to copy
use copy in regexp and bytes.Buffer
R=rsc
CC=golang-dev
http://codereview.appspot.com/157073
|
|
performance hit of about 20% but more intuitive results for submatches.
we need a good regexp package at some point.
Fixes issue 110.
R=rsc
CC=golang-dev
http://codereview.appspot.com/152131
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/152118
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)
R=rsc, r
http://go/go-review/1024041
|
|
R=rsc, r
http://go/go-review/1025029
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
(one-line functions will be re-established once we have all
formatted uniformly)
R=r
http://go/go-review/1023004
|
|
R=r
http://go/go-review/1019005
|
|
R=rsc
http://go/go-review/1016041
|
|
R=rsc
CC=go-dev
http://go/go-review/1018021
|
|
during initialization.
R=rsc
CC=go-dev
http://go/go-review/1016023
|
|
R=gri
OCL=35485
CL=35488
|
|
syscall testing time unicode unsafe utf8
R=gri
DELTA=1409 (79 added, 24 deleted, 1306 changed)
OCL=35415
CL=35437
|
|
use strings.Buffer instead of bytes.Buffer in some places
R=rsc
DELTA=40 (0 added, 3 deleted, 37 changed)
OCL=34770
CL=34775
|
|
R=rsc
DELTA=152 (6 added, 0 deleted, 146 changed)
OCL=34695
CL=34701
|
|
the last round omitted := range and only
checked 1 out of N vars in a multi-var :=
R=r
OCL=34624
CL=34638
|
|
R=r
DELTA=112 (6 added, 57 deleted, 49 changed)
OCL=34610
CL=34610
|
|
after this CL, two more to come:
1) add an exhaustive test, probably as a variant of maketables
2) add ToUpper, ToLower, ToTitle and associated tests
R=rsc
DELTA=1578 (1007 added, 559 deleted, 12 changed)
OCL=33902
CL=33907
|
|
to whole-package compilation.
R=r
OCL=33070
CL=33101
|
|
inside testing.
remove "regexp." from regexp tests.
R=rsc
DELTA=1173 (1152 added, 1 deleted, 20 changed)
OCL=33028
CL=33037
|
|
AllMatchesStringIter, based on sawn and sawzall functions in sawzall.
APPROVED=rsc
DELTA=218 (218 added, 0 deleted, 0 changed)
OCL=32408
CL=32949
|
|
change the names; Match is for []byte and MatchString is for string, etc.
R=rsc
DELTA=195 (155 added, 0 deleted, 40 changed)
OCL=32800
CL=32800
|
|
R=rsc
DELTA=25 (23 added, 1 deleted, 1 changed)
OCL=32793
CL=32799
|
|
io.ByteBuffer -> bytes.Buffer
left io.ByteBuffer stub around for now,
for protocol compiler.
R=r
OCL=30861
CL=30872
|
|
APPROVED=r,rsc
DELTA=189 (187 added, 0 deleted, 2 changed)
OCL=30205
CL=30517
|
|
tests: all.bash passes, gobuild still works, godoc still works.
R=rsc
OCL=30096
CL=30102
|