Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Use a count of -1 for infinity. Ditto for Replace.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1704044
Committer: Rob Pike <r@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1722046
|
|
netchan, rpc, websocket: run test servers on 127.0.0.1,
to avoid conflict with OS X firewall.
TBR=r
CC=golang-dev
http://codereview.appspot.com/1689046
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1736042
|
|
x.go:13: cannot use t (type T) as type Reader in assignment:
T does not implement Reader (Read method requires pointer receiver)
x.go:19: cannot use q (type Q) as type Reader in assignment:
Q does not implement Reader (missing Read method)
have read()
want Read()
x.go:22: cannot use z (type int) as type Reader in assignment:
int does not implement Reader (missing Read method)
x.go:24: too many arguments to conversion to complex: complex(1, 3)
R=ken2
CC=golang-dev
http://codereview.appspot.com/1736041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/989042
|
|
R=r
CC=golang-dev, rog
http://codereview.appspot.com/811046
|
|
Fixes issue 675.
R=rsc, msolo
CC=golang-dev
http://codereview.appspot.com/882049
|
|
- don't log normal EOF
- fix ServeConn to block as documented
R=rsc, msolo
CC=golang-dev
http://codereview.appspot.com/886043
|
|
in the tests, println+panic.
gofmt some tests too.
R=rsc
CC=golang-dev
http://codereview.appspot.com/741041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/624042
|
|
usage pattern of http.Request and paves the way to persistent connection
handling.
R=rsc
CC=golang-dev
http://codereview.appspot.com/185043
Committer: Russ Cox <rsc@golang.org>
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
4th set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180049
|
|
Fixes issue 338.
R=rsc
CC=golang-dev
http://codereview.appspot.com/163083
|
|
R=rsc
http://codereview.appspot.com/157156
|
|
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes issue 115.
R=rsc, dsymonds1
http://codereview.appspot.com/157067
Committer: Russ Cox <rsc@golang.org>
|
|
Error information is carried from RPC server to client in the string
'Error' field of rpc.Response. An empty string is sent in the success
case. This empty string was being returned to the caller (of Client.Call
or Client.Go), resulting in a non-nil error response.
This change detects an empty-string Response.Error at the client, and
translates it into a nil value in Call.Error.
Tests updated to check error return in success cases.
R=r, rsc
http://codereview.appspot.com/154159
Committer: Rob Pike <r@golang.org>
|
|
rpc connection.
R=rsc
CC=golang-dev
http://codereview.appspot.com/155078
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)
R=rsc, r
http://go/go-review/1024041
|
|
R=rsc, r
http://go/go-review/1025029
|
|
address one in rpc/client.go
R=rsc
CC=go-dev
http://go/go-review/1026030
|
|
R=rsc
CC=go-dev
http://go/go-review/1026014
Committer: Russ Cox <rsc@golang.org>
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
R=rsc
http://go/go-review/1022002
|
|
added ReadFrom/WriteTo for packet protocols like UDP.
simplified the net.Conn interface.
added new net.PacketConn interface for packet protocols.
implemented proper UDP listener.
cleaned up LocalAddr/RemoteAddr methods - cache in netFD.
threw away various unused methods.
an interface change:
introduced net.Addr as a network address interface,
to avoid conversion of UDP host:port to string and
back for every ReadFrom/WriteTo sequence.
another interface change:
since signature of Listener.Accept was changing anyway,
dropped the middle return value, because it is available
as c.RemoteAddr(). (the Accept signature predates the
existence of that method.)
Dial and Listen still accept strings, but the proto-specific
versions DialTCP, ListenUDP, etc. take net.Addr instead.
because the generic Dial didn't change and because
no one calls Accept directly (only indirectly via the http
server), very little code will be affected by these interface
changes.
design comments welcome.
R=p
CC=go-dev, r
http://go/go-review/1018017
|
|
fix up one usage to take advantage.
R=rsc
CC=go-dev
http://go/go-review/1018023
|
|
syscall testing time unicode unsafe utf8
R=gri
DELTA=1409 (79 added, 24 deleted, 1306 changed)
OCL=35415
CL=35437
|
|
R=r
OCL=34731
CL=34731
|
|
the last round omitted := range and only
checked 1 out of N vars in a multi-var :=
R=r
OCL=34624
CL=34638
|
|
R=r
DELTA=112 (6 added, 57 deleted, 49 changed)
OCL=34610
CL=34610
|
|
to whole-package compilation.
R=r
OCL=33070
CL=33101
|
|
R=rsc
DELTA=28 (19 added, 0 deleted, 9 changed)
OCL=32550
CL=32554
|
|
R=rsc
OCL=32472
CL=32472
|
|
R=rsc
DELTA=121 (115 added, 0 deleted, 6 changed)
OCL=32427
CL=32429
|
|
R=rsc
DELTA=160 (124 added, 0 deleted, 36 changed)
OCL=32233
CL=32256
|
|
of use.
R=rsc
DELTA=31 (8 added, 2 deleted, 21 changed)
OCL=31778
CL=31792
|
|
R=rsc
DELTA=23 (4 added, 7 deleted, 12 changed)
OCL=31701
CL=31703
|
|
R=rsc
DELTA=5 (4 added, 1 deleted, 0 changed)
OCL=31690
CL=31692
|
|
1) terminate outstanding calls on the client when we see EOF from server
2) allow data to drain on server before closing the connection
R=rsc
DELTA=41 (23 added, 4 deleted, 14 changed)
OCL=31687
CL=31689
|