Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Cached string indexing in inner loop of Btoui64.
Before:
strconv_test.BenchmarkAtoi 5000000 309 ns/op
strconv_test.BenchmarkAtoiNeg 5000000 325 ns/op
strconv_test.BenchmarkAtoi64 5000000 465 ns/op
strconv_test.BenchmarkAtoi64Neg 5000000 469 ns/op
After:
strconv_test.BenchmarkAtoi 10000000 182 ns/op
strconv_test.BenchmarkAtoiNeg 10000000 193 ns/op
strconv_test.BenchmarkAtoi64 10000000 251 ns/op
strconv_test.BenchmarkAtoi64Neg 10000000 258 ns/op
R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/1227042
Committer: Robert Griesemer <gri@golang.org>
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
4th set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180049
|
|
R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)
R=rsc, r
http://go/go-review/1024041
|
|
R=rsc, r
http://go/go-review/1025029
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
leave that for Btoi with base == 0.
R=r
DELTA=146 (101 added, 29 deleted, 16 changed)
OCL=35584
CL=35593
|
|
syscall testing time unicode unsafe utf8
R=gri
DELTA=1409 (79 added, 24 deleted, 1306 changed)
OCL=35415
CL=35437
|
|
whole-package compilation. new Makefiles,
tests now in separate package
bytes
flag
fmt
io
math
once
os
reflect
strconv
sync
time
utf8
delete import "xxx" in package xxx.
inside package xxx, xxx is not declared
anymore so s/xxx.//g
delete file and package level forward declarations.
note the new internal_test.go and sync
and strconv to provide public access to
internals during testing. the installed version
of the package omits that file and thus does
not open the internals to all clients.
R=r
OCL=33065
CL=33097
|
|
R=r
DELTA=28 (5 added, 0 deleted, 23 changed)
OCL=31093
CL=31093
|
|
echo back context of call in error if likely to be useful.
For example, if os.Open("/etc/passwd", os.O_RDONLY)
fails with syscall.EPERM, it returns as the os.Error
&PathError{
Op: "open",
Path: "/etc/passwd"
Error: os.EPERM
}
which formats as
open /etc/passwd: permission denied
Not converted:
datafmt
go/...
google/...
regexp
tabwriter
template
R=r
DELTA=1153 (561 added, 156 deleted, 436 changed)
OCL=30738
CL=30781
|
|
tests: all.bash passes, gobuild still works, godoc still works.
R=rsc
OCL=30096
CL=30102
|