Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
panic if base is invalid.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1702050
|
|
Use a count of -1 for infinity. Ditto for Replace.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1704044
Committer: Rob Pike <r@golang.org>
|
|
Fixes issue 822.
Credit to http://codereview.appspot.com/1442041 by danielfleischman
R=rsc
CC=golang-dev
http://codereview.appspot.com/1738047
|
|
Fixes issue 845.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1673049
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1700043
|
|
Cached string indexing in inner loop of Btoui64.
Before:
strconv_test.BenchmarkAtoi 5000000 309 ns/op
strconv_test.BenchmarkAtoiNeg 5000000 325 ns/op
strconv_test.BenchmarkAtoi64 5000000 465 ns/op
strconv_test.BenchmarkAtoi64Neg 5000000 469 ns/op
After:
strconv_test.BenchmarkAtoi 10000000 182 ns/op
strconv_test.BenchmarkAtoiNeg 10000000 193 ns/op
strconv_test.BenchmarkAtoi64 10000000 251 ns/op
strconv_test.BenchmarkAtoi64Neg 10000000 258 ns/op
R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/1227042
Committer: Robert Griesemer <gri@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1081042
|
|
note that sortmain.go has been run through hg gofmt;
only the formatting of the day initializers changed.
i'm happy to revert that formatting if you'd prefer.
stop on error in doc/progs/run
R=r
CC=golang-dev
http://codereview.appspot.com/850041
|
|
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/773041
Committer: Robert Griesemer <gri@golang.org>
|
|
Fixes issue 639
R=rsc
CC=golang-dev
http://codereview.appspot.com/755041
|
|
in the tests, println+panic.
gofmt some tests too.
R=rsc
CC=golang-dev
http://codereview.appspot.com/741041
|
|
- gofmt -w src misc
- improves several lists and fixes minor degradation introduced
with the fix for issue 628
- removed some dead code (stringList)
R=rsc
CC=golang-dev
http://codereview.appspot.com/223058
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
4th set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180049
|
|
R=rsc
http://codereview.appspot.com/172041
|
|
R=rsc, r, r1
http://codereview.appspot.com/160046
Committer: Russ Cox <rsc@golang.org>
|
|
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes issue 115.
R=rsc, dsymonds1
http://codereview.appspot.com/157067
Committer: Russ Cox <rsc@golang.org>
|
|
R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
|
|
replace all calls with calls to copy
use copy in regexp and bytes.Buffer
R=rsc
CC=golang-dev
http://codereview.appspot.com/157073
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)
R=rsc, r
http://go/go-review/1024041
|
|
R=rsc, r
http://go/go-review/1025029
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
R=rsc
http://go/go-review/1019004
|
|
(and remove an empty line at the end of a file)
R=rsc
http://go/go-review/1017046
|
|
R=r
http://go/go-review/1016017
|
|
R=gri
http://go/go-review/1015011
|
|
leave that for Btoi with base == 0.
R=r
DELTA=146 (101 added, 29 deleted, 16 changed)
OCL=35584
CL=35593
|
|
R=gri
OCL=35485
CL=35488
|
|
syscall testing time unicode unsafe utf8
R=gri
DELTA=1409 (79 added, 24 deleted, 1306 changed)
OCL=35415
CL=35437
|
|
R=r
OCL=34731
CL=34731
|
|
the last round omitted := range and only
checked 1 out of N vars in a multi-var :=
R=r
OCL=34624
CL=34638
|
|
R=r
DELTA=112 (6 added, 57 deleted, 49 changed)
OCL=34610
CL=34610
|
|
%E - upper case %e
%G - upper case %g
%#v - Go syntax
R=r
DELTA=332 (238 added, 47 deleted, 47 changed)
OCL=34091
CL=34145
|
|
ReplacementChar.
utf8 package imports unicode to get those definitions.
regenerate dependencies.
R=rsc
DELTA=41 (19 added, 3 deleted, 19 changed)
OCL=34123
CL=34129
|
|
also drop bool arg from ReadString
R=r
DELTA=45 (13 added, 1 deleted, 31 changed)
OCL=33923
CL=33960
|
|
whole-package compilation. new Makefiles,
tests now in separate package
bytes
flag
fmt
io
math
once
os
reflect
strconv
sync
time
utf8
delete import "xxx" in package xxx.
inside package xxx, xxx is not declared
anymore so s/xxx.//g
delete file and package level forward declarations.
note the new internal_test.go and sync
and strconv to provide public access to
internals during testing. the installed version
of the package omits that file and thus does
not open the internals to all clients.
R=r
OCL=33065
CL=33097
|
|
R=r
DELTA=113 (89 added, 9 deleted, 15 changed)
OCL=31087
CL=31096
|
|
R=r
DELTA=28 (5 added, 0 deleted, 23 changed)
OCL=31093
CL=31093
|
|
echo back context of call in error if likely to be useful.
For example, if os.Open("/etc/passwd", os.O_RDONLY)
fails with syscall.EPERM, it returns as the os.Error
&PathError{
Op: "open",
Path: "/etc/passwd"
Error: os.EPERM
}
which formats as
open /etc/passwd: permission denied
Not converted:
datafmt
go/...
google/...
regexp
tabwriter
template
R=r
DELTA=1153 (561 added, 156 deleted, 436 changed)
OCL=30738
CL=30781
|
|
R=r
DELTA=32 (0 added, 3 deleted, 29 changed)
OCL=30718
CL=30725
|
|
R=rsc
APPROVED=r
DELTA=131 (39 added, 10 deleted, 82 changed)
OCL=30669
CL=30723
|
|
R=r
DELTA=69 (37 added, 3 deleted, 29 changed)
OCL=30661
CL=30667
|
|
remove io.ErrEOF.
rename io.FullRead to io.ReadFull, to match
ReadAtLeast and ReadAll.
remove io.FullReader, because it is now unused.
R=r
DELTA=295 (88 added, 105 deleted, 102 changed)
OCL=30544
CL=30588
|
|
tests: all.bash passes, gobuild still works, godoc still works.
R=rsc
OCL=30096
CL=30102
|