Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Use a count of -1 for infinity. Ditto for Replace.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1704044
Committer: Rob Pike <r@golang.org>
|
|
This is the Replace I suggested in the review of CL 1114041.
It's true that we already have
regexp.MustCompile(regexp.QuoteMeta(old)).ReplaceAll(s, new)
but because this Replace is doing a simpler job it is
simpler to call and inherently more efficient.
I will add the bytes implementation and tests to the
CL after the strings one has been reviewed.
R=r, cw
CC=golang-dev
http://codereview.appspot.com/1731048
|
|
Change TrimRight and TrimLeft to use these functions.
Incidentally fix minor bug in TrimRight.
Add some test cases for this.
YMMV whether it's worth saving the closure allocation.
R=r, r2
CC=golang-dev, hoisie, rsc
http://codereview.appspot.com/1198044
Committer: Rob Pike <r@golang.org>
|
|
R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/1072041
Committer: Robert Griesemer <gri@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/940041
Committer: Russ Cox <rsc@golang.org>
|
|
strings.Trim*Func functions.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/824051
Committer: Rob Pike <r@golang.org>
|
|
equivalents TrimFunc, TrimLeftFunc, TrimRightFunc
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/799048
Committer: Russ Cox <rsc@golang.org>
|
|
in character and string case mapping routines.
Add a custom mapper for Turkish and Azeri.
A more general solution for deriving the case information from Unicode's
SpecialCasing.txt will require more work.
Fixes issue 703.
R=rsc, rsc1
CC=golang-dev, mdakin
http://codereview.appspot.com/824043
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/833042
|
|
+ first use in go/doc
R=r
CC=golang-dev
http://codereview.appspot.com/781041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/223096
Committer: Russ Cox <rsc@golang.org>
|
|
gofmt -w -r 'strings.Bytes(a) -> []byte(a)' src/cmd src/pkg test/bench
gofmt -w -r 'strings.Runes(a) -> []int(a)' src/cmd src/pkg test/bench
delete unused imports
R=r
CC=golang-dev
http://codereview.appspot.com/224062
|
|
(per suggestion from Heresy.Mc@gmail.com)
R=rsc
CC=golang-dev
http://codereview.appspot.com/223052
|
|
R=rsc, r, phf
CC=golang-dev
http://codereview.appspot.com/170046
Committer: Russ Cox <rsc@golang.org>
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
4th set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180049
|
|
xml: drop invalid characters in attribute names
when constructing struct field names.
R=rsc
CC=r
http://codereview.appspot.com/157104
Committer: Russ Cox <rsc@golang.org>
|
|
Split: fixed typo in documentation
R=rsc, r, r1
http://codereview.appspot.com/157170
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 358.
R=rsc
CC=r
http://codereview.appspot.com/164043
|
|
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes issue 115.
R=rsc, dsymonds1
http://codereview.appspot.com/157067
Committer: Russ Cox <rsc@golang.org>
|
|
R=r, gri
CC=golang-dev
http://codereview.appspot.com/156115
|
|
also pick off the special case in strings.Index. don't want strings.IndexByte
because the call site will very rarely need to allocate and we can handle the
test in the code itself. bytes.IndexByte can avoid a common allocation.
R=rsc
CC=golang-dev
http://codereview.appspot.com/156091
|
|
copy of a string or a byte array.
strings.Repeat("-", 50)
bytes.Repeat(b, 99)
R=rsc
http://codereview.appspot.com/155063
Committer: Russ Cox <rsc@golang.org>
|
|
packages.
thanks to ulrik.sverdrup for the test case.
Fixes issue 191.
R=rsc
CC=golang-dev
http://codereview.appspot.com/155056
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)
R=rsc, r
http://go/go-review/1024041
|
|
R=rsc, r
http://go/go-review/1025029
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
R=r
http://go/go-review/1018064
|
|
most common usage is:
lines := strings.SplitAfter(text, "\n", 0)
R=r
http://go/go-review/1018042
|
|
add bytes.LastIndex.
add strings.Reader.
R=r
DELTA=59 (56 added, 0 deleted, 3 changed)
OCL=35585
CL=35601
|
|
R=rsc
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=35572
CL=35572
|
|
syscall testing time unicode unsafe utf8
R=gri
DELTA=1409 (79 added, 24 deleted, 1306 changed)
OCL=35415
CL=35437
|
|
delete strings.Buffer
add a test for a bug not caught before (mustn't install zero-length blocks)
R=rsc
DELTA=987 (289 added, 587 deleted, 111 changed)
OCL=34850
CL=34850
|
|
make strings.Buffer handle strings and bytes with comparable efficiency.
if ok, next step will be to move this code to bytes.Buffer and terminate
strings.Buffer's short happy life.
R=rsc
DELTA=292 (212 added, 0 deleted, 80 changed)
OCL=34837
CL=34849
|
|
can be made more efficient but this is reasonable.
R=rsc
DELTA=363 (363 added, 0 deleted, 0 changed)
OCL=34720
CL=34720
|
|
the last round omitted := range and only
checked 1 out of N vars in a multi-var :=
R=r
OCL=34624
CL=34638
|
|
R=rsc
DELTA=186 (181 added, 0 deleted, 5 changed)
OCL=34203
CL=34203
|
|
Change their names too.
R=rsc
DELTA=206 (123 added, 2 deleted, 81 changed)
OCL=34170
CL=34194
|