Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/982043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/953041
|
|
into a string of decimal numbers.
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/624041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/391041
|
|
- gofmt -w src misc
- looking for feedback
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/223076
|
|
Adds tests and fixes for two cases that fail with the current release.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/217115
Committer: Rob Pike <r@golang.org>
|
|
gofmt -w -r 'strings.Bytes(a) -> []byte(a)' src/cmd src/pkg test/bench
gofmt -w -r 'strings.Runes(a) -> []int(a)' src/cmd src/pkg test/bench
delete unused imports
R=r
CC=golang-dev
http://codereview.appspot.com/224062
|
|
- add extra test cases to go/printer tests
- apply gofmt to src and misc
R=rsc
CC=golang-dev
http://codereview.appspot.com/223041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/186169
|
|
Fixes issue 501.
R=rsc
CC=golang-dev
http://codereview.appspot.com/181183
|
|
Fixes issue 309.
R=rsc
CC=golang-dev
http://codereview.appspot.com/181044
|
|
Fixes issue 389.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180061
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
5th and last set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180050
|
|
R=rsc
http://codereview.appspot.com/172041
|
|
* diagnose template not created with New
(current code just crashes)
* write []byte uninterpreted
(current code writes fmt format: "[65 65 65 65]")
R=r
CC=golang-dev
http://codereview.appspot.com/161075
|
|
- removed New(len int) in favor of new(Vector).Resize(len, cap)
- removed Init(len int) in favor of Resize(len, cap)
- runs all.bash
Fixes issue 294.
R=rsc, r, r1
http://codereview.appspot.com/157143
|
|
Allows the developer to pass a map either by itself for
evaluation, or inside a struct. Access to data inside
maps is identical to the current system for structs, ie.
-Psuedocode-
mp map[string]string = {
"header" : "A fantastic header!",
"footer" : "A not-so-fantastic footer!",
}
template.Execute(mp)
...can be accessed using {header} and {footer} in
the template. Similarly, for maps inside structs:
type s struct {
mp map[string]string,
}
s1 = new s
s1.mp["header"] = "A fantastic header!";
template.Execute(s1)
...is accessed using {mp.header}. Multi-maps, ie.
map[string](map[string]string) and maps of structs
containing more maps are unsupported, but then, I'm
not even sure if that's supported by the language.
Map elements can be of any type that can be written
by the formatters. Keys should really only be strings.
Fixes issue 259.
R=r, rsc
http://codereview.appspot.com/157088
Committer: Rob Pike <r@golang.org>
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)
R=rsc, r
http://go/go-review/1024041
|
|
R=rsc, r
http://go/go-review/1025029
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
R=r
http://go/go-review/1018064
|
|
R=gri
http://go/go-review/1017014
|
|
R=gri
http://go/go-review/1015011
|
|
R=gri
OCL=35485
CL=35488
|
|
use strings.Buffer instead of bytes.Buffer in some places
R=rsc
DELTA=40 (0 added, 3 deleted, 37 changed)
OCL=34770
CL=34775
|
|
R=r
OCL=34731
CL=34731
|
|
R=rsc
DELTA=152 (6 added, 0 deleted, 146 changed)
OCL=34695
CL=34701
|
|
the last round omitted := range and only
checked 1 out of N vars in a multi-var :=
R=r
OCL=34624
CL=34638
|
|
* do full lookup for {.section},
so that it is always allowed to replace
{Foo} with {.section Foo}{@}{.end}
* treat False as empty so that .section can
be used to test bools
R=r
DELTA=29 (21 added, 0 deleted, 8 changed)
OCL=34215
CL=34219
|
|
R=r
APPROVED=r
DELTA=13 (11 added, 0 deleted, 2 changed)
OCL=34081
CL=34081
|
|
R=r,rsc
APPROVED=rsc
DELTA=194 (97 added, 32 deleted, 65 changed)
OCL=33861
CL=33933
|
|
to whole-package compilation.
R=r
OCL=33070
CL=33101
|
|
R=rsc
DELTA=23 (23 added, 0 deleted, 0 changed)
OCL=32592
CL=32595
|
|
R=rsc
DELTA=28 (19 added, 0 deleted, 9 changed)
OCL=32550
CL=32554
|
|
io.ByteBuffer -> bytes.Buffer
left io.ByteBuffer stub around for now,
for protocol compiler.
R=r
OCL=30861
CL=30872
|
|
tests: all.bash passes, gobuild still works, godoc still works.
R=rsc
OCL=30096
CL=30102
|