Age | Commit message (Collapse) | Author | Files | Lines |
|
R=rsc
http://codereview.appspot.com/159044
|
|
in order of discovery.
R=rsc
http://codereview.appspot.com/157112
|
|
fix %E: was same as %e.
add tests.
Fixes issue 278.
R=rsc
CC=golang-dev
http://codereview.appspot.com/157111
|
|
* add runtime sliceslice1 for x[lo:]
* remove runtime arraytoslice, rewriting &arr into arr[0:len(arr)].
* port cgen_inline into 8g, 5g.
* use native memmove in maps
R=ken2
http://codereview.appspot.com/157106
|
|
simple regexps run 20x faster.
the regex-dna benchmark goes 3x faster.
R=rsc
CC=golang-dev
http://codereview.appspot.com/156108
|
|
R=r
http://codereview.appspot.com/156104
|
|
Allows the developer to pass a map either by itself for
evaluation, or inside a struct. Access to data inside
maps is identical to the current system for structs, ie.
-Psuedocode-
mp map[string]string = {
"header" : "A fantastic header!",
"footer" : "A not-so-fantastic footer!",
}
template.Execute(mp)
...can be accessed using {header} and {footer} in
the template. Similarly, for maps inside structs:
type s struct {
mp map[string]string,
}
s1 = new s
s1.mp["header"] = "A fantastic header!";
template.Execute(s1)
...is accessed using {mp.header}. Multi-maps, ie.
map[string](map[string]string) and maps of structs
containing more maps are unsupported, but then, I'm
not even sure if that's supported by the language.
Map elements can be of any type that can be written
by the formatters. Keys should really only be strings.
Fixes issue 259.
R=r, rsc
http://codereview.appspot.com/157088
Committer: Rob Pike <r@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/157068
Committer: Russ Cox <rsc@golang.org>
|
|
io.Writer interfaces
There's no functional change here. io gives the Read and Write methods byte slice arguments, but tar called them uint8. It's the same thing, but I think this is clearer and it matches what other packages do.
R=rsc
CC=golang-dev
http://codereview.appspot.com/157099
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 269.
TBR=kaib
http://codereview.appspot.com/156107
|
|
1) if char class contains a single character, make it a single character.
(this is used to quote, e.g. [.] rather than \.
2) if regexp begins with ordinary text substring, use plain string match to start engine
R=rsc
CC=golang-dev
http://codereview.appspot.com/157095
|
|
R=r, rsc
http://codereview.appspot.com/157082
|
|
No benchmarks are run unless the --benchmarks=<regexp> flag
is specified on the gotest command line. This change includes
sample benchmarks for regexp.
% gotest --benchmarks=.*
(standard test output redacted)
testing.BenchmarkSimpleMatch 200000 7799 ns/op
testing.BenchmarkUngroupedMatch 20000 76898 ns/op
testing.BenchmarkGroupedMatch 50000 38148 ns/op
R=r, rsc
http://codereview.appspot.com/154173
Committer: Russ Cox <rsc@golang.org>
|
|
of keeping a checked-in copy. doesn't
slow down make.bash appreciably.
R=r
http://codereview.appspot.com/156099
|
|
thanks to lionkov for the fix.
Fixes issue 262.
R=rsc
CC=golang-dev
http://codereview.appspot.com/156097
|
|
Fixes issue 265.
R=r
CC=golang-dev
http://codereview.appspot.com/157084
|
|
R=rsc
http://codereview.appspot.com/156093
|
|
I missed a case.
R=rsc, agl
CC=golang-dev
http://codereview.appspot.com/156092
|
|
also pick off the special case in strings.Index. don't want strings.IndexByte
because the call site will very rarely need to allocate and we can handle the
test in the code itself. bytes.IndexByte can avoid a common allocation.
R=rsc
CC=golang-dev
http://codereview.appspot.com/156091
|
|
R=r
http://codereview.appspot.com/157077
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/157074
Committer: Russ Cox <rsc@golang.org>
|
|
TBR=rsc
R=rsc
http://codereview.appspot.com/157075
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/157056
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/156054
|
|
replace all calls with calls to copy
use copy in regexp and bytes.Buffer
R=rsc
CC=golang-dev
http://codereview.appspot.com/157073
|
|
- has arguments (no stack split)
- MOVL does not set condition
R=ken2, rsc
http://codereview.appspot.com/156086
|
|
Previously a netFd could be queued for reading/writing in the channel,
but close(2)'ed before pollServer got to it. In this case, the kernel
would consider the descriptor closed and the attempt to add it to the
epoll set would fail and panic.
This patch makes Close a roundtrip to the pollServer, although the
actual close(2) still occurs elsewhere to avoid blocking the
pollServer.
Fixes issue 143.
R=rsc
CC=golang-dev
http://codereview.appspot.com/152130
Committer: Adam Langley <agl@golang.org>
|
|
7x speedup on big and crypto/rsa unit tests.
also dropped useAsm in favor of making the
asm stubs jump to the Go versions.
R=agl1
CC=golang-dev, gri
http://codereview.appspot.com/157062
|
|
R=rsc
http://codereview.appspot.com/156077
Committer: Russ Cox <rsc@golang.org>
|
|
In thread.c, we need to cast to whatever the native
size of intptr is on the system, but we only have
uintptr available. They're the same size, but can't
do signed casts without this one :).
R=rsc
CC=golang-dev
http://codereview.appspot.com/156073
Committer: Russ Cox <rsc@golang.org>
|
|
This patchset gets Go to pretty much the same state that
FreeBSD/amd64 is in.
R=rsc
http://codereview.appspot.com/157055
Committer: Russ Cox <rsc@golang.org>
|
|
R=ken2
http://codereview.appspot.com/156063
|
|
* move memmove to arch-specific subdirectories
* add memmove for arm
* add copyright notices marking them as copied from Inferno
R=ken2
http://codereview.appspot.com/156061
|
|
threw in an embedded one for good measure.
R=rsc
CC=golang-dev
http://codereview.appspot.com/157058
|
|
R=r
http://codereview.appspot.com/156059
|
|
R=rsc
http://codereview.appspot.com/156056
|
|
did not test 386, but should work
shouldnt matter if copy is not used
R=rsc
http://codereview.appspot.com/156055
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/156051
|
|
* add Marshal
* add BitString.RightAlign
* change to using a *time.Time (from time.Time) since that's what
the time package uses.
* return the unparsed data from Unmarshal.
R=rsc
CC=golang-dev
http://codereview.appspot.com/156047
|
|
empty string for unnamed types.
Fixes issue 249.
R=r
http://codereview.appspot.com/156052
|
|
Fixes issue 233.
R=dsymonds1
http://codereview.appspot.com/154179
|
|
the signal handling stack is a different size than
the normal stack, so it cannot be allocated using
the backup stack allocator.
Fixes issue 250.
R=agl1
CC=golang-dev
http://codereview.appspot.com/157044
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/157042
|
|
Error information is carried from RPC server to client in the string
'Error' field of rpc.Response. An empty string is sent in the success
case. This empty string was being returned to the caller (of Client.Call
or Client.Go), resulting in a non-nil error response.
This change detects an empty-string Response.Error at the client, and
translates it into a nil value in Call.Error.
Tests updated to check error return in success cases.
R=r, rsc
http://codereview.appspot.com/154159
Committer: Rob Pike <r@golang.org>
|
|
(error introduced converting from arg1, arg2)
Fixes issue 220.
R=r
http://codereview.appspot.com/156041
|
|
Fixes issue 153.
R=r
http://codereview.appspot.com/154177
|
|
linux/386 stack trace: use 32-bit hex.
Fixes issue 159.
R=r
http://codereview.appspot.com/154178
|
|
cgo/libmach remain unimplemented. However, compilers, runtime,
and packages are 100%. I still need to go through and implement
missing syscalls (at least make sure they're all listed), but
for all shipped functionality, this is done. Ship! ;)
R=rsc, VenkateshSrinivas
http://codereview.appspot.com/152142
Committer: Russ Cox <rsc@golang.org>
|
|
decoder side.
Fix is to move all decoder state into the decoder object.
Fixes issue 215.
R=rsc
CC=golang-dev
http://codereview.appspot.com/155077
|
|
rpc connection.
R=rsc
CC=golang-dev
http://codereview.appspot.com/155078
|