Age | Commit message (Collapse) | Author | Files | Lines |
|
R=nigeltao_golang
CC=golang-dev, r, rsc
http://codereview.appspot.com/1690043
Committer: Nigel Tao <nigeltao@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1714044
|
|
Fixes issue 872.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1731043
|
|
Fixes issue 881.
R=iant
CC=golang-dev
http://codereview.appspot.com/1696044
|
|
move mal next to the other malloc functions.
R=r
CC=golang-dev
http://codereview.appspot.com/1701045
|
|
to make it easier to build package without assembly.
R=r, r2
CC=golang-dev
http://codereview.appspot.com/1680045
|
|
now net.go is only type definitions, not active code.
R=r
CC=golang-dev
http://codereview.appspot.com/1708046
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1715043
|
|
Ping IDs should be limited to 16-bits. Fix failure printing.
R=rsc
CC=golang-dev, jean-christophe smith <jeanchristophe.smith
http://codereview.appspot.com/1682043
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1724042
|
|
gob: substitute slice for map
R=r
CC=golang-dev
http://codereview.appspot.com/1699045
|
|
netchan, rpc, websocket: run test servers on 127.0.0.1,
to avoid conflict with OS X firewall.
TBR=r
CC=golang-dev
http://codereview.appspot.com/1689046
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1736042
|
|
update other code to match.
R=r
CC=golang-dev
http://codereview.appspot.com/1680044
|
|
x.go:13: cannot use t (type T) as type Reader in assignment:
T does not implement Reader (Read method requires pointer receiver)
x.go:19: cannot use q (type Q) as type Reader in assignment:
Q does not implement Reader (missing Read method)
have read()
want Read()
x.go:22: cannot use z (type int) as type Reader in assignment:
int does not implement Reader (missing Read method)
x.go:24: too many arguments to conversion to complex: complex(1, 3)
R=ken2
CC=golang-dev
http://codereview.appspot.com/1736041
|
|
TBR=r
CC=golang-dev
http://codereview.appspot.com/1706044
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1700043
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1693043
Committer: Rob Pike <r@golang.org>
|
|
R=iant, ken2, r, r2, ken3
CC=golang-dev
http://codereview.appspot.com/1686044
|
|
This CL replaces my earlier http://codereview.appspot.com/1640044/show
in which Continue handling was explicit. Instead, this CL makes
it automatic. Reading from Body() is an implicit acknowledgement
that the request headers were fine and the body is wanted. In that
case, the 100 Continue response is written automatically when the
request continues the "Expect: 100-continue" header.
R=rsc, adg
CC=golang-dev
http://codereview.appspot.com/1610042
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/1707042
|
|
While we're at it, clean up and test the code to guarantee we see every byte when
the text is erroneous UTF-8.
Fixes issue 866.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1712042
|
|
Fixes issue 852.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1680042
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1703041
|
|
Fix a bug that caused it to ignore field widths.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1704041
|
|
This shortens, simplifies and regularizes the code significantly.
(Improvements to reflect could make another step.)
Passes all.bash.
One semantic change occurs: The String() method changes
behavior. It used to run only for string formats such as %s and %q.
Instead, it now runs whenever the item has the method and the
result is then processed by the format as a string. Besides the
regularization, this has three effects:
1) width is honored for String() items
2) %x works for String() items
3) implementations of String that merely recur will recur forever
Regarding point 3, example from the updated documentation:
type X int
func (x X) String() string { return Sprintf("%d", x) }
should cast the value before recurring:
func (x X) String() string { return Sprintf("%d", int(x)) }
R=rsc
CC=golang-dev
http://codereview.appspot.com/1613045
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1701041
|
|
Change TrimRight and TrimLeft to use these functions.
Incidentally fix minor bug in TrimRight.
Add some test cases for this.
YMMV whether it's worth saving the closure allocation.
R=r, r2
CC=golang-dev, hoisie, rsc
http://codereview.appspot.com/1198044
Committer: Rob Pike <r@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1662041
|
|
Make dpix variable names consistent.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1563041
|
|
Cannot assume that g == m->curg at time of signal.
Must save actual g and restore.
Fixes flaky crashes with messages like
throw: malloc mlookup
throw: malloc/free - deadlock
throw: unwindstack on self
throw: free mlookup
(and probably others) when running cgo.
R=iant
CC=golang-dev
http://codereview.appspot.com/1648043
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1381041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1652041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1633042
|
|
Although technically incorrect, we want this in order to parse X.509
certificates where a wildcard hostname ("*.example.com") has been put
into a PrintableString.
Fixes issue 850.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1615043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1599043
|
|
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/1636043
|
|
* Code for assignment, conversions now mirrors spec.
* Changed some snprint -> smprint.
* Renamed runtime functions to separate
interface conversions from type assertions:
convT2I, assertI2T, etc.
* Correct checking of \U sequences.
Fixes issue 840.
Fixes issue 830.
Fixes issue 778.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1303042
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1620042
|
|
(remains of the semicolon conversion)
R=rsc
CC=golang-dev
http://codereview.appspot.com/1623041
|
|
(caused certain files to not be idempotent under gofmt)
- corrected golden files for go/printer
- slightly simplified some code in nodes.go (no impact on formatting)
- these changes have no impact on gofmt output of .go files under src, misc
fallthrough statement considered harmful!
R=rsc
CC=golang-dev
http://codereview.appspot.com/1593042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1581041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1514041
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1539042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1559041
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1548042
|
|
Time (us) to draw a 200x200 src onto an image.RGBA dst with the Over
operator. Each case was measured three separate times, and the sorted
times are reported.
Fill case (where src is an image.ColorImage):
Before:
7438, 7511, 7526
After:
3073, 3087, 3102
Copy case (where src is an image.RGBA):
Before:
9506, 9510, 9563
After:
5262, 5300, 5344
R=rsc
CC=golang-dev
http://codereview.appspot.com/1532041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1533041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1518042
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1472042
|