Age | Commit message (Collapse) | Author | Files | Lines |
|
added ReadFrom/WriteTo for packet protocols like UDP.
simplified the net.Conn interface.
added new net.PacketConn interface for packet protocols.
implemented proper UDP listener.
cleaned up LocalAddr/RemoteAddr methods - cache in netFD.
threw away various unused methods.
an interface change:
introduced net.Addr as a network address interface,
to avoid conversion of UDP host:port to string and
back for every ReadFrom/WriteTo sequence.
another interface change:
since signature of Listener.Accept was changing anyway,
dropped the middle return value, because it is available
as c.RemoteAddr(). (the Accept signature predates the
existence of that method.)
Dial and Listen still accept strings, but the proto-specific
versions DialTCP, ListenUDP, etc. take net.Addr instead.
because the generic Dial didn't change and because
no one calls Accept directly (only indirectly via the http
server), very little code will be affected by these interface
changes.
design comments welcome.
R=p
CC=go-dev, r
http://go/go-review/1018017
|
|
Rather than drop everything into a single, huge review, I've included
some simple bits of code here.
R=rsc
CC=go-dev
http://go/go-review/1016029
|
|
R=r
CC=iant
http://go/go-review/1018024
|
|
fix up one usage to take advantage.
R=rsc
CC=go-dev
http://go/go-review/1018023
|
|
R=rsc, agl
http://go/go-review/1016028
|
|
Firstly, with -Werror, GCC switched to printing warnings starting
with "error:". Widening the string matches solves this as the messages
are otherwise unchanged.
Secondly, GCC 4.4 outputs DWARF sections with with NUL bytes in all
the offsets and requires the relocation section for .debug_info to be
processed in order to result in valid DWARF data. Thus we add minimal
handling for relocation sections, which is sufficient for our needs.
BUG=1
Fixes issue 1.
R=rsc, iant
CC=go-dev
http://go/go-review/1017003
|
|
global regexps.
R=rsc, gri
CC=go-dev
http://go/go-review/1016025
|
|
R=rsc
CC=go-dev
http://go/go-review/1018021
|
|
R=rsc
CC=go-dev
http://go/go-review/1018020
|
|
R=ken@golang.org
CC=r
http://go/go-review/1018019
|
|
during initialization.
R=rsc
CC=go-dev
http://go/go-review/1016023
|
|
just a single directory
- all pieces present but not well integrated
- directory tree served at the moment under /tree
R=rsc
http://go/go-review/1018016
|
|
(previously not shown in godoc)
- simplify parsing of struct types (match code structure for parsing interface types)
R=rsc, r
http://go/go-review/1016019
|
|
fix nil pointer check in 6g.
was dereferencing after the ADD;
dereference before instead.
R=ken@golang.org
CC=iant
http://go/go-review/1016022
|
|
left, like an assignment, like strcpy, etc.
R=rsc
CC=go-dev
http://go/go-review/1016011
|
|
(I should have tested the last change a bit more before
submitting).
R=rsc
http://go/go-review/1017011
|
|
to build 6g, 6l, etc.
R=rsc
CC=go-dev
http://go/go-review/1018015
|
|
were excluded before because of incorrect comment
formatting (comment formatting is mostly idempotent
at this point)
R=rsc
http://go/go-review/1018014
|
|
already removed from the Makefile.
R=rsc
http://go/go-review/1017006
|
|
prior to cleanup. no changes, only moving.
remove dependencies on strconv and strings
R=r
http://go/go-review/1017010
|
|
* rename PORT.sh -> mkall.sh (hopefully more obvious),
change behavior: run commands by default.
* pull more constants out of #defines automatically,
instead of editing large lists by hand.
* add Recvfrom, Sendto
add os.O_EXCL.
R=r
http://go/go-review/1017009
|
|
(and thus avoid re-indexing after every sync attempt)
R=rsc
http://go/go-review/1016010
|
|
dir_* and stat_* are just os specific,
not os+arch-specific.
R=r
http://go/go-review/1018010
|
|
R=r
http://go/go-review/1016017
|
|
now that reflection supports it.
R=r
http://go/go-review/1015008
|
|
allow Makefiles using Make.pkg to specify a
list of directories that should be installed
before trying to build the package.
this is a stopgap for small package trees
maintained outside the standard tree.
R=r
http://go/go-review/1016012
|
|
R=rsc
CC=go-dev
http://go/go-review/1016005
|
|
R=rsc
http://go/go-review/1018005
|
|
R=agl
CC=rsc
http://go/go-review/1016008
|
|
- print comments line by line, strip common prefix but do not
modify comment contents otherwise
- align comments with subsequent keyword if indicated (e.g. case labels)
- terminate "column section" after multi-line expressions for better alignment
R=rsc
http://go/go-review/1017002
|
|
and godoc/main.go.
R=gri
CC=r
http://go/go-review/1017005
|
|
R=rsc
http://go/go-review/1018006
|
|
go/test: passes 99% (343/347)
R=rsc
http://go/go-review/1016004
|
|
TBR=rsc
R=rsc
http://go/go-review/1017004
|
|
R=go-dev
APPROVED=rsc
DELTA=407 (400 added, 0 deleted, 7 changed)
OCL=36007
CL=36146
|
|
name.
R=rsc
APPROVED=rsc
DELTA=566 (566 added, 0 deleted, 0 changed)
OCL=35974
CL=36111
|
|
unsafe.Pointer references inside the C declarations.
R=go-dev
APPROVED=rsc
DELTA=1 (1 added, 0 deleted, 0 changed)
OCL=36063
CL=36063
|
|
R=rsc
CC=go-dev
http://go/go-review/1018003
|
|
selfree maintains a cache of Select structures for several sizes. In
newselect, we'll use an entry from the cache if one is found. However,
the Scase structures corresponding to a send may have been allocated
for the wrong size. In this case we'll write off the end of the Scase
into random memory and, generally, read some amount of junk in the
receive.
This patch fixes the issue by removing the cache, on the advice of
rsc.
R=rsc
CC=go-dev
http://go/go-review/1016002
|
|
- replaced deprecated use of </font> with </span> tag
- added html escaping to godoc formatters where missing
- enabled text format for package documentation
R=rsc
http://go/go-review/1017001
|
|
when switching architectures.
fix bug twice: make sure clean removes the file,
and generate into architecture-specific file names.
R=r
http://go/go-review/1013018
|
|
R=rsc
http://go/go-review/1013017
|
|
R=gri
http://go/go-review/1015011
|
|
R=rsc
http://go/go-review/1015017
|
|
- sort by package name (instead of package path) for results with snippets
- sort line numbers in results without snippets
- properly characterize package clauses
- experiment with a leaner look: no underlines for top-level godoc links in the left side bar
Still using colors to distinguish results. Next step.
R=rsc
http://go/go-review/1015016
|
|
- added goroutine to automatically index in the background
- added handler for search requests
- added search box to top-level godoc template
- added search.html template for the display of search results
- changes to spec.go because of name conflicts
- added extra styles to style.css (for shorter .html files)
R=rsc
http://go/go-review/1014011
|
|
call. This uses the header files from a 32-bit Ubuntu Hardy
system.
The use of _LOOSE_KERNEL_NAMES seems right. The
-D__ARCH_SI_UID_T works around a bug which appears to be fixed
in later Linux versions.
R=rsc
http://go/go-review/1013015
|
|
R=rsc
http://go/go-review/1013016
|
|
- fixed several bugs
R=rsc
http://go/go-review/1015015
|
|
R=rsc
http://go/go-review/1015014
|