Age | Commit message (Collapse) | Author | Files | Lines |
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1522041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1503041
|
|
charclass to avoid unnecessarily iterating over ranges.
Also, use the fact that IntVector is an []int to avoid method calls.
On my machine, this brings us from ~27500 ns/op to ~17500 ns/op in the benchmark I've added (it is also faster in the case where a range check
doesn't help, added a benchmark for this too.)
I'd also like to propose that "[]", and "[^]" be disallowed. They aren't useful as far as I can tell, they aren't widely supported, and they make reasoning about character classes a bit more complicated.
R=r
CC=golang-dev
http://codereview.appspot.com/1495041
Committer: Rob Pike <r@golang.org>
|
|
Also added more tests for acosh, hypot, log, log10, log2
in all_test.go.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1417041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1486041
|
|
On error, ReadSlice is defined to return the available data
and advance past that data, but it was not behaving that
way for err == ErrBufferFull, making it harder for callers to
handle well.
R=r
CC=golang-dev
http://codereview.appspot.com/1480041
|
|
- provide convenience functions for scanning strings
- enable Scanf etc.
- update doc comments
R=rsc
CC=golang-dev
http://codereview.appspot.com/1451044
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1372042
|
|
- implement scanning for all renamed types
(compiler bug stops complex from being renamable,
so it can't be tested but the code is there)
- %q %x for strings
- error handling now done with panic/recover
R=rsc
CC=golang-dev
http://codereview.appspot.com/1458041
|
|
- implement scanning for all renamed types
(compiler bug stops complex from being renamable,
so it can't be tested but the code is there)
- %q %x for strings
- error handling now done with panic/recover
R=rsc
CC=golang-dev
http://codereview.appspot.com/1458041
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1442042
|
|
Fixes issue 820.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1453041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1395041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1258044
Committer: Russ Cox <rsc@golang.org>
|
|
For example, earlier, the regexp would accept SIGQUEUE_MAX
as a unix signal with name SIGQUEUE. Now it is ignored.
R=iant
CC=golang-dev, golang-nuts, joel.sherrill
http://codereview.appspot.com/1452041
Committer: Ian Lance Taylor <iant@golang.org>
|
|
"change the encoding of uints...".
R=r
CC=golang-dev
http://codereview.appspot.com/1436041
|
|
Also, move Do() to vector.go, so that Do() for IntVector and StringVector
is autogenerated.
The only files edited are Makefile, defs.go, and vector.go. The rest are
autogenerated with "make generate".
R=r
CC=golang-dev, hoisie
http://codereview.appspot.com/1435041
Committer: Rob Pike <r@golang.org>
|
|
Fixes issue 821.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1434041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1433041
Committer: Rob Pike <r@golang.org>
|
|
use the same function.
simplifies the code significantly.
Still TODO:
- proper format handling
- strings
R=rsc
CC=golang-dev
http://codereview.appspot.com/1432041
|
|
- reimplement integer scanning to handle renamed basic integer types
- start implementation of Fscanf and Scanf; not yet ready for general use.
This intermediate CL is a useful checkpoint. A similar change needs to be
done for float and complex, but it seemed worth getting the approach
reviewed before making those changes.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1418041
|
|
R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/1145044
Committer: Andrew Gerrand <adg@golang.org>
|
|
It turns out that _cgo_malloc is used, via cmalloc in
runtime/cgocall.c, which is called by code generated by out.go
for the ·_C_CString function. I can't find a call to
_cgo_free, but given _cgo_malloc we might as well keep
_cgo_free. This patch fixes it so that it should work on
amd64.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1399041
|
|
Fixes issue 819.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1421041
|
|
Fixes issue 805.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1400041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1388041
|
|
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/1382041
Committer: Russ Cox <rsc@golang.org>
|
|
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/1383041
Committer: Russ Cox <rsc@golang.org>
|
|
read from standard input. Add description of scanning to
the package comment.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1390041
|
|
Fix Rectangle.Clip.
It could return a non-canonical rectangle if its arguments
did not overlap.
e.g. Rect(0, 0, 10, 10).Clip(Rect(0, 20, 10, 30)) -> Rect(0, 20, 10, 10)
R=rsc, r
CC=golang-dev, golang-dev
http://codereview.appspot.com/1290041
Committer: Rob Pike <r@golang.org>
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1326042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1315042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1315042
|
|
one found
R=r
CC=golang-dev
http://codereview.appspot.com/1331041
|
|
ModInverse is just a small wrapper around GcdInt, but it's nice to
have in order to be clear about what one is doing in other code.
R=gri, agl1
CC=golang-dev
http://codereview.appspot.com/1244045
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1316042
|
|
Still to do:
- composite types
- user-defined scanners
- format-driven scanning
The package comment will be updated when more of the functionality is in place.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1252045
|
|
On my laptop, time to prepare and write 800x600 pixels over the
socket falls from 125-ish ms to 80-ish ms.
Thanks to Roger Peppe for the suggestion.
R=r
CC=golang-dev
http://codereview.appspot.com/1228044
|
|
Fixes issue 806.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1281042
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1284041
|
|
TBR=nigeltao
CC=golang-dev
http://codereview.appspot.com/1259042
|
|
Fixes issue 771.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1267042
|
|
Fixes issue 807.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1283041
|
|
R=rsc
CC=golang-dev, r
http://codereview.appspot.com/1271041
Committer: Russ Cox <rsc@golang.org>
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1270041
Committer: Robert Griesemer <gri@golang.org>
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1278042
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1220046
|
|
Fixes issue 808.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1273042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1282041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1254044
|