Age | Commit message (Collapse) | Author | Files | Lines |
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1701041
|
|
Change TrimRight and TrimLeft to use these functions.
Incidentally fix minor bug in TrimRight.
Add some test cases for this.
YMMV whether it's worth saving the closure allocation.
R=r, r2
CC=golang-dev, hoisie, rsc
http://codereview.appspot.com/1198044
Committer: Rob Pike <r@golang.org>
|
|
various cleanup, deleting unused code
R=ken2
CC=golang-dev
http://codereview.appspot.com/1663041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1662041
|
|
Make dpix variable names consistent.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1563041
|
|
Cleans up a few other corner cases too.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1592045
|
|
Cannot assume that g == m->curg at time of signal.
Must save actual g and restore.
Fixes flaky crashes with messages like
throw: malloc mlookup
throw: malloc/free - deadlock
throw: unwindstack on self
throw: free mlookup
(and probably others) when running cgo.
R=iant
CC=golang-dev
http://codereview.appspot.com/1648043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1597044
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1627042
|
|
There's only one Go object file per package now,
so there's no need to parse the metadata and merge
metadata from multiple files. Just save the original
and use it as __.PKGDEF verbatim.
R=r
CC=golang-dev
http://codereview.appspot.com/1647042
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1597043
|
|
This avoids a crash when using cgo where glibc's malloc thinks
that it can use some of the memory following the symbol table.
This fails because the symbol table is mapped read-only, which
affects the whole page.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1616042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1381041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1652041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1633042
|
|
Although technically incorrect, we want this in order to parse X.509
certificates where a wildcard hostname ("*.example.com") has been put
into a PrintableString.
Fixes issue 850.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1615043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1599043
|
|
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/1636043
|
|
* disallow surrogate pair runes.
* diagnose impossible type assertions
* eliminate another static buffer.
* do not overflow lexbuf.
* add -u flag to disable package unsafe.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1619042
|
|
* Code for assignment, conversions now mirrors spec.
* Changed some snprint -> smprint.
* Renamed runtime functions to separate
interface conversions from type assertions:
convT2I, assertI2T, etc.
* Correct checking of \U sequences.
Fixes issue 840.
Fixes issue 830.
Fixes issue 778.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1303042
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1620042
|
|
(remains of the semicolon conversion)
R=rsc
CC=golang-dev
http://codereview.appspot.com/1623041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1621041
|
|
(caused certain files to not be idempotent under gofmt)
- corrected golden files for go/printer
- slightly simplified some code in nodes.go (no impact on formatting)
- these changes have no impact on gofmt output of .go files under src, misc
fallthrough statement considered harmful!
R=rsc
CC=golang-dev
http://codereview.appspot.com/1593042
|
|
Fixes issue 844.
R=ken2, rsc, ken3
CC=golang-dev
http://codereview.appspot.com/1593041
|
|
Fixes issue 827.
R=ken2
CC=golang-dev, rsc
http://codereview.appspot.com/1592041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1581041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1514041
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1539042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1559041
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1548042
|
|
Time (us) to draw a 200x200 src onto an image.RGBA dst with the Over
operator. Each case was measured three separate times, and the sorted
times are reported.
Fill case (where src is an image.ColorImage):
Before:
7438, 7511, 7526
After:
3073, 3087, 3102
Copy case (where src is an image.RGBA):
Before:
9506, 9510, 9563
After:
5262, 5300, 5344
R=rsc
CC=golang-dev
http://codereview.appspot.com/1532041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1533041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1518042
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1472042
|
|
- cannot send body
- should not send body-related headers
R=r
CC=golang-dev
http://codereview.appspot.com/1499041
|
|
Also fix an interface bug: white-space-delimited doesn't work well for cases like "%d, %d" on "23, 23")
R=rsc
CC=golang-dev
http://codereview.appspot.com/1502041
|
|
Was timing Exp, not Exp2.
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/1521042
Committer: Rob Pike <r@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1522041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1503041
|
|
charclass to avoid unnecessarily iterating over ranges.
Also, use the fact that IntVector is an []int to avoid method calls.
On my machine, this brings us from ~27500 ns/op to ~17500 ns/op in the benchmark I've added (it is also faster in the case where a range check
doesn't help, added a benchmark for this too.)
I'd also like to propose that "[]", and "[^]" be disallowed. They aren't useful as far as I can tell, they aren't widely supported, and they make reasoning about character classes a bit more complicated.
R=r
CC=golang-dev
http://codereview.appspot.com/1495041
Committer: Rob Pike <r@golang.org>
|
|
Also added more tests for acosh, hypot, log, log10, log2
in all_test.go.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1417041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1486041
|
|
On error, ReadSlice is defined to return the available data
and advance past that data, but it was not behaving that
way for err == ErrBufferFull, making it harder for callers to
handle well.
R=r
CC=golang-dev
http://codereview.appspot.com/1480041
|
|
- provide convenience functions for scanning strings
- enable Scanf etc.
- update doc comments
R=rsc
CC=golang-dev
http://codereview.appspot.com/1451044
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1372042
|
|
- implement scanning for all renamed types
(compiler bug stops complex from being renamable,
so it can't be tested but the code is there)
- %q %x for strings
- error handling now done with panic/recover
R=rsc
CC=golang-dev
http://codereview.appspot.com/1458041
|
|
- implement scanning for all renamed types
(compiler bug stops complex from being renamable,
so it can't be tested but the code is there)
- %q %x for strings
- error handling now done with panic/recover
R=rsc
CC=golang-dev
http://codereview.appspot.com/1458041
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1442042
|
|
Fixes issue 820.
R=rsc
CC=golang-dev
http://codereview.appspot.com/1453041
|