Age | Commit message (Collapse) | Author | Files | Lines |
|
This matches the old JSON package behavior.
All lowercase names are not as standard as I believed,
and it seems less surprising to need to write
type T struct { Field string "field" }
to get lower case (behavior after this CL) than it does to need
to write
type T struct { Field string "Field" }
to preserve the case (behavior before this CL).
Also test and fix unmarshal into non-nil interface
value or pointer.
Fixes issue 744.
R=r
CC=golang-dev
http://codereview.appspot.com/1013041
|
|
Added goroutine; got simpler.
Fixes deadlock when doing Read+Close
or Write+Close on same end.
R=r, cw
CC=golang-dev
http://codereview.appspot.com/994043
|
|
Fixes issue 734.
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/975042
Committer: Russ Cox <rsc@golang.org>
|
|
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/988042
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc, rsc1
CC=golang-dev
http://codereview.appspot.com/878046
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/897042
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1014041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/937042
Committer: Russ Cox <rsc@golang.org>
|
|
R=ken2, r, ken3
CC=golang-dev
http://codereview.appspot.com/1006041
|
|
R=adg, gri
CC=golang-dev, r
http://codereview.appspot.com/1008042
|
|
Depends on CL 957045, 980043, 1004043.
Fixes issue 715.
R=agl1, agl
CC=golang-dev
http://codereview.appspot.com/943043
|
|
Adds two more methods, Timeout and Temporary.
Implemented by os.Errno too. The intent is to make
the checks for os.EAGAIN a little less clunky.
It should also let us clean up a bug that Mike Solomon
pointed out: if a network server gets an "out of file descriptors"
error from Accept, the listener should not stop.
It will be able to check this because that error would
have Temporary() == true.
Also clean up some underscore names.
Fixes issue 442.
R=r
CC=golang-dev, msolo
http://codereview.appspot.com/957045
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1004043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/980043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1009041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/982043
|
|
More in line with other regexp packages
and egrep; accommodates overzealous escapers.
R=r
CC=golang-dev
http://codereview.appspot.com/1008041
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1007041
|
|
Enable package tests for Native Client build.
R=r
CC=golang-dev
http://codereview.appspot.com/957042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/970042
|
|
Changed most of the functions in nat.go to methods on nat.
R=gri
CC=golang-dev
http://codereview.appspot.com/976041
Committer: Robert Griesemer <gri@golang.org>
|
|
Uid, Gid become int.
File size info becomes int64.
Times become int64.
R=rsc, cw
CC=golang-dev
http://codereview.appspot.com/968042
|
|
R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/917042
Committer: Andrew Gerrand <adg@golang.org>
|
|
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/967041
Committer: Robert Griesemer <gri@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/953041
|
|
Fixes issue 733.
R=r
CC=golang-dev
http://codereview.appspot.com/958041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/971041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/970041
|
|
R=gri, eds
CC=golang-dev
http://codereview.appspot.com/947042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/940041
Committer: Russ Cox <rsc@golang.org>
|
|
This gives about a 6% performance improvement to pidigits.
Thanks to Russ for the suggestion.
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/957041
Committer: Russ Cox <rsc@golang.org>
|
|
There was a bug in makeN that caused lots of unnecessary
allocations. Fixing this exposed a few bugs in other
functions which worked when makeN allocated a new slice, but
failed when it simply resized an existing slice. The result
is a pretty big performance improvement. When running
pidigits, here were the numbers I got on amd64:
Before this change:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.09u 0.02s 2.11r
gc pidigits 12.68u 0.04s 12.72r
gc_B pidigits 12.71u 0.03s 12.75r
After:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.09u 0.00s 2.10r
gc pidigits 6.82u 0.00s 6.85r
gc_B pidigits 6.55u 0.01s 6.59r
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/953042
Committer: Russ Cox <rsc@golang.org>
|
|
Due to page boundary rounding, the header would have
been loaded as part of the text segment already, but this
change placates the "paxctl" tool on so-called hardened
Linux distributions (as if normal distributions weren't already
hard enough to use).
R=r
CC=golang-dev
http://codereview.appspot.com/954041
|
|
This yields a pretty significant performance boost to pidigits and there are still some improvements to be made. Here are my numbers:
amd64 w/ bignum:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.10u 0.00s 2.10r
gc pidigits 22.92u 0.02s 22.97r
gc_B pidigits 22.62u 0.00s 22.65r
amd64 w/ big:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.09u 0.02s 2.11r
gc pidigits 12.68u 0.04s 12.72r
gc_B pidigits 12.71u 0.03s 12.75r
386 w/ bignum:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.09u 0.00s 2.09r
gc pidigits 44.30u 0.01s 44.35r
gc_B pidigits 44.29u 0.03s 44.35r
386 w/ big:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.10u 0.00s 2.10r
gc pidigits 22.70u 0.06s 22.79r
gc_B pidigits 22.80u 0.09s 22.91r
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/881050
Committer: Russ Cox <rsc@golang.org>
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/955041
|
|
to avoid confusion with real cgo
R=r
CC=golang-dev
http://codereview.appspot.com/904046
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/823048
|
|
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/929041
Committer: Robert Griesemer <gri@golang.org>
|
|
strings.Trim*Func functions.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/824051
Committer: Rob Pike <r@golang.org>
|
|
Fixes issue 729.
R=ken2
CC=golang-dev
http://codereview.appspot.com/875048
|
|
SETSID does return an errno - any reason why it has been done this
way in zsyscall_linux_* ? Otherwise it should be the same as darwin.
From SETSID(2) on my Linux box:
ERRORS
On error, -1 is returned, and errno is set.
Fixes issue 730
R=rsc
CC=golang-dev
http://codereview.appspot.com/878047
|
|
xml: add support for XML marshalling embedded structs.
R=rsc
CC=golang-dev
http://codereview.appspot.com/837042
Committer: Russ Cox <rsc@golang.org>
|
|
packStructValue was cutting off last byte of uint32
in _Dns_msg.Unpack, use packRR for rr types
R=rsc
CC=golang-dev
http://codereview.appspot.com/844048
Committer: Russ Cox <rsc@golang.org>
|
|
This is the first of probably four separate CLs
for the new implementation of the json package.
The scanner is the core of the new implementation.
The other CLs would be the new decoder,
the new encoder, and support for JSON streams.
R=r
CC=golang-dev
http://codereview.appspot.com/802051
|
|
Fixes issue 675.
R=rsc, msolo
CC=golang-dev
http://codereview.appspot.com/882049
|
|
We were letting bignum decide, which caused problems with float literals with a leading 0.
R=gri
CC=golang-dev
http://codereview.appspot.com/816047
Committer: Robert Griesemer <gri@golang.org>
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/846050
Committer: Robert Griesemer <gri@golang.org>
|
|
R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/908044
Committer: Robert Griesemer <gri@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/872045
|
|
$ godoc xml | grep Copy\(\)
func (c CharData) Copy() CharData
func (c Comment) Copy() Comment
func (d Directive) Copy() Directive
func (p ProcInst) Copy() ProcInst
func (e StartElement) Copy() StartElement
--------------------------------------------
$ godoc -src xml | grep Copy\(\)
func (c CharData) Copy() CharData
--------------------------------------------
$ godoc -src xml Copy
func (c CharData) Copy() CharData { return CharData(makeCopy(c)) }
--------------------------------------------
The command "godoc -src pkg_name" should output the interface of the named package, but it excludes all duplicate entries. Also the command "godoc -src pkg_name method_name" will output the source code only for one method even if there are more of them with the same name in the same package. This patch set fixes this issue.
R=gri
CC=golang-dev
http://codereview.appspot.com/883051
Committer: Robert Griesemer <gri@golang.org>
|