summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2009-12-10rename exp/parser package to oldParserRobert Griesemer3-8/+13
to allow simultaneous import with the current go/parser R=rsc http://codereview.appspot.com/174053
2009-12-10implement NoSemis and NoStringConcat mode for go/printerRobert Griesemer2-5/+22
R=rsc http://codereview.appspot.com/174050
2009-12-10implemented InsertSemis mode for go/scannerRobert Griesemer2-20/+236
R=rsc http://codereview.appspot.com/175047
2009-12-10- unmodified copy of existing go/parser, not yet hooked upRobert Griesemer4-0/+2326
R=rsc CC=r http://codereview.appspot.com/175045
2009-12-10fix calling convention and make memmove restore the g and mKai Backman1-2/+10
registers. R=rsc http://codereview.appspot.com/166049
2009-12-10added SHUT_RD, SHOT_WR and xSHUT_RDWR to fix net compilation errorKai Backman1-0/+3
R=rsc http://codereview.appspot.com/165044
2009-12-09minor manual format correctionsRobert Griesemer2-3/+1
R=rsc http://codereview.appspot.com/172042
2009-12-09remove uses of string concatenation from src and misc directoryRobert Griesemer20-621/+620
R=rsc http://codereview.appspot.com/172041
2009-12-09added benchmarks to rand_test.go;Roger Peppe1-0/+15
removed superfluous field name in lockedSource. R=r, rsc http://codereview.appspot.com/170043 Committer: Russ Cox <rsc@golang.org>
2009-12-09syscalls can return negative i/o counts. fix bugs in ReadAt and WriteAt not ↵Rob Pike1-2/+2
to include negative counts in return values. R=rsc CC=golang-dev http://codereview.appspot.com/170044
2009-12-09Make the operations on the global rng thread safe.Roger Peppe1-1/+21
R=r, rsc CC=golang-dev http://codereview.appspot.com/168041 Committer: Russ Cox <rsc@golang.org>
2009-12-09Continuation of issue 221 fix. When 8g or 6g or 5g are called with aCharles L. Dorian5-5/+5
UTF-8 string, Yconv() converts it into an octal sequence. If the string converted to more than 30 bytes, the str buffer would overflow. For example, 4 Greek runes became 32 bytes, 3 Hiragana runes became 36 bytes, and 2 Gothic runes became 32 bytes. In 8l, 6l and 5l the function is Sconv(). For some reason, only 5l uses the constant STRINGSZ (defined as 200) for the buffer size. R=rsc http://codereview.appspot.com/168045 Committer: Russ Cox <rsc@golang.org>
2009-12-09json package: Fixed handling of nil valuesRoss Light2-1/+15
Fixes issue 400. R=golang-dev, rsc http://codereview.appspot.com/167058 Committer: Russ Cox <rsc@golang.org>
2009-12-09Added XTEA block cipher package to src/pkg/cryptoAdrian O'Grady5-0/+417
This is an adaption of the code from http://en.wikipedia.org/wiki/XTEA. The package also implements the block.Cipher interface so that it can be used with the various block modes. R=rsc http://codereview.appspot.com/157152 Committer: Russ Cox <rsc@golang.org>
2009-12-08runtime: start new darwin/amd64 threads on correct stack,Russ Cox1-11/+13
then enable stack check. R=r http://codereview.appspot.com/165100
2009-12-08bufio: use copy - significant speedup for writersRuss Cox1-12/+6
R=r http://codereview.appspot.com/167047
2009-12-08Fix stack on FreeBSD / add stack check across the boardDevon H. O'Dell8-10/+36
FreeBSD was passing stk as the new thread's stack base, while stk is the top of the stack in go. The added check should cause a trap if this ever comes up in any new ports, or regresses in current ones. R=rsc CC=golang-dev http://codereview.appspot.com/167055 Committer: Russ Cox <rsc@golang.org>
2009-12-08When SA_SIGINFO is set, we should use __sa_sigaction on FreeBSDDevon H. O'Dell2-4/+4
R=rsc CC=golang-dev http://codereview.appspot.com/165097 Committer: Russ Cox <rsc@golang.org>
2009-12-076l, 8l: make string buffer big enough for 8 chars (and then some)Russ Cox2-2/+2
Fixes issue 221. R=ken2 http://codereview.appspot.com/165086
2009-12-07runtime: don't touch pages of memory unnecessarily.Russ Cox8-45/+15
cuts working size for hello world from 6 MB to 1.2 MB. still some work to be done, but diminishing returns. R=r http://codereview.appspot.com/165080
2009-12-07runtime: introduce unsafe.New and unsafe.NewArrayRuss Cox7-38/+79
to provide functionality previously hacked in to reflect and gob. R=r http://codereview.appspot.com/165076
2009-12-07use a bootstrap array to avoid allocation for short vectorsRobert Griesemer2-16/+30
R=r http://codereview.appspot.com/165078
2009-12-07Remove copyBytes completely in favor of copy.Christopher Wedgwood1-11/+2
R=r, rsc http://codereview.appspot.com/165068 Committer: Rob Pike <r@golang.org>
2009-12-07pick off special one-byte case in copy. worth 2x in benchmarks (38ns->16ns).Rob Pike1-1/+5
the one-item case could be generalized easily with no cost. worth considering. R=rsc CC=golang-dev, cw http://codereview.appspot.com/167044
2009-12-07the AST walker currently provides no way to find out how theRoger Peppe2-57/+61
nodes in the tree are nested with respect to one another. a simple change to the Visitor interface makes it possible to do this (for example to maintain a current node-depth, or a knowledge of the name of the current function). Visit(nil) is called at the end of a node's children; this make possible the channel-based interface below, amongst other possibilities. It is still just as simple to get the original behaviour - just return the same Visitor from Visit. Here are a couple of possible Visitor types. // closure-based type FVisitor func(n interface{}) FVisitor func (f FVisitor) Visit(n interface{}) Visitor { return f(n); } // channel-based type CVisitor chan Visit; type Visit struct { node interface{}; reply chan CVisitor; }; func (v CVisitor) Visit(n interface{}) Visitor { if n == nil { close(v); } else { reply := make(chan CVisitor); v <- Visit{n, reply}; r := <-reply; if r == nil { return nil; } return r; } return nil; } R=gri CC=rsc http://codereview.appspot.com/166047 Committer: Robert Griesemer <gri@golang.org>
2009-12-06save a few ns by inlining (which mostly simplifies things anyway).Rob Pike2-114/+100
a couple of cleanups. don't keep big buffers in the free list. R=rsc CC=golang-dev http://codereview.appspot.com/166078
2009-12-06unexport Fmt. it's not needed outside this package any moreRob Pike2-205/+179
cleans up godoc's output for package fmt substantially. R=rsc CC=golang-dev http://codereview.appspot.com/165070
2009-12-06Make printing faster by avoiding mallocs and some other advances.Rob Pike4-415/+423
Roughly 33% faster for simple cases, probably more for complex ones. Before: mallocs per Sprintf(""): 4 mallocs per Sprintf("xxx"): 6 mallocs per Sprintf("%x"): 10 mallocs per Sprintf("%x %x"): 12 Now: mallocs per Sprintf(""): 2 mallocs per Sprintf("xxx"): 3 mallocs per Sprintf("%x"): 5 mallocs per Sprintf("%x %x"): 7 Speed improves because of avoiding mallocs and also by sharing a bytes.Buffer between print.go and format.go rather than copying the data back after each printed item. Before: fmt_test.BenchmarkSprintfEmpty 1000000 1346 ns/op fmt_test.BenchmarkSprintfString 500000 3461 ns/op fmt_test.BenchmarkSprintfInt 500000 3671 ns/op Now: fmt_test.BenchmarkSprintfEmpty 2000000 995 ns/op fmt_test.BenchmarkSprintfString 1000000 2745 ns/op fmt_test.BenchmarkSprintfInt 1000000 2391 ns/op fmt_test.BenchmarkSprintfIntInt 500000 3751 ns/op I believe there is more to get but this is a good milestone. R=rsc CC=golang-dev, hong http://codereview.appspot.com/166076
2009-12-06runtime: disable pointer scan optimizationRuss Cox1-1/+3
* broken by reflect, gob TBR=r http://codereview.appspot.com/166077
2009-12-04Fix syscall.Statfs and syscall.Fstatfs for 386 GNU/Linux.Ian Lance Taylor2-14/+12
For 386 we use the [f]statfs64 system call, which takes three parameters: the filename, the size of the statfs64 structure, and a pointer to the structure itself. R=rsc http://codereview.appspot.com/166073
2009-12-04gc/runtime: pass type structure to makeslice.Russ Cox7-17/+201
* inform garbage collector about memory with no pointers in it 1.9s gcc reverse-complement.c reverse-complement.go 4.5s / 3.5s original, with/without bounds checks 3.5s / 3.3s bounds check reduction 3.3s / 2.8s smarter garbage collector 2.6s / 2.3s assembler bytes.IndexByte 2.5s / 2.1s even smarter garbage collector (this CL) R=r http://codereview.appspot.com/165064
2009-12-04gc: walk pointer in range on slice/arrayRuss Cox1-4/+21
R=ken2 http://codereview.appspot.com/166071
2009-12-046g/8g optimizer fix: throw functions now in runtimeRuss Cox2-8/+8
R=ken2 http://codereview.appspot.com/166070
2009-12-04gotest: stop if the // gotest commands failRuss Cox1-1/+1
R=r http://codereview.appspot.com/166067
2009-12-04net: more fiddling with the udp test.Russ Cox1-1/+1
i don't know why the timeout needs to be so big. R=r http://codereview.appspot.com/165063
2009-12-04libmach: fix disassembly of MOVLQSXRuss Cox1-1/+1
R=r http://codereview.appspot.com/166068
2009-12-04gotest: ignore *_test.pb.goRuss Cox1-1/+1
R=r http://codereview.appspot.com/166064
2009-12-04Add syscall.Rename for NaCl. Fixes NaCl build.Ian Lance Taylor1-0/+4
R=rsc http://codereview.appspot.com/165062
2009-12-04runtime: shift the index for the sort by one.Adam Langley1-6/+2
Makes the code look cleaner, even if it's a little harder to figure out from the sort invariants. R=rsc CC=golang-dev http://codereview.appspot.com/165061
2009-12-04Add os.Rename.Ian Lance Taylor2-1/+31
R=rsc http://codereview.appspot.com/166058
2009-12-04Remove global chanlock.Adam Langley1-33/+75
On a microbenchmark that ping-pongs on lots of channels, this makes the multithreaded case about 20% faster and the uniprocessor case about 1% slower. (Due to cache effects, I expect.) R=rsc, agl CC=golang-dev http://codereview.appspot.com/166043
2009-12-04bytes: asm for bytes.IndexByteRuss Cox7-1/+96
PERFORMANCE DIFFERENCE SUMMARY amd64 386 2.2 GHz AMD Opteron 8214 HE (Linux) 3.0x faster 8.2x faster 3.60 GHz Intel Xeon (Linux) 2.2x faster 6.2x faster 2.53 GHz Intel Core2 Duo E7200 (Linux) 1.5x faster 4.4x faster 2.66 Ghz Intel Xeon 5150 (Mac Pro, OS X) 1.5x SLOWER 3.0x faster 2.33 GHz Intel Xeon E5435 (Linux) 1.5x SLOWER 3.0x faster 2.33 GHz Intel Core2 T7600 (MacBook Pro, OS X) 1.4x SLOWER 3.0x faster 1.83 GHz Intel Core2 T5600 (Mac Mini, OS X) none* 3.0x faster * but yesterday I consistently saw 1.4x SLOWER. DETAILS 2.2 GHz AMD Opteron 8214 HE (Linux) amd64 (3x faster) IndexByte4K 500000 3733 ns/op 1097.24 MB/s IndexByte4M 500 4328042 ns/op 969.10 MB/s IndexByte64M 50 67866160 ns/op 988.84 MB/s IndexBytePortable4K 200000 11161 ns/op 366.99 MB/s IndexBytePortable4M 100 11795880 ns/op 355.57 MB/s IndexBytePortable64M 10 188675000 ns/op 355.68 MB/s 386 (8.2x faster) IndexByte4K 500000 3734 ns/op 1096.95 MB/s IndexByte4M 500 4209954 ns/op 996.28 MB/s IndexByte64M 50 68031980 ns/op 986.43 MB/s IndexBytePortable4K 50000 30670 ns/op 133.55 MB/s IndexBytePortable4M 50 31868220 ns/op 131.61 MB/s IndexBytePortable64M 2 508851500 ns/op 131.88 MB/s 3.60 GHz Intel Xeon (Linux) amd64 (2.2x faster) IndexByte4K 500000 4612 ns/op 888.12 MB/s IndexByte4M 500 4835250 ns/op 867.44 MB/s IndexByte64M 20 77388450 ns/op 867.17 MB/s IndexBytePortable4K 200000 10306 ns/op 397.44 MB/s IndexBytePortable4M 100 11201460 ns/op 374.44 MB/s IndexBytePortable64M 10 179456800 ns/op 373.96 MB/s 386 (6.3x faster) IndexByte4K 500000 4631 ns/op 884.47 MB/s IndexByte4M 500 4846388 ns/op 865.45 MB/s IndexByte64M 20 78691200 ns/op 852.81 MB/s IndexBytePortable4K 100000 28989 ns/op 141.29 MB/s IndexBytePortable4M 50 31183180 ns/op 134.51 MB/s IndexBytePortable64M 5 498347200 ns/op 134.66 MB/s 2.53 GHz Intel Core2 Duo E7200 (Linux) amd64 (1.5x faster) IndexByte4K 500000 6502 ns/op 629.96 MB/s IndexByte4M 500 6692208 ns/op 626.74 MB/s IndexByte64M 10 107410400 ns/op 624.79 MB/s IndexBytePortable4K 200000 9721 ns/op 421.36 MB/s IndexBytePortable4M 100 10013680 ns/op 418.86 MB/s IndexBytePortable64M 10 160460800 ns/op 418.23 MB/s 386 (4.4x faster) IndexByte4K 500000 6505 ns/op 629.67 MB/s IndexByte4M 500 6694078 ns/op 626.57 MB/s IndexByte64M 10 107397600 ns/op 624.86 MB/s IndexBytePortable4K 100000 28835 ns/op 142.05 MB/s IndexBytePortable4M 50 29562680 ns/op 141.88 MB/s IndexBytePortable64M 5 473221400 ns/op 141.81 MB/s 2.66 Ghz Intel Xeon 5150 (Mac Pro, OS X) amd64 (1.5x SLOWER) IndexByte4K 200000 9290 ns/op 440.90 MB/s IndexByte4M 200 9568925 ns/op 438.33 MB/s IndexByte64M 10 154473600 ns/op 434.44 MB/s IndexBytePortable4K 500000 6202 ns/op 660.43 MB/s IndexBytePortable4M 500 6583614 ns/op 637.08 MB/s IndexBytePortable64M 20 107166250 ns/op 626.21 MB/s 386 (3x faster) IndexByte4K 200000 9301 ns/op 440.38 MB/s IndexByte4M 200 9568025 ns/op 438.37 MB/s IndexByte64M 10 154391000 ns/op 434.67 MB/s IndexBytePortable4K 100000 27526 ns/op 148.80 MB/s IndexBytePortable4M 100 28302490 ns/op 148.20 MB/s IndexBytePortable64M 5 454170200 ns/op 147.76 MB/s 2.33 GHz Intel Xeon E5435 (Linux) amd64 (1.5x SLOWER) IndexByte4K 200000 10601 ns/op 386.38 MB/s IndexByte4M 100 10827240 ns/op 387.38 MB/s IndexByte64M 10 173175500 ns/op 387.52 MB/s IndexBytePortable4K 500000 7082 ns/op 578.37 MB/s IndexBytePortable4M 500 7391792 ns/op 567.43 MB/s IndexBytePortable64M 20 122618550 ns/op 547.30 MB/s 386 (3x faster) IndexByte4K 200000 11074 ns/op 369.88 MB/s IndexByte4M 100 10902620 ns/op 384.71 MB/s IndexByte64M 10 181292800 ns/op 370.17 MB/s IndexBytePortable4K 50000 31725 ns/op 129.11 MB/s IndexBytePortable4M 50 32564880 ns/op 128.80 MB/s IndexBytePortable64M 2 545926000 ns/op 122.93 MB/s 2.33 GHz Intel Core2 T7600 (MacBook Pro, OS X) amd64 (1.4x SLOWER) IndexByte4K 200000 11120 ns/op 368.35 MB/s IndexByte4M 100 11531950 ns/op 363.71 MB/s IndexByte64M 10 184819000 ns/op 363.11 MB/s IndexBytePortable4K 500000 7419 ns/op 552.10 MB/s IndexBytePortable4M 200 8018710 ns/op 523.06 MB/s IndexBytePortable64M 10 127614900 ns/op 525.87 MB/s 386 (3x faster) IndexByte4K 200000 11114 ns/op 368.54 MB/s IndexByte4M 100 11443530 ns/op 366.52 MB/s IndexByte64M 10 185212000 ns/op 362.34 MB/s IndexBytePortable4K 50000 32891 ns/op 124.53 MB/s IndexBytePortable4M 50 33930580 ns/op 123.61 MB/s IndexBytePortable64M 2 545400500 ns/op 123.05 MB/s 1.83 GHz Intel Core2 T5600 (Mac Mini, OS X) amd64 (no difference) IndexByte4K 200000 13497 ns/op 303.47 MB/s IndexByte4M 100 13890650 ns/op 301.95 MB/s IndexByte64M 5 222358000 ns/op 301.81 MB/s IndexBytePortable4K 200000 13584 ns/op 301.53 MB/s IndexBytePortable4M 100 13913280 ns/op 301.46 MB/s IndexBytePortable64M 10 222572600 ns/op 301.51 MB/s 386 (3x faster) IndexByte4K 200000 13565 ns/op 301.95 MB/s IndexByte4M 100 13882640 ns/op 302.13 MB/s IndexByte64M 5 221411600 ns/op 303.10 MB/s IndexBytePortable4K 50000 39978 ns/op 102.46 MB/s IndexBytePortable4M 50 41038160 ns/op 102.20 MB/s IndexBytePortable64M 2 656362500 ns/op 102.24 MB/s R=r CC=golang-dev http://codereview.appspot.com/166055
2009-12-04make Native Client support build again,Russ Cox16-20/+155
add README explaining how to try the web demos. Fixes issue 339. R=r CC=barry.d.silverman, bss, vadim http://codereview.appspot.com/165057
2009-12-04testing: compute MB/s in benchmarksRuss Cox1-1/+11
R=r http://codereview.appspot.com/166060
2009-12-04avoid an allocation inside bytes.Buffer by providing a static array.Rob Pike1-8/+4
R=rsc http://codereview.appspot.com/165058
2009-12-038l: fix print line number format, buffer overflowRuss Cox1-4/+4
R=ken2 http://codereview.appspot.com/165059
2009-12-03net: turn off empty packet test by defaultRuss Cox1-2/+9
Fixes issue 374. R=r http://codereview.appspot.com/166053
2009-12-03gc: check for assignment to private fields during initializationRuss Cox1-2/+6
R=ken2 http://codereview.appspot.com/165055
2009-12-036g code gen bugKen Thompson2-11/+6
R=rsc http://codereview.appspot.com/166052
2009-12-03Add Count, Cycle, ZipWith, GroupBy, Repeat, RepeatTimes, Unique to exp/iterable.Michael Elkins2-25/+363
Modify iterFunc to take chan<- instead of just chan. R=rsc, dsymonds1 CC=golang-dev, r http://codereview.appspot.com/160064 Committer: Russ Cox <rsc@golang.org>