Age | Commit message (Collapse) | Author | Files | Lines |
|
Fixes bug 375.
R=rsc
http://codereview.appspot.com/165045
|
|
Fixes issue 176.
R=r
http://codereview.appspot.com/166044
|
|
R=r
http://codereview.appspot.com/164086
|
|
* throw away dead code
* add mlookup counter
* add malloc counter
* set up for blocks with no pointers
Fixes issue 367.
R=r
http://codereview.appspot.com/165050
|
|
this package,
so make it a local method (_String()).
R=rsc
CC=golang-dev
http://codereview.appspot.com/165049
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/165048
|
|
buffer allocation.
Use them in Copy and Copyn.
Speed up ReadFile by using ReadFrom and avoiding Copy altogether (a minor win).
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/166041
|
|
R=rsc
http://codereview.appspot.com/164095
Committer: Russ Cox <rsc@golang.org>
|
|
- fixes a godoc issue (for instance, "godoc os EOF" now shows an entry)
R=r
CC=rsc
http://codereview.appspot.com/165042
|
|
Fixes issue 238.
R=ken2
http://codereview.appspot.com/163098
|
|
Fixes issue 245.
R=ken2
http://codereview.appspot.com/164094
|
|
Fixes bug 292.
R=ken2
http://codereview.appspot.com/164093
|
|
Fixes issue 364.
R=ken2
http://codereview.appspot.com/164092
|
|
R=rsc
http://codereview.appspot.com/164090
|
|
Fixes issue 370.
R=ken2
http://codereview.appspot.com/163097
|
|
Fixes issue 371.
R=ken2
http://codereview.appspot.com/164091
|
|
this breaks the dependency of package io on package bytes.
R=rsc
CC=golang-dev
http://codereview.appspot.com/163085
|
|
Split: fixed typo in documentation
R=rsc, r, r1
http://codereview.appspot.com/157170
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
http://codereview.appspot.com/164085
|
|
in favor of tempname.
allows optimizer to do more.
unfortunately, optimizer seems to be broken; disable it.
R=ken2
http://codereview.appspot.com/163091
|
|
drop check in range over array.
drop check in [256]array indexed by byte.
R=ken2
http://codereview.appspot.com/163088
|
|
tabs for indentation even if -spaces is set.
Changes to gofmt:
- added -tabindent flag
- don't recompute parser and printer mode repeatedly
Changes to go/printer:
- provide new printing mode TabIndent
Changes to tabwriter:
- implement new mode TabIndent to use tabs independent
of the actual padding character for leading empty columns
- distinguish between minimal cell width and tab width
(tabwidth is only used if the output contains tabs,
minwidth and padding are always considered)
- fixed and added more comments
- some additional factoring
By default, -tabindent is disabled and the default gofmt
behavior is unchanged. By setting -spaces and -tabindent,
gofmt will use tabs for indentation but do any other
alignment with spaces. This permits a user to change the
visible indentation by simply changing the editor's tab
width and the code will remain properly aligned without
the need to rerun gofmt.
R=rsc
http://codereview.appspot.com/163068
|
|
Fixes issue 274.
R=r
CC=jonathan.r.hudson
http://codereview.appspot.com/163072
Committer: Russ Cox <rsc@golang.org>
|
|
How to reproduce:
$ mkdir /tmp/foo
$ cp /dev/null /tmp/foo/bar.go
$ chmod -r /tmp/foo/bar.go
$ gofmt /tmp/foo
open /tmp/foo/bar.go: permission denied
$ echo $? # should echo 2
0
$
Maybe you need to put a call to time.Sleep at the beginning of report().
R=gri
CC=golang-dev
http://codereview.appspot.com/164073
Committer: Robert Griesemer <gri@golang.org>
|
|
R=rsc
http://codereview.appspot.com/164071
|
|
Fixes issue 338.
R=rsc
CC=golang-dev
http://codereview.appspot.com/163083
|
|
can't mix slices and arrays now; perhaps that should be a TODO
R=rsc
http://codereview.appspot.com/164079
|
|
added random test to look for more.
Fixes issue 363.
R=r, cw
http://codereview.appspot.com/163071
|
|
Submitting as a TBR to fix the build.
R=dho, rsc
http://codereview.appspot.com/164078
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=hurtonm
http://codereview.appspot.com/164074
|
|
Fixes issue 271.
Fixes issue 321.
R=rsc, agl, cw
CC=golang-dev
http://codereview.appspot.com/163052
Committer: Russ Cox <rsc@golang.org>
|
|
the result.
R=rsc
http://codereview.appspot.com/163070
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/163069
|
|
Necessary for 163052
R=rsc
CC=golang-dev
http://codereview.appspot.com/164068
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/164069
Committer: Russ Cox <rsc@golang.org>
|
|
R=gri
http://codereview.appspot.com/163067
Committer: Robert Griesemer <gri@golang.org>
|
|
R=dho
CC=golang-dev
http://codereview.appspot.com/163061
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/163062
|
|
TBR=r
http://codereview.appspot.com/163064
|
|
Bad returns noticed by "Devon H. O'Dell" <devon.odell@gmail.com>.
Resolves Issue 360.
R=rsc, dho, agl, agl1
CC=ukai
http://codereview.appspot.com/163055
Committer: Adam Langley <agl@golang.org>
|
|
Also fixes issue 310 comment 5 error.
Fixes issue 310.
R=rsc
http://codereview.appspot.com/163042
Committer: Russ Cox <rsc@golang.org>
|
|
1) need to send slice and array types (was only sending element types)
2) compatibleType needs to use decoder's type map
R=rsc
CC=golang-dev
http://codereview.appspot.com/164062
|
|
R=rsc
http://codereview.appspot.com/164059
|
|
R=rsc
http://codereview.appspot.com/161050
|
|
Opening /dev/stdin can sometimes fail. For example, in the acme editor,
executing "Edit ,|gofmt" fails with:
open /dev/stdin: no such device or address
Executing "Edit ,|ls -l /dev/stdin /proc/self/fd/0" gives:
lrwxrwxrwx 1 root root 15 2009-09-07 02:17 /dev/stdin -> /proc/self/fd/0
lrwx------ 1 fhs users 64 2009-11-26 22:05 /proc/self/fd/0 -> socket:[5528230]
(This is my first change, and I've signed the individual contributor license agreement.)
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/162041
Committer: Robert Griesemer <gri@golang.org>
|
|
- simplified dealing with parse errors: no need to intersperse them in the source
- improve visibility of highlighted identifiers by showing them in bold
R=rsc
http://codereview.appspot.com/163051
|
|
The python script needs a checkout of xcb/proto to generate
an xproto.go file, which together with xgb.go provide functions
to access all of the core X11 protocol requests. I have included the
generated file.
Extensions and authentication methods are not implemented.
R=r, rsc, nigeltao_golang
http://codereview.appspot.com/162053
Committer: Russ Cox <rsc@golang.org>
|
|
This patch adds an ability to convert JSON-encoded data into
a hierarchy of Go's native data types.
R=rsc
CC=golang-dev
http://codereview.appspot.com/161060
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 358.
R=rsc
CC=r
http://codereview.appspot.com/164043
|
|
Also made sync.xadd public to help testing sync.RWMutex.
Also added unit tests for sync.RWMutex.
R=rsc
http://codereview.appspot.com/162044
Committer: Russ Cox <rsc@golang.org>
|