Age | Commit message (Collapse) | Author | Files | Lines |
|
(request by r)
- feature temporarily disabled
R=rsc
CC=r
http://go/go-review/1018052
|
|
R=r
http://go/go-review/1017034
|
|
hopefully no change
R=rsc
http://go/go-review/1017035
|
|
R=r
http://go/go-review/1018043
|
|
R=rsc
http://go/go-review/1016045
|
|
R=r
http://go/go-review/1018050
|
|
R=rsc
http://go/go-review/1018049
|
|
R=rsc
http://go/go-review/1018047
|
|
R=rsc
http://go/go-review/1018046
|
|
R=agl
CC=rsc
http://go/go-review/1017032
|
|
and parser.go and scanner_test.go which have minor formatting issues)
R=rsc
http://go/go-review/1016042
|
|
picked up by gofmt (they should not be modified) or godoc
(testdata should not be considered a potential package
directory)
R=rsc
http://go/go-review/1018045
|
|
R=r
http://go/go-review/1016044
|
|
R=rsc
http://go/go-review/1017030
|
|
most common usage is:
lines := strings.SplitAfter(text, "\n", 0)
R=r
http://go/go-review/1018042
|
|
R=r
http://go/go-review/1016039
|
|
R=rsc
http://go/go-review/1016041
|
|
- at the moment this also affects single-line function declarations
because we have disabled them at the moment (but not single-line
function literals)
R=rsc
http://go/go-review/1016040
|
|
R=rsc
http://go/go-review/1017028
|
|
R=rsc
http://go/go-review/1018036
|
|
R=rsc
http://go/go-review/1018039
|
|
R=rsc
http://go/go-review/1017027
|
|
- made ast.Spec nodes implement Node interface
- added extra test cases
R=rsc
http://go/go-review/1016038
|
|
R=rsc
http://go/go-review/1018038
|
|
TBR=r
http://go/go-review/1016037
|
|
seems to help on snow leopard.
TBR=r
http://go/go-review/1018035
|
|
R=rsc
CC=go-dev
http://go/go-review/1017026
|
|
R=rsc
http://go/go-review/1017025
|
|
R=rsc
CC=go-dev
http://go/go-review/1018034
|
|
document goyacc a little.
R=rsc
CC=go-dev
http://go/go-review/1017024
|
|
change string in usage message.
R=rsc
http://go/go-review/1017023
|
|
R=gri
http://go/go-review/1016034
|
|
fix the usage message.
R=rsc
CC=go-dev
http://go/go-review/1016033
|
|
- made package tree handler generic so it can work on any fs tree
- cleanups along the way
R=rsc
CC=r
http://go/go-review/1017020
|
|
R=rsc
http://go/go-review/1017022
|
|
R=rsc
CC=go-dev
http://go/go-review/1017021
|
|
R=rsc
CC=go-dev
http://go/go-review/1018028
|
|
For testing it can be useful to use a null random source (one which
always returns zero) to remove non-determinism from the tests.
However, when performing RSA blinding, the random blind ends up being
zero and it's hard to reverse a multiplication by zero.
R=rsc
CC=go-dev
http://go/go-review/1018033
|
|
add details about -d and -e flags in the loaders.
R=rsc
CC=go-dev
http://go/go-review/1018031
|
|
Each command gets a doc.go file for godoc to analyze. Its main
element is a package comment.
R=rsc
CC=go-dev
http://go/go-review/1018029
|
|
enough to make nm and oprofile work.
R=r
http://go/go-review/1017016
|
|
(which I uploaded at home and thus can't upload from here).
CL 1018027 was reviewed.
- added comments to scope.go
- commented out some code that is not yet needed
(and which showed up prominently in the documentation)
R=rsc
http://go/go-review/1017017
|
|
- start new sections if a field/method declaration spans multiple lines;
this avoids tabs from the previous line affecting the next field/method
R=rsc
http://go/go-review/1017015
|
|
R=rsc, r
CC=go-dev
http://go/go-review/1016001
|
|
(No visual change yet since the comments for
exported code snippets - as shown on the pkg
page - are not yet formatted using the standard
comment intersperse mechanism in the printer.
This is a TODO in the printer.)
R=rsc
http://go/go-review/1016031
|
|
R=gri
http://go/go-review/1017014
|
|
- removed some underbars in section headings for better looks
- various minor tweaks
R=rsc
http://go/go-review/1018026
|
|
- nodes.go implements ast node formatting
- printer.go implements the core printing functionality
and public interface
No code changes except for updating the import clauses
and adding a top-level comment to nodes.go.
R=rsc
http://go/go-review/1016026
|
|
also fix a error-printing bug in godoc.
R=gri
http://go/go-review/1016030
|
|
added ReadFrom/WriteTo for packet protocols like UDP.
simplified the net.Conn interface.
added new net.PacketConn interface for packet protocols.
implemented proper UDP listener.
cleaned up LocalAddr/RemoteAddr methods - cache in netFD.
threw away various unused methods.
an interface change:
introduced net.Addr as a network address interface,
to avoid conversion of UDP host:port to string and
back for every ReadFrom/WriteTo sequence.
another interface change:
since signature of Listener.Accept was changing anyway,
dropped the middle return value, because it is available
as c.RemoteAddr(). (the Accept signature predates the
existence of that method.)
Dial and Listen still accept strings, but the proto-specific
versions DialTCP, ListenUDP, etc. take net.Addr instead.
because the generic Dial didn't change and because
no one calls Accept directly (only indirectly via the http
server), very little code will be affected by these interface
changes.
design comments welcome.
R=p
CC=go-dev, r
http://go/go-review/1018017
|