Age | Commit message (Collapse) | Author | Files | Lines |
|
Rather than confuse people by linking to a spec we
don't fully support, let them just use the package docs.
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/1016041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/989044
|
|
Fixes issue 732.
R=ken2
CC=golang-dev
http://codereview.appspot.com/956050
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/989042
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/943047
|
|
R=r
CC=golang-dev, rog
http://codereview.appspot.com/811046
|
|
(composite literals in control clauses only need
parentheses if the literals start with a type name)
R=rsc
CC=golang-dev
http://codereview.appspot.com/962045
|
|
literal
within an if, for, or switch control clause
R=rsc
CC=golang-dev
http://codereview.appspot.com/943046
|
|
Fixes issue 748.
R=rsc
CC=golang-dev
http://codereview.appspot.com/946043
|
|
R=r, cw
CC=golang-dev
http://codereview.appspot.com/952041
|
|
This fixes a crash seen when viewing a directory list.
Fixes issue 747.
R=gri
CC=golang-dev, rsc
http://codereview.appspot.com/1010042
Committer: Robert Griesemer <gri@golang.org>
|
|
This matches the old JSON package behavior.
All lowercase names are not as standard as I believed,
and it seems less surprising to need to write
type T struct { Field string "field" }
to get lower case (behavior after this CL) than it does to need
to write
type T struct { Field string "Field" }
to preserve the case (behavior before this CL).
Also test and fix unmarshal into non-nil interface
value or pointer.
Fixes issue 744.
R=r
CC=golang-dev
http://codereview.appspot.com/1013041
|
|
Added goroutine; got simpler.
Fixes deadlock when doing Read+Close
or Write+Close on same end.
R=r, cw
CC=golang-dev
http://codereview.appspot.com/994043
|
|
Fixes issue 734.
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/975042
Committer: Russ Cox <rsc@golang.org>
|
|
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/988042
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc, rsc1
CC=golang-dev
http://codereview.appspot.com/878046
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/897042
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1014041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/937042
Committer: Russ Cox <rsc@golang.org>
|
|
R=ken2, r, ken3
CC=golang-dev
http://codereview.appspot.com/1006041
|
|
R=adg, gri
CC=golang-dev, r
http://codereview.appspot.com/1008042
|
|
Depends on CL 957045, 980043, 1004043.
Fixes issue 715.
R=agl1, agl
CC=golang-dev
http://codereview.appspot.com/943043
|
|
Adds two more methods, Timeout and Temporary.
Implemented by os.Errno too. The intent is to make
the checks for os.EAGAIN a little less clunky.
It should also let us clean up a bug that Mike Solomon
pointed out: if a network server gets an "out of file descriptors"
error from Accept, the listener should not stop.
It will be able to check this because that error would
have Temporary() == true.
Also clean up some underscore names.
Fixes issue 442.
R=r
CC=golang-dev, msolo
http://codereview.appspot.com/957045
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1004043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/980043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1009041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/982043
|
|
More in line with other regexp packages
and egrep; accommodates overzealous escapers.
R=r
CC=golang-dev
http://codereview.appspot.com/1008041
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1007041
|
|
Enable package tests for Native Client build.
R=r
CC=golang-dev
http://codereview.appspot.com/957042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/970042
|
|
Changed most of the functions in nat.go to methods on nat.
R=gri
CC=golang-dev
http://codereview.appspot.com/976041
Committer: Robert Griesemer <gri@golang.org>
|
|
Uid, Gid become int.
File size info becomes int64.
Times become int64.
R=rsc, cw
CC=golang-dev
http://codereview.appspot.com/968042
|
|
R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/917042
Committer: Andrew Gerrand <adg@golang.org>
|
|
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/967041
Committer: Robert Griesemer <gri@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/953041
|
|
Fixes issue 733.
R=r
CC=golang-dev
http://codereview.appspot.com/958041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/971041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/970041
|
|
R=gri, eds
CC=golang-dev
http://codereview.appspot.com/947042
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/940041
Committer: Russ Cox <rsc@golang.org>
|
|
This gives about a 6% performance improvement to pidigits.
Thanks to Russ for the suggestion.
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/957041
Committer: Russ Cox <rsc@golang.org>
|
|
There was a bug in makeN that caused lots of unnecessary
allocations. Fixing this exposed a few bugs in other
functions which worked when makeN allocated a new slice, but
failed when it simply resized an existing slice. The result
is a pretty big performance improvement. When running
pidigits, here were the numbers I got on amd64:
Before this change:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.09u 0.02s 2.11r
gc pidigits 12.68u 0.04s 12.72r
gc_B pidigits 12.71u 0.03s 12.75r
After:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.09u 0.00s 2.10r
gc pidigits 6.82u 0.00s 6.85r
gc_B pidigits 6.55u 0.01s 6.59r
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/953042
Committer: Russ Cox <rsc@golang.org>
|
|
Due to page boundary rounding, the header would have
been loaded as part of the text segment already, but this
change placates the "paxctl" tool on so-called hardened
Linux distributions (as if normal distributions weren't already
hard enough to use).
R=r
CC=golang-dev
http://codereview.appspot.com/954041
|
|
This yields a pretty significant performance boost to pidigits and there are still some improvements to be made. Here are my numbers:
amd64 w/ bignum:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.10u 0.00s 2.10r
gc pidigits 22.92u 0.02s 22.97r
gc_B pidigits 22.62u 0.00s 22.65r
amd64 w/ big:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.09u 0.02s 2.11r
gc pidigits 12.68u 0.04s 12.72r
gc_B pidigits 12.71u 0.03s 12.75r
386 w/ bignum:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.09u 0.00s 2.09r
gc pidigits 44.30u 0.01s 44.35r
gc_B pidigits 44.29u 0.03s 44.35r
386 w/ big:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.10u 0.00s 2.10r
gc pidigits 22.70u 0.06s 22.79r
gc_B pidigits 22.80u 0.09s 22.91r
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/881050
Committer: Russ Cox <rsc@golang.org>
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/955041
|
|
to avoid confusion with real cgo
R=r
CC=golang-dev
http://codereview.appspot.com/904046
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/823048
|
|
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/929041
Committer: Robert Griesemer <gri@golang.org>
|
|
strings.Trim*Func functions.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/824051
Committer: Rob Pike <r@golang.org>
|