Age | Commit message (Collapse) | Author | Files | Lines |
|
instead use pure substring matching to find template values.
this makes stdZulu unnecessary and allows formats
like "20060102 030405" (used in some internet protocols).
this makes Parse not handle years < 0000 or > 9999 anymore.
that seems like an okay price to pay, trading hypothetical
functionality for real functionality.
also changed the comments on the Time struct to use the
same reference date as the format and parse routines.
R=r
CC=golang-dev
http://codereview.appspot.com/833045
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/848041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/800042
|
|
This is for making the fluent interface idiom usable with gofmt.
R=gri
CC=golang-dev
http://codereview.appspot.com/802043
Committer: Robert Griesemer <gri@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/844041
|
|
main semantic change is to enforce single argument to panic.
runtime: change to 1-argument panic.
use String method on argument if it has one.
R=ken2, r
CC=golang-dev
http://codereview.appspot.com/812043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/833044
|
|
otherwise "make install" runs cp unconditionally
R=r
CC=golang-dev
http://codereview.appspot.com/802044
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/849041
|
|
note that sortmain.go has been run through hg gofmt;
only the formatting of the day initializers changed.
i'm happy to revert that formatting if you'd prefer.
stop on error in doc/progs/run
R=r
CC=golang-dev
http://codereview.appspot.com/850041
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/811042
|
|
Also minor reformatting.
R=rsc
CC=golang-dev
http://codereview.appspot.com/845041
Committer: Russ Cox <rsc@golang.org>
|
|
baby step toward panic+recover.
Fixes issue 349.
R=r
CC=golang-dev
http://codereview.appspot.com/825043
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/826042
|
|
+ various minor cleanups
Usage: godoc -src math Sin
R=rsc
CC=golang-dev
http://codereview.appspot.com/791041
|
|
publishing
the set() method and add() functions. But we rename add() to Var() for consistency.
Also rename FlagValue to Value for simplicity.
Also, delete the check for multiple settings for a flag. This makes it possible to
define a flag that collects values, such as into a slice of strings.
type flagVar []string
func (f *flagVar) String() string {
return fmt.Sprint(v)
}
func (f *flagVar) Set(value string) bool {
if v == nil {
v = make(flagVar, 1)
} else {
nv := make(flagVar, len(v)+1)
copy(nv, v)
v = nv
}
v[len(v)-1] = value
return true
}
var v flagVar
func main() {
flag.Var(&v, "testV", "multiple values build []string")
flag.Parse()
fmt.Printf("v = %v\n", v)
}
R=rsc
CC=golang-dev
http://codereview.appspot.com/842041
|
|
now runtime.MemStats.Sys really is the sum of all the other Sys fields.
R=r
CC=golang-dev
http://codereview.appspot.com/843041
|
|
Fixes issue 700.
R=ken2
CC=golang-dev
http://codereview.appspot.com/839041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/788041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/833042
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/837041
|
|
expvar: default publishings for cmdline, memstats
godoc: import expvar
R=r
CC=golang-dev
http://codereview.appspot.com/815041
|
|
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/773041
Committer: Robert Griesemer <gri@golang.org>
|
|
Fixes issue 698.
Fixes issue 699.
R=rsc
CC=golang-dev
http://codereview.appspot.com/824041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/823041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/763042
|
|
R=cemeyer, rsc
CC=golang-dev
http://codereview.appspot.com/809041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/800041
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 186.
R=ken2
CC=golang-dev
http://codereview.appspot.com/793041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/790041
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/787041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/786041
|
|
TBR=r
CC=golang-dev
http://codereview.appspot.com/785041
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/784041
|
|
This is a modified version of the open source pprof
from code.google.com/p/google-perftools.
That version is likely to catch up to this one,
but it's still useful to ship our own copy since
we only need the one script from that project,
not all the C++ libraries.
R=r
CC=golang-dev
http://codereview.appspot.com/783041
|
|
eliminate second pass of mark+sweep
by scanning finalizer table specially.
R=r
CC=golang-dev
http://codereview.appspot.com/782041
|
|
Also amend j0.go (variable name conflict, small corrections).
R=rsc
CC=golang-dev
http://codereview.appspot.com/769041
Committer: Russ Cox <rsc@golang.org>
|
|
In this change I'd like to combine the common code that is
present in syscall_darwin.go and syscall_freebsd.go. I
have three reasons for wanting to do this now:
1. reducing code duplication is nearly always good :-)
2. the duplication will get worse if I duplicate this code
a third time for the NetBSD port I'm working on, which
I need to do almost immediately
3. by making this change all in one lump and ignoring any
commonality with the syscall_linux*.go files the diff
is long but, I think, readable
In future it may be possible to cherry pick functions that
also apply to Linux and put them in (say) syscall_unix.go,
and of course some functions may diverge in future and have
to move out to OS or architecture specific files, but today
I want just the low hanging fruit.
Tested and passed on:
Darwin (Snow Leopard, 10.6): amd64 and 386
FreeBSD (8.0-RELEASE): 386 only(*)
(*) All my virtualisation software has stopped playing nice
with FreeBSD for the moment, so I don't have facilities to
test the amd64 port. As the OS X port is OK and the diff
looks all right to my eyes I shall keep my fingers crossed.
If someone with a FreeBSD/amd64 system cares to test and
report I would be appreciative.
2010-03-27 update: I have replaced my virtualisation software, and have working FreeBSD/i386 and FreeBSD/amd64 virtual machines again.
As I hoped (and expected -- programmers are optimists :-) the code built and passed all but the two currently known to fail tests on FreeBSD/amd64. I rechecked FreeBSD/i386 too: same results.
R=rsc
CC=golang-dev
http://codereview.appspot.com/751041
Committer: Russ Cox <rsc@golang.org>
|
|
+ first use in go/doc
R=r
CC=golang-dev
http://codereview.appspot.com/781041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/778041
|
|
R=nigeltao_golang, rsc
CC=golang-dev
http://codereview.appspot.com/759041
Committer: Russ Cox <rsc@golang.org>
|
|
- new heuristic: if both the opening { and closing } braces are on the
same line, and the function body doesn't contain comments or is other-
wise too long (e.g. signature too long), it is formatted as a one-line
function
- related cleanups along the way
- gofmt -w src misc led to no additional changes as expected
R=rsc, rsc1
CC=golang-dev, ken2, r
http://codereview.appspot.com/758041
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/760042
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/731041
|
|
Fixes issue 639
R=rsc
CC=golang-dev
http://codereview.appspot.com/755041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/733041
|
|
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/739042
Committer: Russ Cox <rsc@golang.org>
|
|
up to date.
No functional change, but when these files are regenerated
they change, leading to noisy diffs when working in the
syscall package.
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/705043
Committer: Russ Cox <rsc@golang.org>
|
|
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/747041
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/743041
|