Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/972046
Committer: Rob Pike <r@golang.org>
|
|
- renamed Len -> BitLen, simplified implementation
- renamed old Div, Mod, DivMod -> Que, Rem, QuoRem
- implemented Div, Mod, DivMod (Euclidian definition, more
useful in a mathematical context)
- fixed a bug in Exp (-0 was possible)
- added extra tests to check normalized results everywhere
- uniformly set Int.neg flag at the end of computations
- minor cosmetic cleanups
- ran all tests
R=rsc
CC=golang-dev
http://codereview.appspot.com/1091041
|
|
OLD fasta -n 25000000
gcc -O2 fasta.c 7.59u 0.06s 7.74r
gc fasta 9.54u 0.15s 9.84r
gc_B fasta 9.48u 0.10s 9.62r
NEW fasta -n 25000000
gcc -O2 fasta.c 2.59u 0.02s 2.66r
gc fasta 3.00u 0.03s 3.09r
gc_B fasta 2.72u 0.03s 2.81r
R=r
CC=golang-dev
http://codereview.appspot.com/1054041
|
|
- fixed a couple of bugs in the process
(shift right was incorrect for negative numbers)
- added more tests and made some tests more robust
- changed pidigits back to using shifts to multiply
by 2 instead of add
This improves pidigit -s -n 10000 by approx. 5%:
user 0m6.496s (old)
user 0m6.156s (new)
R=rsc
CC=golang-dev
http://codereview.appspot.com/963044
|
|
user time for pidigits -s -n=10000:
6.466s w/ adds
7.138s w/ shifts
R=rsc
CC=golang-dev
http://codereview.appspot.com/1021041
|
|
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/978042
Committer: Russ Cox <rsc@golang.org>
|
|
run reverse-complement only once. (garbage is no longer an issue)
R=rsc
CC=golang-dev
http://codereview.appspot.com/968041
|
|
This yields a pretty significant performance boost to pidigits and there are still some improvements to be made. Here are my numbers:
amd64 w/ bignum:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.10u 0.00s 2.10r
gc pidigits 22.92u 0.02s 22.97r
gc_B pidigits 22.62u 0.00s 22.65r
amd64 w/ big:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.09u 0.02s 2.11r
gc pidigits 12.68u 0.04s 12.72r
gc_B pidigits 12.71u 0.03s 12.75r
386 w/ bignum:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.09u 0.00s 2.09r
gc pidigits 44.30u 0.01s 44.35r
gc_B pidigits 44.29u 0.03s 44.35r
386 w/ big:
pidigits 10000
gcc -O2 pidigits.c -lgmp 2.10u 0.00s 2.10r
gc pidigits 22.70u 0.06s 22.79r
gc_B pidigits 22.80u 0.09s 22.91r
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/881050
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/881042
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/833044
|
|
gofmt -w -r 'strings.Bytes(a) -> []byte(a)' src/cmd src/pkg test/bench
gofmt -w -r 'strings.Runes(a) -> []int(a)' src/cmd src/pkg test/bench
delete unused imports
R=r
CC=golang-dev
http://codereview.appspot.com/224062
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/197043
|
|
some significant improvements:
reverse-complement
nbody (gccgo only)
regex-dna
pidigits
one mysterious drop:
binary-tree.go (gccgo only)
R=rsc
CC=golang-dev
http://codereview.appspot.com/181158
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
5th and last set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180050
|
|
This change removes the necessity to have GOBIN in $PATH,
and also doesn't assume that the build is being run from
$GOROOT/src. This is a minimal set of necessary changes
to get Go to build happily from the FreeBSD ports
collection.
R=rsc
CC=golang-dev
http://codereview.appspot.com/171044
Committer: Russ Cox <rsc@golang.org>
|
|
- remove use of implicit string concatenation
- these appear to be the only files correctly compiling under test
that used implicit string concatenation
R=rsc
http://codereview.appspot.com/172043
|
|
R=r
http://codereview.appspot.com/165083
Committer: Russ Cox <rsc@golang.org>
|
|
shootout.alioth.debian.org .
it's now there: http://shootout.alioth.debian.org/u32q/benchmark.php?test=chameneosredux&lang=all&box=1!
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/167043
Committer: Russ Cox <rsc@golang.org>
|
|
1.9s gcc reverse-complement.c
reverse-complement.go
4.5s / 3.5s original, with/without bounds checks
3.5s / 3.3s bounds check reduction
3.3s / 2.8s smarter garbage collector
2.6s / 2.3s assembler bytes.IndexByte
2.5s / 2.1s even smarter garbage collector
2.3s / 2.1s fix optimizer unnecessary spill bug
2.0s / 1.9s change loop to range (this CL)
R=r
http://codereview.appspot.com/166072
|
|
R=r
http://codereview.appspot.com/165065
|
|
this breaks the dependency of package io on package bytes.
R=rsc
CC=golang-dev
http://codereview.appspot.com/163085
|
|
unnamed, not require -n, in line with other
entries.
R=rsc
CC=r
http://codereview.appspot.com/162061
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/160054
|
|
based on suggestion from arvindht@gmail.com
R=r, rsc, r1
http://codereview.appspot.com/157091
Committer: Russ Cox <rsc@golang.org>
|
|
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes issue 115.
R=rsc, dsymonds1
http://codereview.appspot.com/157067
Committer: Russ Cox <rsc@golang.org>
|
|
except chameneosredux which i know is being edited
require gofmt for test/bench
R=r
http://codereview.appspot.com/157110
|
|
* reverse-complement: port C algorithm to Go
saves 30% on my MacBook Pro and makes it a fairer comparison.
* test reverse-complement with and without GC (another 15%)
* revise timing.sh to work on more systems
* avoid two glibcisms in fasta.c
R=r
http://codereview.appspot.com/156110
|
|
replace all calls with calls to copy
use copy in regexp and bytes.Buffer
R=rsc
CC=golang-dev
http://codereview.appspot.com/157073
|
|
performance hit of about 20% but more intuitive results for submatches.
we need a good regexp package at some point.
Fixes issue 110.
R=rsc
CC=golang-dev
http://codereview.appspot.com/152131
|
|
adjust an inconsistency in reflect/type.go's package comment
R=rsc
http://go/go-review/1026029
|
|
global regexps.
R=rsc, gri
CC=go-dev
http://go/go-review/1016025
|
|
various missing or incorrect files.
R=r
CC=go-dev
http://go/go-review/1014004
|
|
R=r
DELTA=40 (9 added, 3 deleted, 28 changed)
OCL=35277
CL=35305
|
|
R=rsc
DELTA=10 (10 added, 0 deleted, 0 changed)
OCL=34987
CL=34987
|
|
R=rsc
DELTA=57 (57 added, 0 deleted, 0 changed)
OCL=34896
CL=34901
|
|
R=r
OCL=34731
CL=34731
|
|
R=r
DELTA=127 (38 added, 3 deleted, 86 changed)
OCL=34640
CL=34650
|