Age | Commit message (Collapse) | Author | Files | Lines |
|
R=r
CC=golang-dev
http://codereview.appspot.com/199042
|
|
more to come, but should suffice for Printf work.
R=ken2
CC=golang-dev
http://codereview.appspot.com/197044
|
|
No longer a distinct type; now a property of func types.
R=ken2
CC=golang-dev
http://codereview.appspot.com/197042
|
|
I got it wrong because gccgo was incorrectly failing to clear
the value when a nonblocking receive did not receive
anything.
R=rsc
CC=golang-dev
http://codereview.appspot.com/194161
|
|
bug238.go:11:7: error: invalid constant type
bug238.go:12:7: error: invalid constant type
bug238.go:13:7: error: invalid constant type
bug238.go:14:7: error: invalid constant type
bug238.go:15:7: error: invalid constant type
bug238.go:16:7: error: invalid constant type
bug238.go:17:7: error: invalid constant type
R=rsc
CC=golang-dev
http://codereview.appspot.com/194159
|
|
8g:
runtime.go:19: cannot refer to unexported name runtime.printbool
gccgo:
runtime.go:19:10: error: invalid reference to unexported identifier ‘runtime.printbool’
R=rsc
CC=golang-dev
http://codereview.appspot.com/194157
|
|
bug231.go:20:4: error: incompatible types in assignment (type has no methods)
R=rsc
CC=golang-dev
http://codereview.appspot.com/194156
|
|
bug228.go:11:25: error: invalid use of ‘...’
bug228.go:13:13: error: ‘...’ only permits one name
bug228.go:15:20: error: ‘...’ must be last parameter
bug228.go:17:7: error: expected type
bug228.go:19:8: error: expected type
R=rsc
CC=golang-dev
http://codereview.appspot.com/196077
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/194129
|
|
Fixes issue 219.
R=ken2, r
CC=golang-dev
http://codereview.appspot.com/194097
|
|
* example-based syntax errors (go.errors)
* enable bison's more specific errors
and translate grammar token names into
tokens like ++
* test cases
R=ken2, r, ken3
CC=golang-dev
http://codereview.appspot.com/194085
|
|
also allow func() func().
R=ken2
CC=golang-dev
http://codereview.appspot.com/194078
|
|
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/193101
|
|
bonus: type switch now detects multiple uses of identical interface types.
bonus: interface types are now order-independent, following the spec.
R=ken2
CC=golang-dev
http://codereview.appspot.com/194053
|
|
(package main; others are pulled in automatically)
R=ken2
CC=golang-dev
http://codereview.appspot.com/194069
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/194051
|
|
Since gcco runs goroutines in independent threads, it needs
locking for the global variables. This shows up when I use
ordinary increments rather than locked increments for var++.
R=ken2, ken3
CC=golang-dev
http://codereview.appspot.com/190074
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/186232
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/186216
|
|
Fixes issue 529.
R=ken2
CC=golang-dev
http://codereview.appspot.com/186215
|
|
Fixes issue 402.
R=ken2
CC=golang-dev
http://codereview.appspot.com/186214
|
|
Fixes issue 481.
R=ken2
CC=golang-dev
http://codereview.appspot.com/186213
|
|
gccgo currently passes this test; 8g currently does not. I
think I counted everything out right.
R=rsc
CC=golang-dev
http://codereview.appspot.com/186165
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/189088
|
|
Fixes issue 471.
R=ken2
CC=golang-dev
http://codereview.appspot.com/181184
|
|
Fixes issue 475.
R=ken2
CC=golang-dev
http://codereview.appspot.com/183157
|
|
Fixes issue 495.
R=ken2
CC=golang-dev
http://codereview.appspot.com/183156
|
|
some significant improvements:
reverse-complement
nbody (gccgo only)
regex-dna
pidigits
one mysterious drop:
binary-tree.go (gccgo only)
R=rsc
CC=golang-dev
http://codereview.appspot.com/181158
|
|
R=iant
CC=golang-dev
http://codereview.appspot.com/183087
|
|
R=iant
CC=golang-dev
http://codereview.appspot.com/183084
|
|
gccgo currently miscompiles this test.
R=rsc
CC=golang-dev
http://codereview.appspot.com/181050
|
|
gccgo currently fails this test.
R=rsc
CC=golang-dev
http://codereview.appspot.com/179108
|
|
R=ken2
http://codereview.appspot.com/180092
|
|
(Thanks to ken and rsc for pointing this out)
rsc:
ken pointed out that there's a race in the new
one-lock-per-channel code. the issue is that
if one goroutine has gone to sleep doing
select {
case <-c1:
case <-c2:
}
and then two more goroutines try to send
on c1 and c2 simultaneously, the way that
the code makes sure only one wins is the
selgen field manipulation in dequeue:
// if sgp is stale, ignore it
if(sgp->selgen != sgp->g->selgen) {
//prints("INVALID PSEUDOG POINTER\n");
freesg(c, sgp);
goto loop;
}
// invalidate any others
sgp->g->selgen++;
but because the global lock is gone both
goroutines will be fiddling with sgp->g->selgen
at the same time.
This results in a 7% slowdown in the single threaded case for a
ping-pong microbenchmark.
Since the cas predominantly succeeds, adding a simple check first
didn't make any difference.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180068
|
|
R=ken2
CC=dho
http://codereview.appspot.com/179097
|
|
Fixes issue 401.
R=ken2
http://codereview.appspot.com/180053
|
|
Fixes issue 403.
R=ken2
http://codereview.appspot.com/180052
|
|
* better error for lookup of unexported field
* do not assign "ideal string" type to typed string literal
* do not confuse methods and fields during interface check
Fixes issue 410.
Fixes issue 411.
Fixes issue 426.
R=ken2
http://codereview.appspot.com/179069
|
|
R=ken2
http://codereview.appspot.com/179070
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
5th and last set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180050
|
|
Fixes issue 423.
R=ken2
http://codereview.appspot.com/180045
|
|
Fixes issue 384.
R=ken2
http://codereview.appspot.com/179061
|
|
Pull the struct into a single line, since 6g reports the error
on the last line of the struct definition and gccgo reports it
on the first line.
6g:
bug215.go:12: invalid recursive type A
gccgo:
bug215.go:12:6: error: invalid recursive type ‘A’
R=rsc
http://codereview.appspot.com/180044
|
|
This change removes the necessity to have GOBIN in $PATH,
and also doesn't assume that the build is being run from
$GOROOT/src. This is a minimal set of necessary changes
to get Go to build happily from the FreeBSD ports
collection.
R=rsc
CC=golang-dev
http://codereview.appspot.com/171044
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc, ken2
http://codereview.appspot.com/174047
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/173044
|
|
R=rsc, ken2, ken3
http://codereview.appspot.com/174042
|
|
R=rsc
http://codereview.appspot.com/173045
|
|
R=rsc, r
http://codereview.appspot.com/172045
|
|
R=rsc, r
http://codereview.appspot.com/171051
|