Age | Commit message (Collapse) | Author | Files | Lines |
|
some significant improvements:
reverse-complement
nbody (gccgo only)
regex-dna
pidigits
one mysterious drop:
binary-tree.go (gccgo only)
R=rsc
CC=golang-dev
http://codereview.appspot.com/181158
|
|
R=iant
CC=golang-dev
http://codereview.appspot.com/183087
|
|
R=iant
CC=golang-dev
http://codereview.appspot.com/183084
|
|
gccgo currently miscompiles this test.
R=rsc
CC=golang-dev
http://codereview.appspot.com/181050
|
|
gccgo currently fails this test.
R=rsc
CC=golang-dev
http://codereview.appspot.com/179108
|
|
R=ken2
http://codereview.appspot.com/180092
|
|
(Thanks to ken and rsc for pointing this out)
rsc:
ken pointed out that there's a race in the new
one-lock-per-channel code. the issue is that
if one goroutine has gone to sleep doing
select {
case <-c1:
case <-c2:
}
and then two more goroutines try to send
on c1 and c2 simultaneously, the way that
the code makes sure only one wins is the
selgen field manipulation in dequeue:
// if sgp is stale, ignore it
if(sgp->selgen != sgp->g->selgen) {
//prints("INVALID PSEUDOG POINTER\n");
freesg(c, sgp);
goto loop;
}
// invalidate any others
sgp->g->selgen++;
but because the global lock is gone both
goroutines will be fiddling with sgp->g->selgen
at the same time.
This results in a 7% slowdown in the single threaded case for a
ping-pong microbenchmark.
Since the cas predominantly succeeds, adding a simple check first
didn't make any difference.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180068
|
|
R=ken2
CC=dho
http://codereview.appspot.com/179097
|
|
Fixes issue 401.
R=ken2
http://codereview.appspot.com/180053
|
|
Fixes issue 403.
R=ken2
http://codereview.appspot.com/180052
|
|
* better error for lookup of unexported field
* do not assign "ideal string" type to typed string literal
* do not confuse methods and fields during interface check
Fixes issue 410.
Fixes issue 411.
Fixes issue 426.
R=ken2
http://codereview.appspot.com/179069
|
|
R=ken2
http://codereview.appspot.com/179070
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
5th and last set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180050
|
|
Fixes issue 423.
R=ken2
http://codereview.appspot.com/180045
|
|
Fixes issue 384.
R=ken2
http://codereview.appspot.com/179061
|
|
Pull the struct into a single line, since 6g reports the error
on the last line of the struct definition and gccgo reports it
on the first line.
6g:
bug215.go:12: invalid recursive type A
gccgo:
bug215.go:12:6: error: invalid recursive type ‘A’
R=rsc
http://codereview.appspot.com/180044
|
|
This change removes the necessity to have GOBIN in $PATH,
and also doesn't assume that the build is being run from
$GOROOT/src. This is a minimal set of necessary changes
to get Go to build happily from the FreeBSD ports
collection.
R=rsc
CC=golang-dev
http://codereview.appspot.com/171044
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc, ken2
http://codereview.appspot.com/174047
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/173044
|
|
R=rsc, ken2, ken3
http://codereview.appspot.com/174042
|
|
R=rsc
http://codereview.appspot.com/173045
|
|
R=rsc, r
http://codereview.appspot.com/172045
|
|
R=rsc, r
http://codereview.appspot.com/171051
|
|
- remove use of implicit string concatenation
- these appear to be the only files correctly compiling under test
that used implicit string concatenation
R=rsc
http://codereview.appspot.com/172043
|
|
R=r
http://codereview.appspot.com/165083
Committer: Russ Cox <rsc@golang.org>
|
|
shootout.alioth.debian.org .
it's now there: http://shootout.alioth.debian.org/u32q/benchmark.php?test=chameneosredux&lang=all&box=1!
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/167043
Committer: Russ Cox <rsc@golang.org>
|
|
1.9s gcc reverse-complement.c
reverse-complement.go
4.5s / 3.5s original, with/without bounds checks
3.5s / 3.3s bounds check reduction
3.3s / 2.8s smarter garbage collector
2.6s / 2.3s assembler bytes.IndexByte
2.5s / 2.1s even smarter garbage collector
2.3s / 2.1s fix optimizer unnecessary spill bug
2.0s / 1.9s change loop to range (this CL)
R=r
http://codereview.appspot.com/166072
|
|
R=r
http://codereview.appspot.com/165065
|
|
add README explaining how to try the
web demos.
Fixes issue 339.
R=r
CC=barry.d.silverman, bss, vadim
http://codereview.appspot.com/165057
|
|
R=ken2
http://codereview.appspot.com/165055
|
|
Fixes issue 238.
R=ken2
http://codereview.appspot.com/163098
|
|
Fixes issue 245.
R=ken2
http://codereview.appspot.com/164094
|
|
Fixes bug 292.
R=ken2
http://codereview.appspot.com/164093
|
|
Fixes issue 364.
R=ken2
http://codereview.appspot.com/164092
|
|
Fixes issue 370.
R=ken2
http://codereview.appspot.com/163097
|
|
this breaks the dependency of package io on package bytes.
R=rsc
CC=golang-dev
http://codereview.appspot.com/163085
|
|
unnamed, not require -n, in line with other
entries.
R=rsc
CC=r
http://codereview.appspot.com/162061
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/164047
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 288.
R=ken2
http://codereview.appspot.com/157162
|
|
R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/160054
|
|
- removed New(len int) in favor of new(Vector).Resize(len, cap)
- removed Init(len int) in favor of Resize(len, cap)
- runs all.bash
Fixes issue 294.
R=rsc, r, r1
http://codereview.appspot.com/157143
|
|
based on suggestion from arvindht@gmail.com
R=r, rsc, r1
http://codereview.appspot.com/157091
Committer: Russ Cox <rsc@golang.org>
|
|
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes issue 115.
R=rsc, dsymonds1
http://codereview.appspot.com/157067
Committer: Russ Cox <rsc@golang.org>
|
|
except chameneosredux which i know is being edited
require gofmt for test/bench
R=r
http://codereview.appspot.com/157110
|
|
R=ken2
http://codereview.appspot.com/157114
|
|
* add runtime sliceslice1 for x[lo:]
* remove runtime arraytoslice, rewriting &arr into arr[0:len(arr)].
* port cgen_inline into 8g, 5g.
* use native memmove in maps
R=ken2
http://codereview.appspot.com/157106
|
|
* reverse-complement: port C algorithm to Go
saves 30% on my MacBook Pro and makes it a fairer comparison.
* test reverse-complement with and without GC (another 15%)
* revise timing.sh to work on more systems
* avoid two glibcisms in fasta.c
R=r
http://codereview.appspot.com/156110
|
|
R=r, rsc
http://codereview.appspot.com/157085
|
|
- actually test the results
R=rsc, ken2
CC=golang-dev
http://codereview.appspot.com/156094
|
|
R=rsc, ken2
CC=golang-dev
http://codereview.appspot.com/156084
|