Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
R=iant
CC=golang-dev
http://codereview.appspot.com/1666048
|
|
Fixes issue 868.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1695049
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1720043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1664043
|
|
gob: substitute slice for map
R=r
CC=golang-dev
http://codereview.appspot.com/1699045
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1736042
|
|
TBR=r
CC=golang-dev
http://codereview.appspot.com/1734042
|
|
x.go:13: cannot use t (type T) as type Reader in assignment:
T does not implement Reader (Read method requires pointer receiver)
x.go:19: cannot use q (type Q) as type Reader in assignment:
Q does not implement Reader (missing Read method)
have read()
want Read()
x.go:22: cannot use z (type int) as type Reader in assignment:
int does not implement Reader (missing Read method)
x.go:24: too many arguments to conversion to complex: complex(1, 3)
R=ken2
CC=golang-dev
http://codereview.appspot.com/1736041
|
|
R=rsc
CC=golang-dev, r
http://codereview.appspot.com/1706043
Committer: Russ Cox <rsc@golang.org>
|
|
R=iant, ken2, r, r2, ken3
CC=golang-dev
http://codereview.appspot.com/1686044
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1703041
|
|
This shortens, simplifies and regularizes the code significantly.
(Improvements to reflect could make another step.)
Passes all.bash.
One semantic change occurs: The String() method changes
behavior. It used to run only for string formats such as %s and %q.
Instead, it now runs whenever the item has the method and the
result is then processed by the format as a string. Besides the
regularization, this has three effects:
1) width is honored for String() items
2) %x works for String() items
3) implementations of String that merely recur will recur forever
Regarding point 3, example from the updated documentation:
type X int
func (x X) String() string { return Sprintf("%d", x) }
should cast the value before recurring:
func (x X) String() string { return Sprintf("%d", int(x)) }
R=rsc
CC=golang-dev
http://codereview.appspot.com/1613045
|
|
It fails with 6g. Once 6g is fixed up I will extend the value tests.
R=rsc, iant
CC=golang-dev
http://codereview.appspot.com/1677043
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1662041
|
|
Cleans up a few other corner cases too.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1592045
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1615042
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1644042
|
|
* disallow surrogate pair runes.
* diagnose impossible type assertions
* eliminate another static buffer.
* do not overflow lexbuf.
* add -u flag to disable package unsafe.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1619042
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1631041
|
|
* Code for assignment, conversions now mirrors spec.
* Changed some snprint -> smprint.
* Renamed runtime functions to separate
interface conversions from type assertions:
convT2I, assertI2T, etc.
* Correct checking of \U sequences.
Fixes issue 840.
Fixes issue 830.
Fixes issue 778.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1303042
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1620042
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1616041
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/1612041
|
|
*T2 implements I2, but T2 does not.
R=gri
CC=golang-dev
http://codereview.appspot.com/1613041
|
|
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/972046
Committer: Rob Pike <r@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/1473042
|
|
R=r, iant
CC=golang-dev
http://codereview.appspot.com/1433042
|
|
R=rsc, r, iant
CC=golang-dev
http://codereview.appspot.com/1465041
|
|
Fixes issue 806.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1281042
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1284041
|
|
Fixes issue 771.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1267042
|
|
Fixes issue 807.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1283041
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1274042
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1220046
|
|
Fixes issue 808.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1273042
|
|
Fixes issue 804.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1224045
|
|
R=ken2
CC=golang-dev
http://codereview.appspot.com/1280041
|
|
- accepted by gccgo, gofmt
- some not accepted by 6g
- spec revision forthcoming
R=rsc
CC=golang-dev
http://codereview.appspot.com/1279041
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1231044
Committer: Robert Griesemer <gri@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1242045
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/1211047
|
|
tweaks & tests of last bug fix too.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1207044
|