From 5f7e4a0eb973f35c08e363768fbce93aebcbb174 Mon Sep 17 00:00:00 2001
From: Russ Cox <rsc@golang.org>
Date: Sat, 7 Nov 2009 18:56:29 -0800
Subject: fix authentication in parallel LoadAllCL

R=r
http://go/go-review/1024018
---
 lib/codereview/codereview.py | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

(limited to 'lib/codereview')

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 06423963b..f5ebc595e 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -372,14 +372,21 @@ def LoadAllCL(ui, repo, web=True):
 	files = [f for f in os.listdir(dir) if f.startswith('cl.')]
 	if not files:
 		return m
-	if web:
-		# Authenticate now, so we can use threads below
-		MySend(None)
 	active = []
+	first = True
 	for f in files:
 		t = LoadCLThread(ui, repo, dir, f, web)
 		t.start()
-		active.append(t)
+		if web and first:
+			# first request: wait in case it needs to authenticate
+			# otherwise we get lots of user/password prompts
+			# running in parallel.
+			t.join()
+			if t.cl:
+				m[t.cl.name] = t.cl
+			first = False
+		else:
+			active.append(t)
 	for t in active:
 		t.join()
 		if t.cl:
-- 
cgit v1.2.3