From 202db70ccb3160957945a82c1e3c174a57e888db Mon Sep 17 00:00:00 2001 From: Rob Pike Date: Tue, 16 Dec 2008 13:01:39 -0800 Subject: If ByteBuffer has never been used, b.buf is nil but Data() should still work. Fix the bug using a (safe) shared global empty array. R=rsc DELTA=8 (8 added, 0 deleted, 0 changed) OCL=21303 CL=21303 --- src/lib/io/bytebuffer.go | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'src/lib/io/bytebuffer.go') diff --git a/src/lib/io/bytebuffer.go b/src/lib/io/bytebuffer.go index 903536717..8af8a09aa 100644 --- a/src/lib/io/bytebuffer.go +++ b/src/lib/io/bytebuffer.go @@ -75,7 +75,15 @@ func (b *ByteBuffer) Len() int { return b.len } +// If the buffer is empty, Data() should still give a valid array. +// Use this variable as a surrogate. It's immutable (can't be +// grown, can't store any data) so it's safe to share. +var EmptyByteArray = new([]byte, 0) + func (b *ByteBuffer) Data() *[]byte { + if b.buf == nil { + return EmptyByteArray + } return b.buf[b.off:b.len] } -- cgit v1.2.3