From dabb97986841f70cd9d71444060b677d98e6f302 Mon Sep 17 00:00:00 2001 From: Robert Griesemer Date: Thu, 30 Jul 2009 19:39:47 -0700 Subject: - don't call String method of AST nodes when converting them to text - make token.Position.String more robust TBR=rsc DELTA=20 (10 added, 6 deleted, 4 changed) OCL=32564 CL=32564 --- src/pkg/go/token/token.go | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) (limited to 'src/pkg/go') diff --git a/src/pkg/go/token/token.go b/src/pkg/go/token/token.go index 61a0c622c..32958b53f 100644 --- a/src/pkg/go/token/token.go +++ b/src/pkg/go/token/token.go @@ -353,15 +353,17 @@ func (pos *Position) IsValid() bool { func (pos *Position) String() string { - s := pos.Filename; - if pos.IsValid() { + if pos != nil { + s := pos.Filename; + if pos.IsValid() { + if s != "" { + s += ":"; + } + s += fmt.Sprintf("%d:%d", pos.Line, pos.Column); + } if s != "" { - s += ":"; + return s; } - s += fmt.Sprintf("%d:%d", pos.Line, pos.Column); - } - if s != "" { - return s; } return ""; } -- cgit v1.2.3