From 19e8c2aaedcc47ca3e3aaed7b75553d1538efb6c Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Mon, 14 Jun 2010 18:07:17 -0700 Subject: runtime: correct fault for 16-bit divide on Leopard R=r CC=golang-dev http://codereview.appspot.com/1703041 --- test/golden.out | 4 ---- test/zerodivide.go | 12 ++++-------- 2 files changed, 4 insertions(+), 12 deletions(-) (limited to 'test') diff --git a/test/golden.out b/test/golden.out index d6d9d576a..24e24a28e 100644 --- a/test/golden.out +++ b/test/golden.out @@ -54,10 +54,6 @@ FAIL Hello World! =========== ./zerodivide.go -int16 0/0: expected "divide"; got "runtime error: floating point error" -int16 1/0: expected "divide"; got "runtime error: floating point error" -uint16 0/0: expected "divide"; got "runtime error: floating point error" -uint16 1/0: expected "divide"; got "runtime error: floating point error" complex 0/0: expected no error; got "runtime error: complex divide by zero" complex64 0/0: expected no error; got "runtime error: complex divide by zero" complex128 0/0: expected no error; got "runtime error: complex divide by zero" diff --git a/test/zerodivide.go b/test/zerodivide.go index 38a040ade..948aedd93 100644 --- a/test/zerodivide.go +++ b/test/zerodivide.go @@ -56,30 +56,26 @@ func use(v interface{}) { var errorTests = []ErrorTest{ // All integer divide by zero should error. ErrorTest{ "int 0/0", func() { use(i/j) }, "divide", }, -// TODO commented out: fails in 8g. -// ErrorTest{ "int8 0/0", func() { use(i8/j8) }, "divide", }, + ErrorTest{ "int8 0/0", func() { use(i8/j8) }, "divide", }, ErrorTest{ "int16 0/0", func() { use(i16/j16) }, "divide", }, ErrorTest{ "int32 0/0", func() { use(i32/j32) }, "divide", }, ErrorTest{ "int64 0/0", func() { use(i64/j64) }, "divide", }, ErrorTest{ "int 1/0", func() { use(k/j) }, "divide", }, -// TODO commented out: fails in 8g. -// ErrorTest{ "int8 1/0", func() { use(k8/j8) }, "divide", }, + ErrorTest{ "int8 1/0", func() { use(k8/j8) }, "divide", }, ErrorTest{ "int16 1/0", func() { use(k16/j16) }, "divide", }, ErrorTest{ "int32 1/0", func() { use(k32/j32) }, "divide", }, ErrorTest{ "int64 1/0", func() { use(k64/j64) }, "divide", }, ErrorTest{ "uint 0/0", func() { use(u/v) }, "divide", }, -// TODO commented out: fails in 8g. -// ErrorTest{ "uint8 0/0", func() { use(u8/v8) }, "divide", }, + ErrorTest{ "uint8 0/0", func() { use(u8/v8) }, "divide", }, ErrorTest{ "uint16 0/0", func() { use(u16/v16) }, "divide", }, ErrorTest{ "uint32 0/0", func() { use(u32/v32) }, "divide", }, ErrorTest{ "uint64 0/0", func() { use(u64/v64) }, "divide", }, ErrorTest{ "uintptr 0/0", func() { use(up/vp) }, "divide", }, ErrorTest{ "uint 1/0", func() { use(w/v) }, "divide", }, -// TODO commented out: fails in 8g. -// ErrorTest{ "uint8 1/0", func() { use(w8/v8) }, "divide", }, + ErrorTest{ "uint8 1/0", func() { use(w8/v8) }, "divide", }, ErrorTest{ "uint16 1/0", func() { use(w16/v16) }, "divide", }, ErrorTest{ "uint32 1/0", func() { use(w32/v32) }, "divide", }, ErrorTest{ "uint64 1/0", func() { use(w64/v64) }, "divide", }, -- cgit v1.2.3