<feed xmlns='http://www.w3.org/2005/Atom'>
<title>puppet/spec/unit/util/rdoc, branch master</title>
<subtitle>[no description]</subtitle>
<id>https://git.osdyson.ru/pkg-puppet/puppet/atom?h=master</id>
<link rel='self' href='https://git.osdyson.ru/pkg-puppet/puppet/atom?h=master'/>
<link rel='alternate' type='text/html' href='https://git.osdyson.ru/pkg-puppet/puppet/'/>
<updated>2014-05-13T00:28:38Z</updated>
<entry>
<title>(PUP-2214) Fix spec failures under 1.8.7</title>
<updated>2014-05-13T00:28:38Z</updated>
<author>
<name>Josh Partlow</name>
<email>joshua.partlow@puppetlabs.com</email>
</author>
<published>2014-05-12T23:53:30Z</published>
<link rel='alternate' type='text/html' href='https://git.osdyson.ru/pkg-puppet/puppet/commit/?id=97d722381ec4a62ae8dcdff536cd014092b99957'/>
<id>urn:sha1:97d722381ec4a62ae8dcdff536cd014092b99957</id>
<content type='text'>
Fixes some rdoc1 spec issues by providing explicit envs in the specs.
</content>
</entry>
<entry>
<title>(PUP-1699) Use Puppet.override to provide some spec envs</title>
<updated>2014-04-28T21:04:58Z</updated>
<author>
<name>Josh Partlow</name>
<email>joshua.partlow@puppetlabs.com</email>
</author>
<published>2014-04-23T01:27:48Z</published>
<link rel='alternate' type='text/html' href='https://git.osdyson.ru/pkg-puppet/puppet/commit/?id=779f012ad6dfca2de252cf2edc50668c7409e67b'/>
<id>urn:sha1:779f012ad6dfca2de252cf2edc50668c7409e67b</id>
<content type='text'>
A few specs relying on mocking Puppet::Node::Environment.new to return
a specific test environment were colliding with the new environments
cacheing layer.  Switched to using puppet override to supply a static
environment.
</content>
</entry>
<entry>
<title>(PUP-2158) Default a missing manifest to no_manifest</title>
<updated>2014-04-07T15:01:38Z</updated>
<author>
<name>Andrew Parker</name>
<email>andy@puppetlabs.com</email>
</author>
<published>2014-04-07T15:01:38Z</published>
<link rel='alternate' type='text/html' href='https://git.osdyson.ru/pkg-puppet/puppet/commit/?id=f6637b0a3dba8bed9cd039ff22e644ea38040a84'/>
<id>urn:sha1:f6637b0a3dba8bed9cd039ff22e644ea38040a84</id>
<content type='text'>
The tests were often creating environments that didn't need to have
manifests. Since we didn't have a way of specifying that when they
were written, we used '' to fill in the blank. This actually caused a
large number of tests to try to find code to load in the PWD, which
caused tests to break if a developer had parse errors in manifests being
used for testing in the root directory of their puppet project. This
changes the manifest to be optional and removes '' from those tests. The
tests no longer fail if a bad manifest is in the PWD :D
</content>
</entry>
<entry>
<title>(PUP-1118) Fix rdoc1 specs to match changes to rdoc puppet_parser_core</title>
<updated>2014-01-29T18:52:10Z</updated>
<author>
<name>Josh Partlow</name>
<email>joshua.partlow@puppetlabs.com</email>
</author>
<published>2014-01-29T18:52:10Z</published>
<link rel='alternate' type='text/html' href='https://git.osdyson.ru/pkg-puppet/puppet/commit/?id=f381f2c758c770e6e3e8ec4e3cb2b6ed3670f423'/>
<id>urn:sha1:f381f2c758c770e6e3e8ec4e3cb2b6ed3670f423</id>
<content type='text'>
PuppetParserCore was updated to pass environment, known_resource_types;
this just catches up the spec, which runs only on 1.8.7, to match the
changes.
</content>
</entry>
<entry>
<title>(PUP-761) Make most FileSystem API change related test pass</title>
<updated>2014-01-06T18:06:06Z</updated>
<author>
<name>Henrik Lindberg</name>
<email>henrik.lindberg@cloudsmith.com</email>
</author>
<published>2014-01-05T21:41:14Z</published>
<link rel='alternate' type='text/html' href='https://git.osdyson.ru/pkg-puppet/puppet/commit/?id=e15cae88317b770a95afd626e01e666106ff35ee'/>
<id>urn:sha1:e15cae88317b770a95afd626e01e666106ff35ee</id>
<content type='text'>
</content>
</entry>
<entry>
<title>(PUP-1133) Windows tests write config to temp</title>
<updated>2013-12-20T14:30:57Z</updated>
<author>
<name>Ethan J. Brown</name>
<email>Iristyle@github</email>
</author>
<published>2013-12-19T18:03:08Z</published>
<link rel='alternate' type='text/html' href='https://git.osdyson.ru/pkg-puppet/puppet/commit/?id=ba09bfe99d9ac8679b74259e55c7b31947d05d1b'/>
<id>urn:sha1:ba09bfe99d9ac8679b74259e55c7b31947d05d1b</id>
<content type='text'>
 - Previously tests were writing to the shared
   %ALLUSERSPROFILE%\PuppetLabs\puppet directory, and would blow
   up if this directory did not exist
 - Because this directory was shared from one run to the next, failing
   tests could be masked by data generated / used by a locally installed
   Puppet
 - The stubbing of FileSystem::File.exist? to return true was causing
   some tests to treat files like c:\dev\null\foo to attempt to be
   loaded, which would cause these tests to fail in isolation, but not
   when run within the suite
 - Had to change some doc specs under Ruby 1.9 / OSX to verify a value
   instead of asserting a method was called, to prevent a stack overflow
 - In some unit tests, the process of reading / writing settings caused
   issues with test loading, so Puppet.settings.use has been stubbed
</content>
</entry>
<entry>
<title>(#19447) Puppet::FileSystem::File#stat / lstat</title>
<updated>2013-11-08T23:51:39Z</updated>
<author>
<name>Ethan J. Brown</name>
<email>Iristyle@github</email>
</author>
<published>2013-10-31T13:38:26Z</published>
<link rel='alternate' type='text/html' href='https://git.osdyson.ru/pkg-puppet/puppet/commit/?id=4bd6f875a02ddfbf50c1b20aea9d7ab46a76695b'/>
<id>urn:sha1:4bd6f875a02ddfbf50c1b20aea9d7ab46a76695b</id>
<content type='text'>
 - All calls to File class stat / lstat go through the new
   FileSystem::File abstraction so that the implementation can later
   be swapped for a Windows specific one to support symlinks
</content>
</entry>
<entry>
<title>(#22180) Recapture class comments under Ruby 2.0 RDoc</title>
<updated>2013-10-25T21:21:23Z</updated>
<author>
<name>Josh Partlow</name>
<email>joshua.partlow@puppetlabs.com</email>
</author>
<published>2013-10-25T21:21:23Z</published>
<link rel='alternate' type='text/html' href='https://git.osdyson.ru/pkg-puppet/puppet/commit/?id=cedd593ddcdac7735ae4af9ac6e022ce4d388a28'/>
<id>urn:sha1:cedd593ddcdac7735ae4af9ac6e022ce4d388a28</id>
<content type='text'>
RDoc 2+ has an RDoc::ClassModule.add_comment(comment,location) method
which is the preferred method of setting comments for a class.  RDoc
shipping with Ruby 1.9 seems to fall back to using the @comment, which
is how rdoc1 handled this, but Ruby 2.0's rdoc seems to be stricter and
requires use of add_comment.

This patch overrides the add_comment method in our PuppetModule,
PuppetClass, PuppetNode code objects with a version compatible with
either rdoc1 or 2.  It also tests for module level README comments being
incorporated.
</content>
</entry>
<entry>
<title>(#22180) Fix broken rdoc1 features</title>
<updated>2013-10-25T00:18:44Z</updated>
<author>
<name>Josh Partlow</name>
<email>joshua.partlow@puppetlabs.com</email>
</author>
<published>2013-10-25T00:18:44Z</published>
<link rel='alternate' type='text/html' href='https://git.osdyson.ru/pkg-puppet/puppet/commit/?id=7f59b3a383dbc97eb81101b91b77e5c9a1f9675c'/>
<id>urn:sha1:7f59b3a383dbc97eb81101b91b77e5c9a1f9675c</id>
<content type='text'>
There were a number of rdoc1 features (tracking of included, required
modules, realized virtual resources, all resources when :document_all
setting is true, and global variables) which had not been functioning
due to the parser wrapping statements in
Puppet::Parser::AST::BlockExpression instances now rather than
Puppet::Parser::AST::Array instances.

This is now fixed so that these areas are documented when using rdoc1.
Only included classes is documented in rdoc2, however.  Documenting the
remaining elements would require writing a new renderer.
</content>
</entry>
<entry>
<title>(#20302) Handle nested include filters</title>
<updated>2013-05-29T18:17:18Z</updated>
<author>
<name>Josh Cooper</name>
<email>josh@puppetlabs.com</email>
</author>
<published>2013-05-29T03:44:41Z</published>
<link rel='alternate' type='text/html' href='https://git.osdyson.ru/pkg-puppet/puppet/commit/?id=650392545c6c3a3c963076343b27690aea9e426a'/>
<id>urn:sha1:650392545c6c3a3c963076343b27690aea9e426a</id>
<content type='text'>
Nested rspec include filters don't work the way I expect. Given:

  describe "A", :if =&gt; rdoc1? do
    before :all do
      require 'rdoc/tokenstream'
    end

    describe "B", :if =&gt; windows? do
    end
  end

If rdoc1? is false, but windows? is true, the before :all/:each blocks
will still be executed, and the tests in B will be executed.

As a result, the spec tests fail on Windows and ruby 1.9, because our rdoc
parser is not compatible with newer versions of rdoc. For example,
rdoc/tokenstream.rb was moved to token_stream.rb, etc.

This commit adds the rdoc1? predicate to the example group B, so that
it is not executed when rdoc1? is false.
</content>
</entry>
</feed>
