summaryrefslogtreecommitdiff
path: root/spec/integration/provider/cron/crontab_spec.rb
diff options
context:
space:
mode:
Diffstat (limited to 'spec/integration/provider/cron/crontab_spec.rb')
-rw-r--r--spec/integration/provider/cron/crontab_spec.rb285
1 files changed, 137 insertions, 148 deletions
diff --git a/spec/integration/provider/cron/crontab_spec.rb b/spec/integration/provider/cron/crontab_spec.rb
index a88eb1c76..e75523cac 100644
--- a/spec/integration/provider/cron/crontab_spec.rb
+++ b/spec/integration/provider/cron/crontab_spec.rb
@@ -2,9 +2,11 @@
require 'spec_helper'
require 'puppet/file_bucket/dipper'
+require 'puppet_spec/compiler'
describe Puppet::Type.type(:cron).provider(:crontab), '(integration)', :unless => Puppet.features.microsoft_windows? do
include PuppetSpec::Files
+ include PuppetSpec::Compiler
before :each do
Puppet::Type.type(:cron).stubs(:defaultprovider).returns described_class
@@ -33,20 +35,6 @@ describe Puppet::Type.type(:cron).provider(:crontab), '(integration)', :unless =
tmpfile('cron_integration_specs')
end
- def run_in_catalog(*resources)
- catalog = Puppet::Resource::Catalog.new
- catalog.host_config = false
- resources.each do |resource|
- resource.expects(:err).never
- catalog.add_resource(resource)
- end
-
- # the resources are not properly contained and generated resources
- # will end up with dangling edges without this stubbing:
- catalog.stubs(:container_of).returns resources[0]
- catalog.apply
- end
-
def expect_output(fixture_name)
File.read(crontab_user1).should == File.read(my_fixture(fixture_name))
end
@@ -54,56 +42,53 @@ describe Puppet::Type.type(:cron).provider(:crontab), '(integration)', :unless =
describe "when managing a cron entry" do
it "should be able to purge unmanaged entries" do
- resource = Puppet::Type.type(:cron).new(
- :name => 'only managed entry',
- :ensure => :present,
- :command => '/bin/true',
- :target => crontab_user1,
- :user => crontab_user1
- )
- resources = Puppet::Type.type(:resources).new(
- :name => 'cron',
- :purge => 'true'
- )
- run_in_catalog(resource, resources)
+ apply_with_error_check(<<-MANIFEST)
+ cron {
+ 'only managed entry':
+ ensure => 'present',
+ command => '/bin/true',
+ target => '#{crontab_user1}',
+ }
+ resources { 'cron': purge => 'true' }
+ MANIFEST
expect_output('purged')
end
describe "with ensure absent" do
it "should do nothing if entry already absent" do
- resource = Puppet::Type.type(:cron).new(
- :name => 'no_such_entry',
- :ensure => :absent,
- :target => crontab_user1,
- :user => crontab_user1
- )
- run_in_catalog(resource)
+ apply_with_error_check(<<-MANIFEST)
+ cron {
+ 'no_such_entry':
+ ensure => 'absent',
+ target => '#{crontab_user1}',
+ }
+ MANIFEST
expect_output('crontab_user1')
end
it "should remove the resource from crontab if present" do
- resource = Puppet::Type.type(:cron).new(
- :name => 'My daily failure',
- :ensure => :absent,
- :target => crontab_user1,
- :user => crontab_user1
- )
- run_in_catalog(resource)
+ apply_with_error_check(<<-MANIFEST)
+ cron {
+ 'My daily failure':
+ ensure => 'absent',
+ target => '#{crontab_user1}',
+ }
+ MANIFEST
expect_output('remove_named_resource')
end
it "should remove a matching cronentry if present" do
- resource = Puppet::Type.type(:cron).new(
- :name => 'no_such_named_resource_in_crontab',
- :ensure => :absent,
- :minute => [ '17-19', '22' ],
- :hour => [ '0-23/2' ],
- :weekday => 'Tue',
- :command => '/bin/unnamed_regular_command',
- :target => crontab_user1,
- :user => crontab_user1
- )
- run_in_catalog(resource)
+ apply_with_error_check(<<-MANIFEST)
+ cron {
+ 'no_such_named_resource_in_crontab':
+ ensure => absent,
+ minute => [ '17-19', '22' ],
+ hour => [ '0-23/2' ],
+ weekday => 'Tue',
+ command => '/bin/unnamed_regular_command',
+ target => '#{crontab_user1}',
+ }
+ MANIFEST
expect_output('remove_unnamed_resource')
end
end
@@ -112,137 +97,141 @@ describe Puppet::Type.type(:cron).provider(:crontab), '(integration)', :unless =
context "and no command specified" do
it "should work if the resource is already present" do
- resource = Puppet::Type.type(:cron).new(
- :name => 'My daily failure',
- :special => 'daily',
- :target => crontab_user1,
- :user => crontab_user1
- )
- run_in_catalog(resource)
+ apply_with_error_check(<<-MANIFEST)
+ cron {
+ 'My daily failure':
+ special => 'daily',
+ target => '#{crontab_user1}',
+ }
+ MANIFEST
expect_output('crontab_user1')
end
it "should fail if the resource needs creating" do
- resource = Puppet::Type.type(:cron).new(
- :name => 'Entirely new resource',
- :special => 'daily',
- :target => crontab_user1,
- :user => crontab_user1
- )
- resource.expects(:err).with(regexp_matches(/no command/))
- run_in_catalog(resource)
+ manifest = <<-MANIFEST
+ cron {
+ 'Entirely new resource':
+ special => 'daily',
+ target => '#{crontab_user1}',
+ }
+ MANIFEST
+ apply_compiled_manifest(manifest) do |res|
+ if res.ref == 'Cron[Entirely new resource]'
+ res.expects(:err).with(regexp_matches(/no command/))
+ else
+ res.expects(:err).never
+ end
+ end
end
end
it "should do nothing if entry already present" do
- resource = Puppet::Type.type(:cron).new(
- :name => 'My daily failure',
- :special => 'daily',
- :command => '/bin/false',
- :target => crontab_user1,
- :user => crontab_user1
- )
- run_in_catalog(resource)
+ apply_with_error_check(<<-MANIFEST)
+ cron {
+ 'My daily failure':
+ special => 'daily',
+ command => '/bin/false',
+ target => '#{crontab_user1}',
+ }
+ MANIFEST
expect_output('crontab_user1')
end
it "should work correctly when managing 'target' but not 'user'" do
- resource = Puppet::Type.type(:cron).new(
- :name => 'My daily failure',
- :special => 'daily',
- :command => '/bin/false',
- :target => crontab_user1
- )
- run_in_catalog(resource)
+ apply_with_error_check(<<-MANIFEST)
+ cron {
+ 'My daily failure':
+ special => 'daily',
+ command => '/bin/false',
+ target => '#{crontab_user1}',
+ }
+ MANIFEST
expect_output('crontab_user1')
end
it "should do nothing if a matching entry already present" do
- resource = Puppet::Type.type(:cron).new(
- :name => 'no_such_named_resource_in_crontab',
- :ensure => :present,
- :minute => [ '17-19', '22' ],
- :hour => [ '0-23/2' ],
- :command => '/bin/unnamed_regular_command',
- :target => crontab_user1,
- :user => crontab_user1
- )
- run_in_catalog(resource)
+ apply_with_error_check(<<-MANIFEST)
+ cron {
+ 'no_such_named_resource_in_crontab':
+ ensure => present,
+ minute => [ '17-19', '22' ],
+ hour => [ '0-23/2' ],
+ command => '/bin/unnamed_regular_command',
+ target => '#{crontab_user1}',
+ }
+ MANIFEST
expect_output('crontab_user1')
end
it "should add a new normal entry if currently absent" do
- resource = Puppet::Type.type(:cron).new(
- :name => 'new entry',
- :ensure => :present,
- :minute => '12',
- :weekday => 'Tue',
- :command => '/bin/new',
- :environment => [
- 'MAILTO=""',
- 'SHELL=/bin/bash'
- ],
- :target => crontab_user1,
- :user => crontab_user1
- )
- run_in_catalog(resource)
+ apply_with_error_check(<<-MANIFEST)
+ cron {
+ 'new entry':
+ ensure => present,
+ minute => '12',
+ weekday => 'Tue',
+ command => '/bin/new',
+ environment => [
+ 'MAILTO=""',
+ 'SHELL=/bin/bash'
+ ],
+ target => '#{crontab_user1}',
+ }
+ MANIFEST
expect_output('create_normal_entry')
end
it "should add a new special entry if currently absent" do
- resource = Puppet::Type.type(:cron).new(
- :name => 'new special entry',
- :ensure => :present,
- :special => 'reboot',
- :command => 'echo "Booted" 1>&2',
- :environment => 'MAILTO=bob@company.com',
- :target => crontab_user1,
- :user => crontab_user1
- )
- run_in_catalog(resource)
+ apply_with_error_check(<<-MANIFEST)
+ cron {
+ 'new special entry':
+ ensure => present,
+ special => 'reboot',
+ command => 'echo "Booted" 1>&2',
+ environment => 'MAILTO=bob@company.com',
+ target => '#{crontab_user1}',
+ }
+ MANIFEST
expect_output('create_special_entry')
end
it "should change existing entry if out of sync" do
- resource = Puppet::Type.type(:cron).new(
- :name => 'Monthly job',
- :ensure => :present,
- :special => 'monthly',
-# :minute => ['22'],
- :command => '/usr/bin/monthly',
- :environment => [],
- :target => crontab_user1,
- :user => crontab_user1
- )
- run_in_catalog(resource)
+ apply_with_error_check(<<-MANIFEST)
+ cron {
+ 'Monthly job':
+ ensure => present,
+ special => 'monthly',
+ #minute => ['22'],
+ command => '/usr/bin/monthly',
+ environment => [],
+ target => '#{crontab_user1}',
+ }
+ MANIFEST
expect_output('modify_entry')
end
it "should change a special schedule to numeric if requested" do
- resource = Puppet::Type.type(:cron).new(
- :name => 'My daily failure',
- :special => 'absent',
- :command => '/bin/false',
- :target => crontab_user1,
- :user => crontab_user1
- )
- run_in_catalog(resource)
+ apply_with_error_check(<<-MANIFEST)
+ cron {
+ 'My daily failure':
+ special => 'absent',
+ command => '/bin/false',
+ target => '#{crontab_user1}',
+ }
+ MANIFEST
expect_output('unspecialized')
end
it "should not try to move an entry from one file to another" do
# force the parsedfile provider to also parse user1's crontab
- random_resource = Puppet::Type.type(:cron).new(
- :name => 'foo',
- :ensure => :absent,
- :target => crontab_user1,
- :user => crontab_user1
- )
- resource = Puppet::Type.type(:cron).new(
- :name => 'My daily failure',
- :special => 'daily',
- :command => "/bin/false",
- :target => crontab_user2,
- :user => crontab_user2
- )
- run_in_catalog(resource)
+ apply_with_error_check(<<-MANIFEST)
+ cron {
+ 'foo':
+ ensure => absent,
+ target => '#{crontab_user1}';
+ 'My daily failure':
+ special => 'daily',
+ command => "/bin/false",
+ target => '#{crontab_user2}',
+ }
+ MANIFEST
File.read(crontab_user1).should == File.read(my_fixture('moved_cronjob_input1'))
File.read(crontab_user2).should == File.read(my_fixture('moved_cronjob_input2'))
end
generated by cgit v1.2.3 (git 2.39.1) at 2025-08-07 03:47:27 +0000