| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
haus/ticket/master/pup-3154-manage-statedir-in-redhat-packaging
(PUP-3154) Create and manage the mode of $statedir on redhat
|
|
We have this problem where it is very difficult to know what exactly is
getting into the Puppet MSI when we build it. Previously, all that
information was stored in the Jenkins job used to build the MSI. This
proved difficult because there is no real way to audit changes made to
Jenkins jobs, why those changes were made, or who made them. This commit
moves that information into the Puppet Repo itself. This will help us
make sure the correct version of each project is getting into the MSI,
and allow us to build the MSI with the current checkout of the Puppet
Repo. However, this means we have to make sure we do not forget to
update the versions of the dependencies getting pulled into the MSI when
a new release happens.
|
|
In debian, we create and manage the $statedir in the postinst of the
puppet-common package. In redhat, $statedir would be created on
service start, and owned by root. This means that other applications,
even those in the puppet group, could not write to this directory. This
commit adds $statedir to the directories created in the redhat package
and sets the user and group ownership to puppet:puppet. This will ensure
a more consistent experience for users of our packages.
|
|
haus/ticket/master/pup-3035-add-var-run-puppet-to-debian-packaging
(PUP-3035) Add /var/run/puppet to debian packaging
|
|
kylog/issue/pup-2349/cleanup-warning-during-pluginsync
(PUP-2349) cleanup warning during pluginsync.
|
|
|
|
There was a typo in the message that referenced a non existing variable.
This was undetected because there was no test to cover this.
When testing the expected behavior, it was found that the validation
was not correct as it allowed parameters to have hexadecimal names, but
not octal names. Now all numeric parameter names are disallowed (they
cannot be used or addressed anyway).
|
|
|
|
This completes the implenentation of the Resource Expression.
* The LHS must now be a QualifiedName (i.e. file, notify), or
a QualifiedReference (i.e. File, Notify), or an access expression
with a left QualifiedReference (i.e. Resource[file]), or literal
'class'
* The result of the LHS must be a CatalogEntry type, and it may not
be detailed to title level.
* The * => syntax can be used to to unfold a hash. It may be used
once per titled resource body. Attribute names must be unique across
the attributes set with name => expr, and those set with * => hash.
|
|
This change was required to be able to see anything relevant regarding
where a problem originated. The fix is to patch the stacktrace
for failed expectencies. While not ideal there is very little that can
be done with Rspec 2 to fix this except reimplementing the support for
produces and fails to be matchers. (Rspec 3 has composable matchers that
may make this simpler).
A ticket has been logged about further improvements to the two support
functions (produces, and fails).
|
|
snippets
In the puppet 4.0 parser, the file resource's mode property will be
required to be a string containing an octal (or symbolic) representation
of mode.
For consistency then, this commit changes all cases where mode was
specified as a Numeric to be a string containing an octal representation
of mode (always prefaced with a 0, again for clarity and consistency).
|
|
The initial commit for this ticket missed the case where
the mode value isn't explicitly specified but rather comes from
source permissions of a file resource, e.g. as happens during
pluginsync.
This change ensures that mode from a source permission is
converted to an octal string if it's a Numeric.
|
|
It's not that it's deprecated, it's that it never worked.
|
|
andersonmills/fix/master/PUP2040-fix_symlink_testing_on_windows
PUP-2040/PE-3113 Remove symlink-ignore tests for symlinkless OSes
|
|
Before this commit, the spec tests checked for symlink-ignore behavior on all
OSes. After this commit, the spec tests only check symlink-ignore
behavior on OSes that have symlinks.
|
|
Now that this function works in a more useful way, we can advertise it a bit
more widely.
|
|
|
|
andersonmills/fix/master/PUP2040-gitignore_symlinks
PUP-2040/PE-3113 Ignore symlinks in module build with pmtignore/gitignore.
|
|
This fixes a problem in the grammar that made it impossible to have
more than one *=> per body.
This commit also adds a check for duplicate entries in the resulting
hash with the final set of parameter to value mapping.
|
|
|
|
Before this commit, pmtignore functionality worked, but only after
checking for symlinks, so it was impossible to ignore symlinks. This
commit allows symlinks to be ignored, too.
|
|
(PUP-2914) Remove remaining rgen dependencies
|
|
Docs: 3.7 deprecations and revisions
|
|
kylog/issue/pup-3129/delete-_timestamp-from-immutable-facts-hash
(PUP-3129) Do not store _timestamp fact in immutable hash
|
|
The _timestamp fact causes problems when turning on immutable facts
because it is an unsupported data type (Time) that should not leak into
the puppet language. (The system halts with an error if you try prior to
this fix.)
|
|
number
Also, link to the puppetlabs/acl module.
|
|
"URL-compliant" was an odd way to put this, so I revised the text to be less ambiguous.
|
|
In 6a94700, the rgen 0.7.0 library was added to the vendor directory in puppet,
and as such is no longer an external dependency. This commit removes the rgen
package as a dependency of the puppet rpm and deb packages, so that it is not
installed in addition to the vendored rgen (or worse even installed at a
conflicting version).
Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
|
|
PUP-2040 Add .pmtignore functionality
|
|
|
|
|
|
Making the vendoring instructions more clear, detailing the PUPPET_README.md
suggestion.
|
|
Adding spec tests to cover build when .pmtignore/.gitignore files are present/absent
|
|
|
|
Prior to this commit there was no way for a module developer to specify files
that they want to ignore when building/packaging their module.
This commit adds the ability to specify files to ignore in a .pmtignore file,
located in the project root and using the same syntax as .gitignore, or if that
is not present, reading the .gitignore file and using that.
This commit also adds pathspec as a vendored gem. (PE-5574)
|
|
(PUP-2745) Skip dependencies with malformed dependencies.
|
|
(PUP-2817) Fix zone properties so that nil is not passed through
|
|
demophoon/deprecation/master/deprecate-instrumentation-system
(PUP-586) Deprecate Instrumentation System
|
|
demophoon/deprecation/master/deprecate-stringify-fact-default
(PUP-406) Deprecate stringify_ facts option
|
|
* upstream/pr/2995:
(doc) Add Puppet Specific Documentation
(PUP-2914) Remove rgen 0.7.0 dependency
(PUP-2914) Add rgen 0.7.0 to vendored libraries
|
|
This commit does some simple refactoring int he puppet-common.postinst
to avoid some unneeded repetition.
|
|
Previously /var/run/puppet was created only during service start on
debian for both puppet and puppetmaster services. However, as it is used
in both of those services, it makes sense to have it owned and created
by one of the puppet packages. puppet-common is a dependency of both the
puppet and puppetmaster packages, so this commit adds /var/run/puppet to
the puppet-common.dirs file so it will be created in that package. This
also brings parity between redhat and debian packages in this respect,
as redhat puppet packages create the /var/run/puppet directory already.
This also adds a dpkg-statoverride call to manage permissions for the
/var/run/puppet directory.
|
|
Seeing sporadic failures on 1.8.7 with these two tests, probably related
to order of parameter keys not being guaranteed. This patch loosens the
regex on these two tests slightly so that it the keys can be in any
order.
With Britt Gresham <britt@puppetlabs.com>
|
|
The instrumentation system is being removed in Puppet 4.0.
This commit is for adding a deprecation message on the subcommands for
users to migrate off of it before it is finally deleted.
|
|
The `stringify_facts` option is going to be removed in Puppet 4.0 and we
need to let users know about deprecated features.
This commit adds in a deprecation message in the stringify_facts
description.
|
|
(PUP-1044) Ensure file bucket streams are closed at all times after use
|
|
Before this patch, when `insync?` was called on the zone properties ip,
dataset and inherit with value nil (happens the first time when the properties
are not present), `true` was returned, which resulted in them not being set
until the values were actually queried, which happened after the installation
of zone. Unfortunately, the inherit property can only be set before
installation.
This patch removes the spurious check for `nil`, which always returned `true`,
and instead handles it similar to when `:absent` is used.
|
|
This makes the stream() method on file bucket file take a block
to ensure that the processing of the stream always ends up closing it.
|
|
(doc) Add documentation for environments api call
|
|
* issue/master/pup-2999-agent-tmpdirs-on-windows:
(PUP-2999) Use host.tmpdir for agent tmpdirs
|
