| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
In the Rakefile, we no longer use Rspec methods or classes, but instead shell
out to rspec, so requiring rspec serves no purpose in the rakefile. The require
was also incorrectly placed within an unrelated begin/rescue block, which
caused deprecated rake libraries to be loaded when rspec was not present. This
commit removes it from the Rakefile.
|
|
The packaging repo now uses an explicit loader which handles loading the
various rake tasks in packaging. This commit updates the puppet Rakefile to use
the loader instead of a blind glob of the ext/packaging/tasks directory. We
move this load into the rescue LoadError block because the packaging repo won't
always be there, and define RAKE_ROOT and use it since its used in more than
one place in the Rakefile.
Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
|
|
Without JUnit style output we don't have a good way of seeing test
failures within jenkins. This adds a new rake task ci:spec that will
run with junit output, descriptive output and spec order logging.
It turns out that some of the tests would call safe_posix_fork which
ended up closing all open file handles. This ended up also closing the
file handle that rspec would hold open for the junit output formatter.
Those tests have been modified to ensure that the file descripters are
not actually closed.
|
|
A shared behavior file located in spec/unit was getting loaded multiple
times if rake spec was invoked. The rspec default behavior loads all
files named *_spec.rb but the rake spec pattern was loading all ruby
files. This commit matches the rake spec behavior to match the rspec
behavior.
|
|
* upstream/2.7.x:
(#17260) Include link to information about deprecation
Update Rakefile to make rspec optional
Remove the asc file from the source of spec file
(#17260) Warn when variables contain hyphens
Edit description of hyphenated variables compatibility setting
(#10146) `-` in variable names should be deprecated!
(#14822) Use feature confine for feature tests during run
(#14822) Re-evaluate features if they previously were false
Conflicts:
ext/build_defaults.yaml
ext/redhat/puppet.spec.erb
lib/puppet/defaults.rb
|
|
Currently rspec is a hard dependency to using the Rakefile for puppet. This
means that users on platforms without native rspec packages can't use the
Rakefile to do other things, like build packages. This commit moves the require
on rspec and rspec/core/rake_task into a begin/rescue block and wraps the call
to Rspec::Core::RakeTask in an `if defined?` conditional so it is only invoked
if Rspec is loaded and available.
|
|
* upstream/2.7.x:
(#16922) Quote strings that contain ":"
fail better in package repo rake tasks
(#16376) Fix rails compatibility layer for activerecord < 3.0
|
|
This commit modifies the top level Rakefile to only
load the packaging repo yaml file if it exists, as
well as provide some error handling for other unwanted
conditions that may arise as a result of trying to
set up the packaging repo.
Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
|
|
Conflicts:
Rakefile
ext/redhat/puppet.spec.erb
lib/puppet/defaults.rb
spec/integration/defaults_spec.rb
tasks/rake/apple.rake
Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
|
|
|
|
* 2.7.x:
(#15464) Exclude gem command from bundler
Revert "Revert "Merge branch 'ticket/2.7.x/15464_a_gemfile_would_improve_contributor_on-boarding' into 2.7.x""
Conflicts:
README_DEVELOPER.md
lib/puppet.rb
tasks/rake/gem.rake
|
|
'ticket/2.7.x/15464_a_gemfile_would_improve_contributor_on-boarding' into 2.7.x""
This reverts commit 76ef99b3ea5baeeaa3482d0b3617a1b799c7028c.
|
|
'ticket/2.7.x/15464_a_gemfile_would_improve_contributor_on-boarding' into 2.7.x"
This reverts commit 8919d749c7f5973ab16c7db2b3a64fd1af8bf6b1, reversing
changes made to 97f742d70603f626dc40000aae72c299603282c6.
|
|
Without this patch applied the version string of Puppet is dynamically
set from the `git describe` tag in the Rakefile using monkey patching.
This is problematic because this causes a constant to be re-defined
which issues a warning in Ruby.
This patch fixes the problem by implementing the Puppet.version= module
method. The Rakefile will now set the Puppet version by using `require
'puppet/version'` and calling `Puppet.version = %x{git describe ...}`
Using a module method also has the benefit of making it easier to
intercept and mock Puppet version specific behavior.
From this point forward, the method Puppet.version should but used to
obtain the version string instead of the constant Puppet::PUPPETVERSION.
|
|
Fixes #15463
|
|
* upstream/3.x:
Fix find_module_root tests so paths are expanded in assertions
Refactor ast_spec to use real values
(Maint) Don't assume paths are absolute
Determine packaging version with git describe
(#14600) Fix cleanup of tempfiles in file_spec
(#14531) Change default ensure value from symlink to link
(#14860) Fix puppet cert exit status on failures
(#14599) Handle ENOTDIR in file type
(#13880) Add openrc spec - service with extreme long name
(#13880) Add openrc service provider for Gentoo and Funtoo
Fixes for #10915 and #11200 - user provider for AIX
(#10354) added delete command to fix missing userdel flag in useradd provider
|
|
* 2.7.x:
(Maint) Don't assume paths are absolute
Determine packaging version with git describe
(#14600) Fix cleanup of tempfiles in file_spec
(#14531) Change default ensure value from symlink to link
(#14860) Fix puppet cert exit status on failures
(#14599) Handle ENOTDIR in file type
(#13880) Add openrc spec - service with extreme long name
(#13880) Add openrc service provider for Gentoo and Funtoo
Fixes for #10915 and #11200 - user provider for AIX
(#10354) added delete command to fix missing userdel flag in useradd provider
Conflicts:
lib/puppet/ssl/certificate_authority/interface.rb
spec/integration/type/file_spec.rb
spec/unit/ssl/certificate_authority/interface_spec.rb
|
|
This commit modifies the rakefile to use git describe
to determine the package version instead of the hard-coded
version in lib/puppet.rb. This takes a couple steps
out of packaging RCs. The specific string manipulation
is borrowed from puppetdb packaging.
Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
|
|
Fixes #15463
|
|
(maint) Make Puppet's gem package task the same name as other Puppetlabs' projects
|
|
|
|
The other test suites, especially acceptance, cover everything that these
tests cover for the a whole bunch of the RAL tests in the older system.
Others were entirely disabled, and can simply be stripped out.
Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
|
|
This reverts commit cd36fce381ab17db99469d6afacc2b8d420abea3, reversing
changes made to 94c5cd31148aef4c7b9cce1aab36bdeb39c5b508.
This was causing problems running rake, since Rubygems would end up
with a version along the lines of '2.7.6-265-gcd36fce', which it did
not like at all.c
|
|
Previously generating tarballs for rc's required a lot of manual
intervention. This fix corrects the versioning scheme so that
everything is handled automatically via the rake task.
|
|
We used to depend on a Unix shell, but with Win32 support this doesn't work so
well. Thankfully, all we really wanted to do was change directory down into
'test', which Ruby can do natively, saving us the platform headache.
|
|
Hudson wasn't notifying us when there was a test failure because
fail_on_error was set to false. This appears to be because of a
misconception that setting this to true caused the specs to run slower.
That is not the case.
Paired-with: Nick Lewis
|
|
Having the Rakefile set RSpec options made it so that the .rspec
(spec.opts in RSpec < 2) file for personal RSpec preferences was
ignored.
It also caused the ci_reporter RSpec options to be ignored which meant
that Hudson couldn't get consumable output from our spec runs.
It's also about time Puppet had a project level .gitignore file so that
if people want personal rspec preferences (color or a different print
format for example) in a .rspec file, those changes don't actually get
checked in.
Paired-with: Jesse Wolfe
|
|
The biggest change is that we no longer need to monkey patch rspec to
get confine behavior. Describe blocks can now be conditional like
confine used to be. "describe" blocks with "shared => true" are now
"shared_examples_for".
Paired-With: Nick Lewis
|
|
Ideally it would be nice if the rake task used personalized RSpec
settings on a per user basis, but until someone figures that out color
would be nice
Signed-off-by: Matt Robinson <matt@puppetlabs.com>
|
|
A typo prevents the Rakefile from finding tests in spec/integration
Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
|
|
|
|
A 'require' statement with a path confused ruby enough to cause the same
file to get interpreted twice.
Signed-off-by: Jesse Wolfe <jes5199@gmail.com>
|
|
- Minor improvements to Rakefile spec task
- Remove puppetmasterd spec, to be run as part of the testing matrix
|
|
|
|
|
|
At some point someone may want to get the coverage tests working, but
the coordinates of that point is are not (now,me). This patch just
comments out the rcov and stops the time consuming trailing stack
trace generation.
Signed-off-by: Markus Roberts <Markus@reality.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
You will need to install the relevance-rcov gem:
gem install relevance-rcov --source http://gems.github.com
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Luke Kanies <luke@madstop.com>
|
|
|
|
edit to Rakefile
|
