summaryrefslogtreecommitdiff
path: root/spec/integration/module_tool_spec.rb
blob: 1067bfab347c4f2cd1decd739deacf731ea8f1bb (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
require 'spec_helper'
require 'tmpdir'
require 'fileutils'

# FIXME This are helper methods that could be used by other tests in the
# future, should we move these to a more central location
def stub_repository_read(code, body)
  kind = Net::HTTPResponse.send(:response_class, code.to_s)
  response = kind.new('1.0', code.to_s, 'HTTP MESSAGE')
  response.stubs(:read_body).returns(body)
  Puppet::Module::Tool::Repository.any_instance.stubs(:read_response).returns(response)
end

def stub_installer_read(body)
  Puppet::Module::Tool::Applications::Installer.any_instance.stubs(:read_match).returns(body)
end

def stub_cache_read(body)
  Puppet::Module::Tool::Cache.any_instance.stubs(:read_retrieve).returns(body)
end

# Return path to temparory directory for testing.
def testdir
  return @testdir ||= tmpdir("module_tool_testdir")
end

# Create a temporary testing directory, change into it, and execute the
# +block+. When the block exists, remove the test directory and change back
# to the previous directory.
def mktestdircd(&block)
  previousdir = Dir.pwd
  rmtestdir
  FileUtils.mkdir_p(testdir)
  Dir.chdir(testdir)
  block.call
ensure
  rmtestdir
  Dir.chdir previousdir
end

# Remove the temporary test directory.
def rmtestdir
  FileUtils.rm_rf(testdir) if File.directory?(testdir)
end
# END helper methods


# Directory that contains sample releases.
RELEASE_FIXTURES_DIR = File.join(PuppetSpec::FIXTURE_DIR, "releases")

# Return the pathname string to the directory containing the release fixture called +name+.
def release_fixture(name)
  return File.join(RELEASE_FIXTURES_DIR, name)
end

# Copy the release fixture called +name+ into the current working directory.
def install_release_fixture(name)
  release_fixture(name)
  FileUtils.cp_r(release_fixture(name), name)
end

describe "module_tool", :fails_on_windows => true do
  include PuppetSpec::Files
  before do
    @tmp_confdir = Puppet[:confdir] = tmpdir("module_tool_test_confdir")
    @tmp_vardir = Puppet[:vardir] = tmpdir("module_tool_test_vardir")
    Puppet[:module_repository] = "http://forge.puppetlabs.com"
    @mytmpdir = Pathname.new(tmpdir("module_tool_test"))
    @options = {}
    @options[:install_dir] = @mytmpdir
    @options[:module_repository] = "http://forge.puppetlabs.com"
  end

  def build_and_install_module
    Puppet::Module::Tool::Applications::Generator.run(@full_module_name)
    Puppet::Module::Tool::Applications::Builder.run(@full_module_name)

    FileUtils.mv("#{@full_module_name}/pkg/#{@release_name}.tar.gz", "#{@release_name}.tar.gz")
    FileUtils.rm_rf(@full_module_name)

    Puppet::Module::Tool::Applications::Installer.run("#{@release_name}.tar.gz", @options)
  end

  # Return STDOUT and STDERR output generated from +block+ as it's run within a temporary test directory.
  def run(&block)
    mktestdircd do
      block.call
    end
  end

  before :all do
    @username = "myuser"
    @module_name  = "mymodule"
    @full_module_name = "#{@username}-#{@module_name}"
    @version = "0.0.1"
    @release_name = "#{@full_module_name}-#{@version}"
  end

  before :each do
    Puppet.settings.stubs(:parse)
    Puppet::Module::Tool::Cache.clean
  end

  after :each do
    Puppet::Module::Tool::Cache.clean
  end

  describe "generate" do
    it "should generate a module if given a dashed name" do
      run do
        Puppet::Module::Tool::Applications::Generator.run(@full_module_name)

        File.directory?(@full_module_name).should == true
        modulefile = File.join(@full_module_name, "Modulefile")
        File.file?(modulefile).should == true
        metadata = Puppet::Module::Tool::Metadata.new
        Puppet::Module::Tool::ModulefileReader.evaluate(metadata, modulefile)
        metadata.full_module_name.should == @full_module_name
        metadata.username.should == @username
        metadata.name.should == @module_name
      end
    end

    it "should fail if given an undashed name" do
      run do
        lambda { Puppet::Module::Tool::Applications::Generator.run("invalid") }.should raise_error(RuntimeError)
      end
    end

    it "should fail if directory already exists" do
      run do
        Puppet::Module::Tool::Applications::Generator.run(@full_module_name)
        lambda { Puppet::Module::Tool::Applications::Generator.run(@full_module_name) }.should raise_error(ArgumentError)
      end
    end

    it "should return an array of Pathname objects representing paths of generated files" do
      run do
        return_value = Puppet::Module::Tool::Applications::Generator.run(@full_module_name)
        return_value.each do |generated_file|
          generated_file.should be_kind_of(Pathname)
        end
        return_value.should be_kind_of(Array)
      end
    end
  end

  describe "build" do
    it "should build a module in a directory" do
      run do
        Puppet::Module::Tool::Applications::Generator.run(@full_module_name)
        Puppet::Module::Tool::Applications::Builder.run(@full_module_name)

        File.directory?(File.join(@full_module_name, "pkg", @release_name)).should == true
        File.file?(File.join(@full_module_name, "pkg", @release_name + ".tar.gz")).should == true
        metadata_file = File.join(@full_module_name, "pkg", @release_name, "metadata.json")
        File.file?(metadata_file).should == true
        metadata = PSON.parse(File.read(metadata_file))
        metadata["name"].should == @full_module_name
        metadata["version"].should == @version
        metadata["checksums"].should be_a_kind_of(Hash)
        metadata["dependencies"].should == []
        metadata["types"].should == []
      end
    end

    it "should build a module's checksums" do
      run do
        Puppet::Module::Tool::Applications::Generator.run(@full_module_name)
        Puppet::Module::Tool::Applications::Builder.run(@full_module_name)

        metadata_file = File.join(@full_module_name, "pkg", @release_name, "metadata.json")
        metadata = PSON.parse(File.read(metadata_file))
        metadata["checksums"].should be_a_kind_of(Hash)

        modulefile_path = Pathname.new(File.join(@full_module_name, "Modulefile"))
        metadata["checksums"]["Modulefile"].should == Digest::MD5.hexdigest(modulefile_path.read)
      end
    end

    it "should build a module's types and providers" do
      run do
        name = "jamtur01-apache"
        install_release_fixture name
        Puppet::Module::Tool::Applications::Builder.run(name)

        metadata_file = File.join(name, "pkg", "#{name}-0.0.1", "metadata.json")
        metadata = PSON.parse(File.read(metadata_file))

        metadata["types"].size.should == 1
        type = metadata["types"].first
        type["name"].should == "a2mod"
        type["doc"].should == "Manage Apache 2 modules"


        type["parameters"].size.should == 1
        type["parameters"].first.tap do |o|
          o["name"].should == "name"
          o["doc"].should == "The name of the module to be managed"
        end

        type["properties"].size.should == 1
        type["properties"].first.tap do |o|
          o["name"].should == "ensure"
          o["doc"].should =~ /present.+absent/
        end

        type["providers"].size.should == 1
        type["providers"].first.tap do |o|
          o["name"].should == "debian"
          o["doc"].should =~ /Manage Apache 2 modules on Debian-like OSes/
        end
      end
    end

    it "should build a module's dependencies" do
      run do
        Puppet::Module::Tool::Applications::Generator.run(@full_module_name)
        modulefile = File.join(@full_module_name, "Modulefile")

        dependency1_name = "anotheruser-anothermodule"
        dependency1_requirement = ">= 1.2.3"
        dependency2_name = "someuser-somemodule"
        dependency2_requirement = "4.2"
        dependency2_repository = "http://some.repo"

        File.open(modulefile, "a") do |handle|
          handle.puts "dependency '#{dependency1_name}', '#{dependency1_requirement}'"
          handle.puts "dependency '#{dependency2_name}', '#{dependency2_requirement}', '#{dependency2_repository}'"
        end

        Puppet::Module::Tool::Applications::Builder.run(@full_module_name)

        metadata_file = File.join(@full_module_name, "pkg", "#{@full_module_name}-#{@version}", "metadata.json")
        metadata = PSON.parse(File.read(metadata_file))

        metadata['dependencies'].size.should == 2
        metadata['dependencies'].sort_by{|t| t['name']}.tap do |dependencies|
          dependencies[0].tap do |dependency1|
            dependency1['name'].should == dependency1_name
            dependency1['version_requirement'].should == dependency1_requirement
            dependency1['repository'].should be_nil
          end

          dependencies[1].tap do |dependency2|
            dependency2['name'].should == dependency2_name
            dependency2['version_requirement'].should == dependency2_requirement
            dependency2['repository'].should == dependency2_repository
          end
        end
      end
    end

    it "should rebuild a module in a directory" do
      run do
        Puppet::Module::Tool::Applications::Generator.run(@full_module_name)
        Puppet::Module::Tool::Applications::Builder.run(@full_module_name)
        Puppet::Module::Tool::Applications::Builder.run(@full_module_name)
      end
    end

    it "should build a module in the current directory" do
      run do
        Puppet::Module::Tool::Applications::Generator.run(@full_module_name)
        Dir.chdir(@full_module_name)
        Puppet::Module::Tool::Applications::Builder.run(Puppet::Module::Tool.find_module_root(nil))

        File.file?(File.join("pkg", @release_name + ".tar.gz")).should == true
      end
    end

    it "should fail to build a module without a Modulefile" do
      run do
        Puppet::Module::Tool::Applications::Generator.run(@full_module_name)
        FileUtils.rm(File.join(@full_module_name, "Modulefile"))

        lambda { Puppet::Module::Tool::Applications::Builder.run(Puppet::Module::Tool.find_module_root(@full_module_name)) }.should raise_error(ArgumentError)
      end
    end

    it "should fail to build a module directory that doesn't exist" do
      run do
        lambda { Puppet::Module::Tool::Applications::Builder.run(Puppet::Module::Tool.find_module_root(@full_module_name)) }.should raise_error(ArgumentError)
      end
    end

    it "should fail to build a module in the current directory that's not a module" do
      run do
        lambda { Puppet::Module::Tool::Applications::Builder.run(Puppet::Module::Tool.find_module_root(nil)) }.should raise_error(ArgumentError)
      end
    end

    it "should return a Pathname object representing the path to the release archive." do
      run do
        Puppet::Module::Tool::Applications::Generator.run(@full_module_name)
        Puppet::Module::Tool::Applications::Builder.run(@full_module_name).should be_kind_of(Pathname)
      end
    end
  end

  describe "search" do
    it "should display matching modules" do
      run do
        stub_repository_read 200, <<-HERE
          [
            {"full_module_name": "cli", "version": "1.0"},
            {"full_module_name": "web", "version": "2.0"}
          ]
        HERE
        Puppet::Module::Tool::Applications::Searcher.run("mymodule", @options).size.should == 2
      end
    end

    it "should display no matches" do
      run do
        stub_repository_read 200, "[]"
        Puppet::Module::Tool::Applications::Searcher.run("mymodule", @options).should == []
      end
    end

    it "should fail if can't get a connection" do
      run do
        stub_repository_read 500, "OH NOES!!1!"
        lambda { Puppet::Module::Tool::Applications::Searcher.run("mymodule", @options) }.should raise_error(RuntimeError)
      end
    end

    it "should return an array of module metadata hashes" do
      run do
        results = <<-HERE
          [
            {"full_module_name": "cli", "version": "1.0"},
            {"full_module_name": "web", "version": "2.0"}
          ]
        HERE
        expected = [
          {"version"=>"1.0", "full_module_name"=>"cli"},
          {"version"=>"2.0", "full_module_name"=>"web"}
        ]
        stub_repository_read 200, results
        return_value = Puppet::Module::Tool::Applications::Searcher.run("mymodule", @options)
        return_value.should == expected
        return_value.should be_kind_of(Array)
      end
    end
  end

  describe "install" do
    it "should install a module to the puppet modulepath by default" do
      myothertmpdir = Pathname.new(tmpdir("module_tool_test_myothertmpdir"))
      run do
        @options[:install_dir] = myothertmpdir
        Puppet::Module::Tool.unstub(:install_dir)

        build_and_install_module

        File.directory?(myothertmpdir + @module_name).should == true
        File.file?(myothertmpdir + @module_name + 'metadata.json').should == true
      end
    end

    it "should install a module from a filesystem path" do
      run do
        build_and_install_module

        File.directory?(@mytmpdir + @module_name).should == true
        File.file?(@mytmpdir + @module_name + 'metadata.json').should == true
      end
    end

    it "should install a module from a webserver URL" do
      run do
        Puppet::Module::Tool::Applications::Generator.run(@full_module_name)
        Puppet::Module::Tool::Applications::Builder.run(@full_module_name)

        stub_cache_read File.read("#{@full_module_name}/pkg/#{@release_name}.tar.gz")
        FileUtils.rm_rf(@full_module_name)

        stub_installer_read <<-HERE
          {"file": "/foo/bar/#{@release_name}.tar.gz", "version": "#{@version}"}
        HERE

        Puppet::Module::Tool::Applications::Installer.run(@full_module_name, @options)

        File.directory?(@mytmpdir + @module_name).should == true
        File.file?(@mytmpdir + @module_name + 'metadata.json').should == true
      end
    end

    it "should install a module from a webserver URL using a version requirement" # TODO

    it "should fail if module isn't a slashed name" do
      run do
        lambda { Puppet::Module::Tool::Applications::Installer.run("invalid") }.should raise_error(RuntimeError)
      end
    end

    it "should fail if module doesn't exist on webserver" do
      run do
        stub_installer_read "{}"
        lambda { Puppet::Module::Tool::Applications::Installer.run("not-found", @options) }.should raise_error(RuntimeError)
      end
    end

    it "should fail gracefully when receiving invalid PSON" do
      pending "Implement PSON error wrapper" # TODO
      run do
        stub_installer_read "1/0"
        lambda { Puppet::Module::Tool::Applications::Installer.run("not-found") }.should raise_error(SystemExit)
      end
    end

    it "should fail if installing a module that's already installed" do
      run do
        name = "myuser-mymodule"
        Dir.mkdir name
        lambda { Puppet::Module::Tool::Applications::Installer.run(name) }.should raise_error(ArgumentError)
      end
    end

    it "should return a Pathname object representing the path to the installed module" do
      run do
        Puppet::Module::Tool::Applications::Generator.run(@full_module_name)
        Puppet::Module::Tool::Applications::Builder.run(@full_module_name)

        stub_cache_read File.read("#{@full_module_name}/pkg/#{@release_name}.tar.gz")
        FileUtils.rm_rf(@full_module_name)

        stub_installer_read <<-HERE
          {"file": "/foo/bar/#{@release_name}.tar.gz", "version": "#{@version}"}
        HERE

        Puppet::Module::Tool::Applications::Installer.run(@full_module_name, @options).should be_kind_of(Pathname)
      end
    end

  end

  describe "clean" do
    require 'puppet/module_tool'
    it "should clean cache" do
      run do
        build_and_install_module
        Puppet::Module::Tool::Cache.base_path.directory?.should == true
        Puppet::Module::Tool::Applications::Cleaner.run
        Puppet::Module::Tool::Cache.base_path.directory?.should == false
      end
    end

    it "should return a status Hash" do
      run do
        build_and_install_module
        return_value = Puppet::Module::Tool::Applications::Cleaner.run
        return_value.should include(:msg)
        return_value.should include(:status)
        return_value.should be_kind_of(Hash)
      end
    end
  end

  describe "changes" do
    it "should return an array of modified files" do
      run do
        Puppet::Module::Tool::Applications::Generator.run(@full_module_name)
        Puppet::Module::Tool::Applications::Builder.run(@full_module_name)
        Dir.chdir("#{@full_module_name}/pkg/#{@release_name}")
        File.open("Modulefile", "a") do |handle|
          handle.puts
          handle.puts "# Added"
        end
        return_value = Puppet::Module::Tool::Applications::Checksummer.run(".")
        return_value.should include("Modulefile")
        return_value.should be_kind_of(Array)
      end
    end
  end
end