summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2013-09-27selftest: Add script to assist in writing out a tree undump.sh can restoreAndrew Bartlett1-0/+48
Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 9b8e174fe8cac61cfcfa1c76e8cab2450e4a0af5)
2013-09-27dbcheck: Look for and fix the all-zero invocationID in replPropertyMetaDataAndrew Bartlett1-0/+68
Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 9e1dde15f9d3a374747d163e37016b54f008bd9f)
2013-09-27dsdb: Refuse to replicate an all-zero invocationID GUID in replPropertyMetaDataAndrew Bartlett1-0/+9
This matches Windows 2008R2. Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 25d4bafca7245e3f8291e5f0f304b1b4f8ce5600)
2013-09-27smb.conf: Fill out the ntvfs handler smb.conf page from source4/NEWSAndrew Bartlett1-0/+13
Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 274b899095645550e263564ae4e03b4f0d6bdbea)
2013-09-27Remove NEWS file containing confusing informationAndrew Bartlett1-496/+0
Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 334d83e4e7821b3f2ac54ef11f67aefaa564b00b)
2013-09-27Remove confusing TODO fileAndrew Bartlett1-276/+0
This makes no sense in the merged tree, and only confuses users. Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 8d9986a6e9cb8c633c57c84c4d6aefd21e181c40)
2013-09-27dsdb: Use WERR_DS_ATT_NOT_DEF_IN_SCHEMA for failed schema lookupsAndrew Bartlett1-28/+28
Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 53c06d03a880319cf67a99250958cce16147f181)
2013-09-27dsdb-repl_meta_data: Make handling of Deleted Objects DN clearer in deleteAndrew Bartlett1-5/+10
This code no longer needs to handle not renaming Deleted Objects during a re-delete, because it is no longer called in that case. Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit aa07b5caf9ac13fc517c4c9d21f16ebff5415544)
2013-09-27dsdb-repl_meta_data: Do not re-delete the Deleted Objects DN during replicationAndrew Bartlett1-3/+5
We need to ensure we do not re-delete the Deleted Objects DN during replication. It itself not entirely a deleted object, but has isDeleted set. Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit c42db8975f8f84ce576c97ad95ca59ba5170d596)
2013-09-27dsdb: Refuse to return an all-zero invocationIDAndrew Bartlett1-0/+8
This could cause an all-zero GUID to be entered into the replPropertyMetaData, which will then fail to be replicated to other DCs. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 4022d8632cc092f4f43fae69cc3cfb58d0d000dd)
2013-09-27dsdb-repl_meta_data: Check for a NULL invocationID and do not proceedAndrew Bartlett1-0/+4
This can happen if we do not find the invocationID, with later patches. Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 40f99625ee4447aa36c0fa5631ffa13b7003569f)
2013-09-27python/drs: Ensure to pass in the local invocationID during the domain joinAndrew Bartlett6-8/+30
This ensures (and asserts) that we never write an all-zero GUID as an invocationID to the database in replPropertyMetaData. Andrew Bartlett Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit a623359fb8a54083b81436d14b7ba022c11efb18)
2013-09-26WHATSNEW: Add changes since 4.1.0rc3.Karolin Seeger1-1/+44
Signed-off-by: Karolin Seeger <kseeger@samba.org> Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Thu Sep 26 13:39:19 CEST 2013 on sn-devel-104
2013-09-26torture3: Trigger a nasty cleanup bug in smbdVolker Lendecke4-0/+73
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue Sep 3 19:13:14 CEST 2013 on sn-devel-104 (cherry picked from commit ade8477f98fcffcc6e3c5ea31618b49d0c1bba95) The last 5 patches address bug #10138 - smbd doesn't always clean up share modes after hard crash. Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Thu Sep 26 11:33:29 CEST 2013 on sn-devel-104
2013-09-26smbd: Fix flawed share_mode_stale_pid APIVolker Lendecke3-9/+56
The comment for this routine said: > Modifies d->num_share_modes, watch out in routines iterating over > that array. Well, it turns out that *every* caller of this API got it wrong. So I think it's better to change the routine. This leaves the array untouched while iterating but filters out the deleted ones while saving them back to disk. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 7d91ffc6fdc3b371564e14f09822a96264ea372a)
2013-09-26smbd: Rename parameter "i" to "idx"Volker Lendecke2-7/+7
We'll need "i" in a later checkin ... :-) Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 5006db98aaf1efe119f1da8be091587a9bc2b952)
2013-09-26smbd: Don't store in-memory only flags in locking.tdbVolker Lendecke1-2/+2
Hey, pidl knows the [skip] attribute ... :-) Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 696bc569b17f024f840774e3d59761229836a310)
2013-09-26smbd: Simplify find_oplock_typesVolker Lendecke1-9/+10
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 94b320527eee0c7ba1d3818816e7d59cb863bf3f)
2013-09-25python-samba-tool fsmo: Do not give an error on a successful role transferAndrew Bartlett1-7/+7
Bug: https://bugzilla.samba.org/show_bug.cgi?id=9461 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Sep 23 12:00:24 CEST 2013 on sn-devel-104 (cherry picked from commit 8d8872ae0a19786452c3be044757b16814b82be8) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Wed Sep 25 10:47:35 CEST 2013 on sn-devel-104
2013-09-23Fix bug 10162 - POSIX ACL mapping failing when setting DENY ACE's from Windows.Daniel Liberman1-1/+1
Fix for ACL problem - not accepting DENY. Code was checking for pointer and not for content. Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Sat Sep 21 05:24:07 CEST 2013 on sn-devel-104 (cherry picked from commit e24fcf0f3e1b5b19d97a13786b09f069393b06d8) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Mon Sep 23 11:19:50 CEST 2013 on sn-devel-104
2013-09-23docs: point out side-effects of global "valid users" setting.Günther Deschner1-0/+10
Guenther Signed-off-by: Günther Deschner <gd@samba.org> Fix bug #10147 - Better document potential implications of a globally used "valid users".
2013-09-20VERSION: Set version to 4.1.0rc4.Karolin Seeger1-1/+1
Signed-off-by: Karolin Seeger <kseeger@samba.org> Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Fri Sep 20 13:26:22 CEST 2013 on sn-devel-104
2013-09-20libcli: continue to read from the socket even if the size is 0Matthieu Patou1-1/+1
This is an issue found by Codenomicon, with a malicious packet with 0 bytes UDP payload we will continiously be looping trying to react from the socket event and continiously do nothing as we will bail out thinking that we had a memory allocation error. Original fix comes from Volker Lendecke <vl@samba.org> Signed-off-by: Matthieu Patou <mat@matws.net> Fix bug #10158 - netbios related samba process consume 100% CPU.
2013-09-19s3: libsmb - 10150 - Not all OEM servers support the ALTNAME info level.Jeremy Allison1-3/+4
Sigh. Some OEM servers return NT_STATUS_NOT_IMPLEMENTED not NT_STATUS_NOT_SUPPORTED. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> (cherry picked from commit 75f353b857d50291672adefc6eefd210c9e8a0f7) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Thu Sep 19 12:06:58 CEST 2013 on sn-devel-104
2013-09-19s3: libsmb : Bug 10150 - Not all OEM servers support the ALTNAME info level.Jeremy Allison1-1/+9
Just ignore and print error message and an altname of "" if the server returns NT_STATUS_NOT_SUPPORTED. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Sep 17 23:40:08 CEST 2013 on sn-devel-104 (cherry picked from commit 17a9a0f37bbb730d09b3a57b00665d44aac18ea6)
2013-09-19s3: libsmb SMB2 wrapper layer. cli_smb2_get_ea_list_path() failed to close ↵Jeremy Allison1-0/+4
file on exit. Found at SNIA SDC plugfest. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> (cherry picked from commit cdc280deb1e6f99ec9eae05d75bc1104448662ef) Fix bug #10149 - cli_smb2_get_ea_list_path() failed to close file on exit.
2013-09-19libcli/smb: only check the SMB2 session setup signature if required and validStefan Metzmacher1-5/+21
This is an update to commit af290a03cef63c3b08446c1980de064a3b1c8804 that skips the scary debug messages. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10146 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Sep 18 04:46:00 CEST 2013 on sn-devel-104 (cherry picked from commit 4879d0810a2ad741e32ad174a7a14cd35521aeaf)
2013-09-19libcli/smb: fix non mendatory signing against some vendor SMB2 servers.Stefan Metzmacher1-1/+10
Windows and Samba always sign the final session setup response even if signing is not mendatory, but it ensures that the signing key is correctly in place. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10146 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Sep 17 09:40:10 CEST 2013 on sn-devel-104 (cherry picked from commit af290a03cef63c3b08446c1980de064a3b1c8804)
2013-09-19Fix is_legal_name() to not emit character conversion error messages.Jeremy Allison1-12/+8
Using next_codepoint() does the same check, but without the conversion message. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> (cherry picked from commit 776db7d38597a29536e4127837ffa3b4f4ce35ab) Fix bug #10139 - valid utf8 filenames cause "invalid conversion error" messages.
2013-09-18s3: libsmb : The short name length is only a one byte field.Jeremy Allison1-1/+1
The next byte is "undefined" and some vendors set this to 0xff (discovered in SNIA SDC lab tests). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Sep 17 12:27:18 CEST 2013 on sn-devel-104 (cherry picked from commit 1c41feb7893ae4a4f42c035f3c83f8b2950b7816) Fix bug #10145 - Samba SMB2 client code reads the wrong short name length in a directory listing reply. Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Wed Sep 18 11:15:35 CEST 2013 on sn-devel-104
2013-09-18libcli/smb: use SMB1 MID=0 for the initial NegprotStefan Metzmacher1-0/+8
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10144 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 1d54d8c501afa151b6cc07b98a14caae2b31ec65)
2013-09-16s3:smb2_find: Return that timestamps do not exist as directoriesChristof Schmitt3-3/+16
When a Windows client receives a large directory listing while querying snapshots, it sends a find request asking for the timestamp as a directory. A Windows server returns NO_SUCH_FILE, so make sure Samba returns the same. Otherwise the client will get confused and display timestamps in the 'previous versions' dialog. Signed-off-by: Christof Schmitt <christof.schmitt@us.ibm.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Sep 10 22:38:51 CEST 2013 on sn-devel-104 (cherry picked from commit c8c0632c871e838fc4465b2a69b4e059e9a126c0) Fix bug #10137 - shadow_copy2 does not display previous versions correctly over SMB2. Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Mon Sep 16 11:33:39 CEST 2013 on sn-devel-104
2013-09-12docs: Fix typos.Karolin Seeger1-3/+3
This is a follow-up patch for bug #10134 - Samba 4.0 is stricter in checking acls for "open for execution". Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Sep 12 11:59:56 CEST 2013 on sn-devel-104 (cherry picked from commit 4af7b709e925d85be9446af179186fc13466626f) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Thu Sep 12 14:22:19 CEST 2013 on sn-devel-104
2013-09-12Raise the level of a debug.Korobkin1-1/+1
Bug #10118 - Samba is chatty about being unable to open a printer Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Sep 11 03:10:08 CEST 2013 on sn-devel-104 (cherry picked from commit d809cf653b624a9fde48de3b0c2ab58aca705c50) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Thu Sep 12 11:36:59 CEST 2013 on sn-devel-104
2013-09-12WHATSNEW: Start to add changes since 4.1.0rc3.Karolin Seeger1-0/+12
Signed-off-by: Karolin Seeger <kseeger@samba.org>
2013-09-12docs: document "acl allow execute always"Michael Adam1-0/+26
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Wed Sep 11 01:21:00 CEST 2013 on sn-devel-104 (cherry picked from commit a2a3c9f36d7a19d75924cff25fa1b450d85ee6d6) The last 3 patches adress bug #10134 - Samba 4.0 is stricter in checking acls for "open for execution".
2013-09-12s3:smbd: ease file server upgrades from 3.6 and earlier with "acl allow ↵Michael Adam1-1/+15
execute aways" 3.6 and earlier allowed open for execution when execute permissions are not present on a file. This has been fixed in Samba 4.0. This patch changes smbd to skip the execute bit from the ACL check in the open code if "acl allow execute always = yes", hence re-establishing the old behaviour in this case. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> (cherry picked from commit 1e29d730663382875d96c275c60e022a1c33a2d1)
2013-09-12loadparm: add new parameter "acl allow execute always"Michael Adam4-0/+13
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> (cherry picked from commit de3bc10ef69f23e7dab9fc3f6990bb403824b14e)
2013-09-12dbwrap_ctdb: Treat empty records as non-existingVolker Lendecke2-0/+18
This is a patch implementing the workaround Christian mentioned in https://bugzilla.samba.org/show_bug.cgi?id=10008#c5 Bug: https://bugzilla.samba.org/show_bug.cgi?id=10008 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org> (cherry picked from commit 1cae59ce112ccb51b45357a52b902f80fce1eef1)
2013-09-09VERSION: Bump version number up to 4.1.0...Karolin Seeger1-2/+2
and re-enable git snapshots. Signed-off-by: Karolin Seeger <kseeger@samba.org>
2013-09-09VERSION: Disable git snapshots for the 4.1.0rc3 release.Karolin Seeger1-1/+1
Signed-off-by: Karolin Seeger <kseeger@samba.org>
2013-09-06WHATSNEW: Update changes since 4.1.0rc2.Karolin Seeger1-0/+13
Signed-off-by: Karolin Seeger <kseeger@samba.org> Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Fri Sep 6 12:59:28 CEST 2013 on sn-devel-104
2013-09-06Optimization. Don't do the retry logic if sitename_fetch() returned NULL, we ↵Jeremy Allison1-1/+5
already did a NULL query. Bug 5917 - Samba does not work on site with Read Only Domain Controller Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Sep 4 01:19:05 CEST 2013 on sn-devel-104 (cherry picked from commit bdab6f9431715fbfd28f8cc0dfb4dde2966f22f3)
2013-09-06Move the retry logic when site_name is passed in a NULL or "" to the wrapper ↵Jeremy Allison1-4/+21
function. Bug 5917 - Samba does not work on site with Read Only Domain Controller Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Richard Sharpe <rsharpe@samba.org> (cherry picked from commit 68e7b1c9446c7d1274b0fb85b59b90ac1a7f6041)
2013-09-06Move the manipulation of site_name into the caller function dsgetdcname().Jeremy Allison1-15/+19
Leave dsgetdcname_internal() only using const char *site_name. Bug 5917 - Samba does not work on site with Read Only Domain Controller Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Richard Sharpe <rsharpe@samba.org> (cherry picked from commit 181c11066bd53b07015a199f56eb71182e89ff71)
2013-09-06Refactor dsgetdcname to be called via a wrapper function.Jeremy Allison1-5/+26
Bug 5917 - Samba does not work on site with Read Only Domain Controller Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Richard Sharpe <rsharpe@samba.org> (cherry picked from commit 66006be7ef703b2935334633d27641050cee5f58)
2013-09-06dsgetdcname_cache_fetch() doesn't use the site_name parameter so don't pass it.Jeremy Allison1-2/+1
Bug 5917 - Samba does not work on site with Read Only Domain Controller Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Richard Sharpe <rsharpe@samba.org> (cherry picked from commit dd12bfbcbf359c1642cc2e968aec62ae904aad5d)
2013-09-06smbd: Correctly return INFO_LENGTH_MISMATCH for smb1Volker Lendecke1-0/+4
This is required if the client offered less buffer than the fixed portion of the info level data requires Bug: https://bugzilla.samba.org/show_bug.cgi?id=10106 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 1b1935b876a14154ef74e447bf53eb7cd0a5dde9)
2013-09-06smbd: Fix error return for STREAM_INFOVolker Lendecke1-0/+4
The stream_info marshalling follows its own rules. This needs unifying eventually... Bug: https://bugzilla.samba.org/show_bug.cgi?id=10106 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 5634f240fd4273cb7327111140ccbea0fd41e3fc)
2013-09-06smbd: Revert a93f9c3Volker Lendecke1-5/+0
This was too broad and has been replaced by finer-grained error checks Bug: https://bugzilla.samba.org/show_bug.cgi?id=10106 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit b37edda32930fec372d6467d442f67532c3fbd33)