summaryrefslogtreecommitdiff
path: root/source3/client/client.c
AgeCommit message (Collapse)AuthorFilesLines
2014-12-04s3-smbclient: Return success if we listed the shares.Andreas Schneider1-1/+1
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10960 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2014-06-10s3: client : Add extra return parameter to all client open calls.Jeremy Allison1-5/+5
Add a return parameter of struct smb_create_returns *cr to cli_ntcreate() cli_ntcreate_recv() cli_nttrans_create() cli_nttrans_create_recv() Always pass in NULL for now. This fixes the create API to always fully return the data the server has given back to us on the open file to the caller. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit 69e24b4e8bc607806453ab137efda6d6bf74fb12)
2014-04-04client: use cli_qpathinfo3 for allinfoGregor Beck1-2/+2
Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2014-04-04client: remove a write only variableGregor Beck1-2/+1
Signed-off-by: Gregor Beck <gbeck@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2014-04-01s3:client: only limit the buffer by the given length 'n'Stefan Metzmacher1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit f0f245f4c8b1a506e8d06c72d3d6680b95738714)
2013-09-19s3: libsmb - 10150 - Not all OEM servers support the ALTNAME info level.Jeremy Allison1-3/+4
Sigh. Some OEM servers return NT_STATUS_NOT_IMPLEMENTED not NT_STATUS_NOT_SUPPORTED. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> (cherry picked from commit 75f353b857d50291672adefc6eefd210c9e8a0f7) Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Thu Sep 19 12:06:58 CEST 2013 on sn-devel-104
2013-09-19s3: libsmb : Bug 10150 - Not all OEM servers support the ALTNAME info level.Jeremy Allison1-1/+9
Just ignore and print error message and an altname of "" if the server returns NT_STATUS_NOT_SUPPORTED. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Sep 17 23:40:08 CEST 2013 on sn-devel-104 (cherry picked from commit 17a9a0f37bbb730d09b3a57b00665d44aac18ea6)
2013-08-30client: add missing newlines to error messages for invalid iosize parameter.Michael Adam1-2/+2
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Aug 21 21:49:45 CEST 2013 on sn-devel-104 (cherry picked from commit db1d0349c4d898141a39f515c690e21409448d56) The last 70 patches address bug #9974 - smbclient does not support SMB2. Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-1-test): Fri Aug 30 13:50:13 CEST 2013 on sn-devel-104
2013-08-30Add new "timeout" command and -t option to smbclient to set the ↵Jeremy Allison1-0/+35
per-operation timeout. This is needed as once SMB3 encryption is selected the server response time can be very slow when requesting large numbers (256) of large encrypted packets (1MB) from a Windows 2012 virtual machine. This allows clients to tune their allowable wait time. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit d9c88a56dc451be09e8c9fc9aa8857e312fcb444)
2013-08-30Remove restrictions on setting iosize inside smbclient for SMB2 connections.Jeremy Allison1-17/+23
Also remove the SMB1 restriction to minimum iosize of 16384 (0x4000): Now values >= 0 and <= 0xFFFF00 can be set for SMB1, 0 meaning server defined behaviour. 0 is the new default for iosize, both for SMB1 and SMB2. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> (cherry picked from commit 25521c90859de0651216c459273b2ffd916ee299)
2013-08-30s3:client: fix compiler warningStefan Metzmacher1-1/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 2394f8788d2f6e21064db0b6099a0dbe3a33e1d6)
2013-08-30s3:client: use the default io sizeStefan Metzmacher1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 9b4692f2d057f31f76db0bdf7c4a515db057e2dd)
2013-08-30s3:client: avoid interpret_protocol()Stefan Metzmacher1-2/+4
lp_set_cmdline("client max protocol",...) and lp_cli_maxprotocol() are the more generic solution. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 861ee9319f3cce8f104fd30c7139323ac3d3319d)
2013-06-24s3/smbclient: fix incorrect command tab completionsDavid Disseldorp1-8/+8
smbclient commands can offer tab-completion for local and remote paths. This behaviour is specified for the first two arguments using the compl_args entry in the commands struct. This change fixes a number of incorrectly specified compl_args values. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Aurélien Aptel <aurelien.aptel@gmail.com> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Mon Jun 24 19:32:54 CEST 2013 on sn-devel-104
2013-03-06Make sure to set umask() before calling mkstemp().Andreas Schneider1-0/+3
Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Wed Mar 6 01:16:34 CET 2013 on sn-devel-104
2013-02-07BUG 9633: Recursive mget should continue on EPERM.David Disseldorp1-2/+11
Regression introduced by 14ff2e8de9bd8d0064762234555260f5eea643fe. When downloading files recursively, smbclient halts if it encounters a folder to which it does not have permission to traverse. Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Feb 7 15:50:36 CET 2013 on sn-devel-104
2012-12-06Clean up client timeout definitions [rev. 2]Scott Lovenberg1-4/+0
The definitions for default client timeout values have been moved to client.h. When initializing a client struct we use this value instead of the old hardcoded value. The timeout value remains 20 seconds. Signed-off-by: Scott Lovenberg <scott.lovenberg@gmail.com> Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Dec 6 03:25:58 CET 2012 on sn-devel-104
2012-12-03smbclient: Use new samba_getpass() function.Andreas Schneider1-3/+6
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
2012-11-08s3fs-client: Burn commandline password of client utils.Andreas Schneider1-0/+2
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Nov 8 21:24:21 CET 2012 on sn-devel-104
2012-09-25client: Fix talloc_stackframe() free order assertion in developer modeAndrew Bartlett1-0/+1
Reported-by: Ricky Nance <ricky.nance@weaubleau.k12.mo.us>
2012-09-10s3:client use more access bits for snapshot displayChristian Ambach1-1/+2
otherwise Windows server will reject the request for shadow copy enumeration with access denied
2012-08-09Correctly check for errors in strlower_m() returns.Jeremy Allison1-2/+7
2012-07-19s3-param: Make lp_name_resolve_order() return a listAndrew Bartlett1-1/+1
This allows this parameter, one of the few with differing declarations between the loadparm systems, to be brought into common. Andrew Bartlett Pair-Programmed-With: Andrew Tridgell <tridge@samba.org>
2012-07-18loadparm: make the source3/ lp_ functions take an explicit TALLOC_CTX *.Rusty Russell1-1/+1
They use talloc_tos() internally: hoist that up to the callers, some of whom don't want to us talloc_tos(). A simple patch, but hits a lot of files. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2012-07-18source3/client/client.c: fix stackframe leak.Rusty Russell1-13/+7
do_message_op() doesn't free its stackframe in various paths. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2012-05-28s3:libsmb: get rid of cli_state_protocolLuk Claes1-1/+1
Signed-off-by: Luk Claes <luk@debian.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-28s3:libsmb: get rid of cli_state_remote_nameLuk Claes1-1/+2
Signed-off-by: Luk Claes <luk@debian.org> Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-04-16s3: Fix smbclient notify against WindowsVolker Lendecke1-1/+1
We need READ_DATA Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Mon Apr 16 21:27:54 CEST 2012 on sn-devel-104
2012-04-06build: Remove SMB_OFF_T, replace with off_tAndrew Bartlett1-5/+5
Now that we always require a 64 bit off_t, we no longer need SMB_OFF_T. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Fri Apr 6 01:47:43 CEST 2012 on sn-devel-104
2012-04-05build: Remove SMB_STRUCT_DIR defineAndrew Bartlett1-1/+1
2012-04-05build: Remove sys_closedir wrapperAndrew Bartlett1-3/+3
2012-04-05build: Remove sys_opendir wrapperAndrew Bartlett1-1/+1
2012-04-05build: Remove sys_open wrapperAndrew Bartlett1-2/+2
2012-04-05build: Remove sys_lseek wrapperAndrew Bartlett1-1/+1
2012-03-24lib/util: Remove obsolete sys_getpid() and sys_fork().Jelmer Vernooij1-2/+2
The performance of these is minimal (these days) and they can return invalid results when used as part of applications that do not use sys_fork(). Autobuild-User: Jelmer Vernooij <jelmer@samba.org> Autobuild-Date: Sat Mar 24 21:55:41 CET 2012 on sn-devel-104
2012-03-22s3:client correct a wordingChristian Ambach1-1/+1
2012-03-22s3: Add "notify" cmd to smbclientVolker Lendecke1-0/+57
Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Thu Mar 22 13:51:50 CET 2012 on sn-devel-104
2012-02-16Rename obscure defined constants.Christopher R. Hertel (crh)1-4/+5
Replaced the undescriptive SMB_PORT1 and SMB_PORT2 defined constants with the slightly more descriptive names NBT_SMB_PORT and TCP_SMB_PORT. Also replaced several hard-coded references to the well-known port numbers (139 and 445, respectively) as appropriate. Small changes to clarify some comments regarding the two transport types. Signed-off-by: Simo Sorce <idra@samba.org> Autobuild-User: Simo Sorce <idra@samba.org> Autobuild-Date: Thu Feb 16 08:29:41 CET 2012 on sn-devel-104
2012-01-31s3:client: ignore SMBecho errors (the server may not support it) (bug #8139)Stefan Metzmacher1-3/+7
metze
2012-01-31Revert "Fix bug #8139 - smbclient fails if server does not support Echo ↵Stefan Metzmacher1-5/+1
request." This reverts commit 1fdc96ecaff8ca12e9aa0082527468ad4242a8a9. This is wrong in master as the error codes are different compared to 3.5.x. The correct way to handle this is to call cli_state_is_connected(). metze
2012-01-31Fix bug #8139 - smbclient fails if server does not support Echo request.Jeremy Allison1-1/+5
Based on work by Matthias Scheler <tron@NetBSD.org> Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Tue Jan 31 00:47:19 CET 2012 on sn-devel-104
2012-01-25Introduce dump_data_fileVolker Lendecke1-7/+2
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Jan 25 11:57:18 CET 2012 on sn-devel-104
2011-12-03Move the callers that need to use the new cli_open() back to callingJeremy Allison1-118/+3
it from cli_openx().
2011-12-03Rename cli_open -> cli_openx. Prelude to replacing generic cli_open()Jeremy Allison1-1/+1
with a call that uses NTCreateX in preference to OpenAndX.
2011-12-02Ensure we map our own Samba return of ERRSRV, ERRunknownsmbJeremy Allison1-0/+3
on an unknown SMB request to NT_STATUS_NOT_IMPLEMENTED.
2011-12-02Convert smbclient to using NtCreateX by preference, fall back to openX onJeremy Allison1-3/+115
'not implemented' or similar error.
2011-12-02Add the "backup" toggle command to smbclient. In order for this to beJeremy Allison1-0/+14
really useful we need to change to using NTCreateX opens by default in cli_open() and fall back to old OpenX calls instead of doing it the other way around. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Dec 2 00:23:13 CET 2011 on sn-devel-104
2011-11-24s3:client: make use of cli_tree_connect()Stefan Metzmacher1-1/+1
metze
2011-11-03s3:client: s/Undefined/SMB_SIGNING_DEFAULT/Stefan Metzmacher1-1/+1
metze
2011-09-29Bug 7551: Return error of cli_push when 'put - /some/file' is usedBram1-1/+1
Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Sep 29 23:47:02 CEST 2011 on sn-devel-104