From 08cd421d679b5e76c9703a4d9fe1ecbae777587f Mon Sep 17 00:00:00 2001 From: bubulle Date: Thu, 25 Feb 2010 21:51:02 +0000 Subject: merge upstream 3.4.6 git-svn-id: svn://svn.debian.org/svn/pkg-samba/trunk/samba@3323 fc4039ab-9d04-0410-8cac-899223bdd6b0 --- docs/htmldocs/Samba3-Developers-Guide/contributing.html | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'docs/htmldocs/Samba3-Developers-Guide/contributing.html') diff --git a/docs/htmldocs/Samba3-Developers-Guide/contributing.html b/docs/htmldocs/Samba3-Developers-Guide/contributing.html index c94cceecdd..696d7cd0c0 100644 --- a/docs/htmldocs/Samba3-Developers-Guide/contributing.html +++ b/docs/htmldocs/Samba3-Developers-Guide/contributing.html @@ -1,4 +1,4 @@ -Chapter 7. Contributing code
Chapter 7. Contributing code
Prev Part II. Samba Basics Next

Chapter 7. Contributing code

Jelmer R. Vernooij

The Samba Team

Here are a few tips and notes that might be useful if you are +Chapter 7. Contributing code

Chapter 7. Contributing code
Prev Part II. Samba Basics Next

Chapter 7. Contributing code

Jelmer R. The Samba Team Vernooij

The Samba Team

Here are a few tips and notes that might be useful if you are interested in modifying samba source code and getting it into samba's main branch.

Retrieving the source

In order to contribute code to samba, make sure you have the latest source. Retrieving the samba source code from CVS is @@ -16,14 +16,14 @@

If you are modifying a copy of samba you retrieved from CVS, you can easily generate a diff file of these changes by running cvs diff -u.

Points of attention when modifying samba source code

-

  • Don't simply copy code from other places and modify it until it +

    • Don't simply copy code from other places and modify it until it works. Code needs to be clean and logical. Duplicate - code is to be avoided.

    • Test your patch. It might take a while before one of us looks + code is to be avoided.

    • Test your patch. It might take a while before one of us looks at your patch so it will take longer before your patch when your patch - needs to go thru the review cycle again.

    • Don't put separate patches in one large diff file. This makes + needs to go thru the review cycle again.

    • Don't put separate patches in one large diff file. This makes it harder to read, understand and test the patch. You might also risk not getting a good patch committed because you mixed it - with one that had issues.

    • Make sure your patch complies to the samba coding style as + with one that had issues.

    • Make sure your patch complies to the samba coding style as suggested in the coding-suggestions chapter.

Sending in bugfixes

Bugfixes to bugs in samba should be submitted to samba's bugzilla system, -- cgit v1.2.3